Browse Source

Fixed some mistakes

Roman Nedzvetskiy 5 years ago
parent
commit
bceb161eba

+ 1 - 2
kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/service/ClusterService.java

@@ -51,7 +51,7 @@ public class ClusterService {
 
     public List<Topic> getTopics(String name) {
         return clustersStorage.getClusterByName(name)
-                .map( c ->
+                .map(c ->
                         c.getTopics().values().stream()
                                 .map(clusterMapper::toTopic)
                                 .collect(Collectors.toList())
@@ -157,6 +157,5 @@ public class ClusterService {
         return clustersStorage.getClusterByName(clusterName)
                 .map(c -> consumingService.loadMessages(c, topicName, consumerPosition, query, limit))
                 .orElse(Flux.empty());
-
     }
 }

+ 1 - 1
kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/util/ClusterUtil.java

@@ -52,7 +52,7 @@ public class ClusterUtil {
         }));
     }
 
-    public static ConsumerGroup convertToConsumerGroup(ConsumerGroupDescription c, KafkaCluster cluster) {
+    public static ConsumerGroup convertToConsumerGroup(ConsumerGroupDescription c) {
         ConsumerGroup consumerGroup = new ConsumerGroup();
         consumerGroup.setConsumerGroupId(c.groupId());
         consumerGroup.setNumConsumers(c.members().size());

+ 4 - 24
kafka-ui-api/src/main/java/com/provectus/kafka/ui/kafka/KafkaService.java

@@ -248,7 +248,7 @@ public class KafkaService {
                 .flatMap(s -> ClusterUtil.toMono(ac.getAdminClient()
                         .describeConsumerGroups(s.stream().map(ConsumerGroupListing::groupId).collect(Collectors.toList())).all()))
                 .map(s -> s.values().stream()
-                        .map(c -> ClusterUtil.convertToConsumerGroup(c, cluster)).collect(Collectors.toList())));
+                        .map(ClusterUtil::convertToConsumerGroup).collect(Collectors.toList())));
     }
 
     public KafkaConsumer<Bytes, Bytes> createConsumer(KafkaCluster cluster) {
@@ -347,26 +347,6 @@ public class KafkaService {
             );
     }
 
-    public Mono<List<JmxMetric>> getClusterJmxMetric(String clusterName) {
-        return clustersStorage.getClusterByName(clusterName)
-                .map(c -> getOrCreateAdminClient(c)
-                        .flatMap(eac -> ClusterUtil.toMono(eac.getAdminClient().describeCluster().nodes()))
-                        .flatMapIterable(n -> n.stream().flatMap(node -> Stream.of(node.host())).collect(Collectors.toList()))
-                        .map(host -> jmxClusterUtil.getJmxMetrics(c.getJmxPort(), host))
-                        .collectList()
-                        .map(s -> s.stream().reduce((s1, s2) -> {
-                            s1.forEach(j1 -> {
-                                s2.forEach(j2 -> {
-                                    if (j1.getCanonicalName().equals(j2.getCanonicalName())) {
-                                        j1.getValue().keySet().forEach(k -> j2.getValue().compute(k, (k1, v1) ->
-                                                JmxClusterUtil.metricValueReduce(j1, j2.getValue().get(k1))));
-                                    }
-                                });
-                            });
-                            return s1;
-                        }).orElseThrow())).orElseThrow();
-    }
-
     public Mono<List<JmxMetric>> getJmxMetric(String clusterName, Integer nodeId) {
         return clustersStorage.getClusterByName(clusterName)
                 .map(c -> getOrCreateAdminClient(c)
@@ -390,7 +370,7 @@ public class KafkaService {
                 }).orElseThrow())
                 .map(i -> {
                     var tempMetrics = new HashMap<>(i.getInternalBrokerMetrics());
-                    tempMetrics.values().stream().flatMap(s -> Stream.of(s.getJmxMetrics())).reduce((s1, s2) -> {
+                    var resultMetrics = tempMetrics.values().stream().flatMap(s -> Stream.of(s.getJmxMetrics())).reduce((s1, s2) -> {
                         s1.forEach(j1 -> {
                             s2.forEach(j2 -> {
                                 if (j1.getCanonicalName().equals(j2.getCanonicalName())) {
@@ -400,8 +380,8 @@ public class KafkaService {
                             });
                         });
                         return s1;
-                    });
-                    return i.toBuilder().jmxMetrics(tempMetrics.values().stream().findFirst().orElseThrow().getJmxMetrics()).build();
+                    }).orElseThrow();
+                    return i.toBuilder().jmxMetrics(resultMetrics).build();
                 });
     }
 }