0ct0pu5/kafka-ui
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[issues-252][bug] - Topic settings form is broken (#332)

Browse source 
add topicName in updateTopic function

Co-authored-by: mbovtryuk <mbovtryuk@provectus.com>
This commit is contained in:
TEDMykhailo 2021-03-31 12:01:43 +03:00 • committed by GitHub
parent d759912c05
commit aedf3c6536
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
kafka-ui-react-app/src/components/Topics/Topic/Edit/Edit.tsx
View file

@ -21,7 +21,11 @@ interface Props {
isFetched: boolean;
isTopicUpdated: boolean;
fetchTopicConfig: (clusterName: ClusterName, topicName: TopicName) => void;
updateTopic: (clusterName: ClusterName, form: TopicFormDataRaw) => void;
updateTopic: (
clusterName: ClusterName,
topicName: TopicName,
form: TopicFormDataRaw
) => void;
}
const DEFAULTS = {
@ -104,7 +108,7 @@ const Edit: React.FC<Props> = ({
});
const onSubmit = async (data: TopicFormDataRaw) => {
updateTopic(clusterName, data);
updateTopic(clusterName, topicName, data);
setIsSubmitting(true); // Keep this action after updateTopic to prevent redirect before update.
};

3
kafka-ui-react-app/src/redux/actions/thunks/topics.ts
View file

@ -234,13 +234,14 @@ export const createTopic = (
export const updateTopic = (
clusterName: ClusterName,
topicName: TopicName,
form: TopicFormDataRaw
): PromiseThunkResult => async (dispatch, getState) => {
dispatch(actions.updateTopicAction.request());
try {
const topic: Topic = await topicsApiClient.updateTopic({
clusterName,
topicName: form.name,
topicName,
topicUpdate: formatTopicUpdate(form),
});