From a4046d46ef44d51626c7f655ef89c3f3429b7b80 Mon Sep 17 00:00:00 2001 From: Oleg Shur Date: Tue, 28 Jun 2022 15:15:12 +0300 Subject: [PATCH] chore: migrate clusters from toolkit to react-query (#2214) --- kafka-ui-react-app/src/components/App.tsx | 48 ++---- .../src/components/Cluster/Cluster.tsx | 59 +++---- .../Cluster/__tests__/Cluster.spec.tsx | 150 ++++++++---------- .../Cluster/__tests__}/fixtures.ts | 2 + .../ConsumerGroups/Details/Details.tsx | 2 +- .../Details/ResetOffsets/ResetOffsets.tsx | 2 +- .../ClustersWidget/ClustersWidget.tsx | 117 +++++++------- .../ClustersWidget/ClustersWidgetContainer.ts | 17 -- .../__test__/ClustersWidget.spec.tsx | 26 +-- .../__test__/ClustersWidgetContainer.spec.tsx | 12 -- .../ClustersWidget/__test__/fixtures.ts | 27 ---- .../src/components/Dashboard/Dashboard.tsx | 9 +- .../Dashboard/__test__/Dashboard.spec.tsx | 11 +- .../src/components/KsqlDb/Query/Query.tsx | 2 +- kafka-ui-react-app/src/components/Nav/Nav.tsx | 31 ++-- .../Nav/__tests__/ClusterMenu.spec.tsx | 2 +- .../src/components/Nav/__tests__/Nav.spec.tsx | 35 ++-- .../Details/Messages/Filters/Filters.tsx | 2 +- .../Topic/Details/Messages/Filters/utils.ts | 2 +- .../Topics/Topic/SendMessage/SendMessage.tsx | 2 +- .../Topic/SendMessage/validateMessage.ts | 2 +- .../src/components/__tests__/App.spec.tsx | 91 ++++------- .../common/Pagination/Pagination.tsx | 2 +- .../src/lib/hooks/api/useClusters.ts | 8 + .../src/lib/hooks/useDataSaver.ts | 2 +- .../src/redux/reducers/alerts/alertsSlice.ts | 2 +- .../clusters/__test__/reducer.spec.ts | 55 ------- .../clusters/__test__/selectors.spec.ts | 60 ------- .../redux/reducers/clusters/clustersSlice.ts | 61 ------- .../src/redux/reducers/connect/selectors.ts | 2 +- .../src/redux/reducers/index.ts | 2 - kafka-ui-react-app/vite.config.ts | 1 - 32 files changed, 274 insertions(+), 572 deletions(-) rename kafka-ui-react-app/src/{redux/reducers/clusters/__test__ => components/Cluster/__tests__}/fixtures.ts (94%) delete mode 100644 kafka-ui-react-app/src/components/Dashboard/ClustersWidget/ClustersWidgetContainer.ts delete mode 100644 kafka-ui-react-app/src/components/Dashboard/ClustersWidget/__test__/ClustersWidgetContainer.spec.tsx delete mode 100644 kafka-ui-react-app/src/components/Dashboard/ClustersWidget/__test__/fixtures.ts create mode 100644 kafka-ui-react-app/src/lib/hooks/api/useClusters.ts delete mode 100644 kafka-ui-react-app/src/redux/reducers/clusters/__test__/reducer.spec.ts delete mode 100644 kafka-ui-react-app/src/redux/reducers/clusters/__test__/selectors.spec.ts delete mode 100644 kafka-ui-react-app/src/redux/reducers/clusters/clustersSlice.ts diff --git a/kafka-ui-react-app/src/components/App.tsx b/kafka-ui-react-app/src/components/App.tsx index 1035edb05d..db7acf4df7 100644 --- a/kafka-ui-react-app/src/components/App.tsx +++ b/kafka-ui-react-app/src/components/App.tsx @@ -1,4 +1,4 @@ -import React, { useCallback } from 'react'; +import React, { Suspense, useCallback } from 'react'; import { Routes, Route, useLocation } from 'react-router-dom'; import { GIT_TAG, GIT_COMMIT } from 'lib/constants'; import { clusterPath, getNonExactPath } from 'lib/paths'; @@ -10,12 +10,6 @@ import Version from 'components/Version/Version'; import Alerts from 'components/Alerts/Alerts'; import { ThemeProvider } from 'styled-components'; import theme from 'theme/theme'; -import { useAppDispatch, useAppSelector } from 'lib/hooks/redux'; -import { - fetchClusters, - getClusterList, - getAreClustersFulfilled, -} from 'redux/reducers/clusters/clustersSlice'; import * as S from './App.styled'; import Logo from './common/Logo/Logo'; @@ -23,9 +17,6 @@ import GitIcon from './common/Icons/GitIcon'; import DiscordIcon from './common/Icons/DiscordIcon'; const App: React.FC = () => { - const dispatch = useAppDispatch(); - const areClustersFulfilled = useAppSelector(getAreClustersFulfilled); - const clusters = useAppSelector(getClusterList); const [isSidebarVisible, setIsSidebarVisible] = React.useState(false); const onBurgerClick = () => setIsSidebarVisible(!isSidebarVisible); const closeSidebar = useCallback(() => setIsSidebarVisible(false), []); @@ -35,10 +26,6 @@ const App: React.FC = () => { closeSidebar(); }, [location, closeSidebar]); - React.useEffect(() => { - dispatch(fetchClusters()); - }, [dispatch]); - return ( @@ -90,10 +77,9 @@ const App: React.FC = () => { -