فهرست منبع

#518 Fixed backend page size (#523)

* #518 Fixed backend page size

* Fixedd tests
German Osin 4 سال پیش
والد
کامیت
a1ee6a30c0

+ 1 - 1
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ClusterService.java

@@ -43,7 +43,7 @@ import reactor.util.function.Tuples;
 @Service
 @Service
 @RequiredArgsConstructor
 @RequiredArgsConstructor
 public class ClusterService {
 public class ClusterService {
-  private static final Integer DEFAULT_PAGE_SIZE = 20;
+  private static final Integer DEFAULT_PAGE_SIZE = 25;
 
 
   private final ClustersStorage clustersStorage;
   private final ClustersStorage clustersStorage;
   private final ClusterMapper clusterMapper;
   private final ClusterMapper clusterMapper;

+ 11 - 11
kafka-ui-api/src/test/java/com/provectus/kafka/ui/service/ClusterServiceTest.java

@@ -33,7 +33,7 @@ class ClusterServiceTest {
   private ClustersStorage clustersStorage;
   private ClustersStorage clustersStorage;
 
 
   @Test
   @Test
-  public void shouldListFirst20Topics() {
+  public void shouldListFirst25Topics() {
     var topicName = UUID.randomUUID().toString();
     var topicName = UUID.randomUUID().toString();
 
 
     when(clustersStorage.getClusterByName(topicName))
     when(clustersStorage.getClusterByName(topicName))
@@ -51,8 +51,8 @@ class ClusterServiceTest {
     var topics = clusterService.getTopics(topicName,
     var topics = clusterService.getTopics(topicName,
         Optional.empty(), Optional.empty(), Optional.empty(),
         Optional.empty(), Optional.empty(), Optional.empty(),
         Optional.empty(), Optional.empty());
         Optional.empty(), Optional.empty());
-    assertThat(topics.getPageCount()).isEqualTo(5);
-    assertThat(topics.getTopics()).hasSize(20);
+    assertThat(topics.getPageCount()).isEqualTo(4);
+    assertThat(topics.getTopics()).hasSize(25);
     assertThat(topics.getTopics()).map(Topic::getName).isSorted();
     assertThat(topics.getTopics()).map(Topic::getName).isSorted();
   }
   }
 
 
@@ -97,8 +97,8 @@ class ClusterServiceTest {
 
 
     var topics = clusterService.getTopics(topicName, Optional.of(0), Optional.of(-1),
     var topics = clusterService.getTopics(topicName, Optional.of(0), Optional.of(-1),
         Optional.empty(), Optional.empty(), Optional.empty());
         Optional.empty(), Optional.empty(), Optional.empty());
-    assertThat(topics.getPageCount()).isEqualTo(5);
-    assertThat(topics.getTopics()).hasSize(20);
+    assertThat(topics.getPageCount()).isEqualTo(4);
+    assertThat(topics.getTopics()).hasSize(25);
     assertThat(topics.getTopics()).map(Topic::getName).isSorted();
     assertThat(topics.getTopics()).map(Topic::getName).isSorted();
   }
   }
 
 
@@ -122,8 +122,8 @@ class ClusterServiceTest {
     var topics = clusterService.getTopics(topicName,
     var topics = clusterService.getTopics(topicName,
         Optional.empty(), Optional.empty(), Optional.of(true),
         Optional.empty(), Optional.empty(), Optional.of(true),
         Optional.empty(), Optional.empty());
         Optional.empty(), Optional.empty());
-    assertThat(topics.getPageCount()).isEqualTo(5);
-    assertThat(topics.getTopics()).hasSize(20);
+    assertThat(topics.getPageCount()).isEqualTo(4);
+    assertThat(topics.getTopics()).hasSize(25);
     assertThat(topics.getTopics()).map(Topic::getName).isSorted();
     assertThat(topics.getTopics()).map(Topic::getName).isSorted();
   }
   }
 
 
@@ -148,8 +148,8 @@ class ClusterServiceTest {
     var topics = clusterService.getTopics(topicName,
     var topics = clusterService.getTopics(topicName,
         Optional.empty(), Optional.empty(), Optional.of(true),
         Optional.empty(), Optional.empty(), Optional.of(true),
         Optional.empty(), Optional.empty());
         Optional.empty(), Optional.empty());
-    assertThat(topics.getPageCount()).isEqualTo(5);
-    assertThat(topics.getTopics()).hasSize(20);
+    assertThat(topics.getPageCount()).isEqualTo(4);
+    assertThat(topics.getTopics()).hasSize(25);
     assertThat(topics.getTopics()).map(Topic::getName).isSorted();
     assertThat(topics.getTopics()).map(Topic::getName).isSorted();
   }
   }
 
 
@@ -198,8 +198,8 @@ class ClusterServiceTest {
     var topics = clusterService.getTopics(topicName,
     var topics = clusterService.getTopics(topicName,
         Optional.empty(), Optional.empty(), Optional.empty(),
         Optional.empty(), Optional.empty(), Optional.empty(),
         Optional.empty(), Optional.of(TopicColumnsToSort.TOTAL_PARTITIONS));
         Optional.empty(), Optional.of(TopicColumnsToSort.TOTAL_PARTITIONS));
-    assertThat(topics.getPageCount()).isEqualTo(5);
-    assertThat(topics.getTopics()).hasSize(20);
+    assertThat(topics.getPageCount()).isEqualTo(4);
+    assertThat(topics.getTopics()).hasSize(25);
     assertThat(topics.getTopics()).map(Topic::getPartitionCount).isSorted();
     assertThat(topics.getTopics()).map(Topic::getPartitionCount).isSorted();
   }
   }
 }
 }