Selaa lähdekoodia

GITBOOK-10: Fix typos, rearrange entries, update git configuration article

Roman Zabaluev 2 vuotta sitten
vanhempi
commit
7e40fef000

+ 2 - 2
SUMMARY.md

@@ -14,12 +14,12 @@
 ## 🛠 Development
 
 * [Contributing](development/contributing.md)
+* [Setting up git](development/setting-up-git.md)
 * [Building](development/building/README.md)
   * [Prerequisites](development/building/prerequisites.md)
-  * [WIP: Setting up git](development/building/wip-setting-up-git.md)
   * [With Docker](development/building/with-docker.md)
   * [Without Docker](development/building/without-docker.md)
-  * [WIP: Testing](development/building/wip-testing.md)
+* [WIP: Testing](development/wip-testing.md)
 
 ## 👷♂ Configuration
 

+ 0 - 7
development/building/wip-setting-up-git.md

@@ -1,7 +0,0 @@
-# WIP: Setting up git
-
-TODO :)
-
-
-
-1. credentials?

+ 10 - 10
development/contributing.md

@@ -2,34 +2,34 @@
 
 This guide aims to walk you through the process of working on issues and Pull Requests (PRs).
 
-Bear in mind that you will not be able to complete some steps on your own if you do not have a “write” permission. Feel free to reach out to the maintainers to help you unlock these activities.
+Bear in mind that you will not be able to complete some steps on your own if you do not have “write” permission. Feel free to reach out to the maintainers to help you unlock these activities.
 
 ## General recommendations
 
-Please note that we have a code of conduct (`CODE-OF-CONDUCT.md`). Make sure that you follow it in all of your interactions with the project.
+Please note that we have a [code of conduct](../project/code-of-conduct.md). Make sure that you follow it in all of your interactions with the project.
 
 ## Issues
 
 ### Choosing an issue
 
 There are two options to look for the issues to contribute to.\
-The first is our ["Up for grabs"](https://github.com/provectus/kafka-ui/projects/11) board. There the issues are sorted by a required experience level (beginner, intermediate, expert).
+The first is our ["Up for grabs"](https://github.com/provectus/kafka-ui/projects/11) board. There the issues are sorted by the required experience level (beginner, intermediate, expert).
 
-The second option is to search for ["good first issue"](https://github.com/provectus/kafka-ui/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)-labeled issues. Some of them might not be displayed on the aforementioned board, or vice versa.
+The second option is to search for ["good first issue"](https://github.com/provectus/kafka-ui/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)-labeled issues. Some of them might not be displayed on the aforementioned board or vice versa.
 
-You also need to consider labels. You can sort the issues by scope labels, such as `scope/backend`, `scope/frontend` or even `scope/k8s`. If any issue covers several specific areas, and you do not have a required expertise for one of them, just do your part of work — others will do the rest.
+You also need to consider labels. You can sort the issues by scope labels, such as `scope/backend`, `scope/frontend` or even `scope/k8s`. If any issue covers several specific areas, and you do not have the required expertise for one of them, just do your part of the work — others will do the rest.
 
 ### Grabbing the issue
 
 There is a bunch of criteria that make an issue feasible for development.\
-The implementation of any features and/or their enhancements should be reasonable, must be backed by justified requirements (demanded by the community, roadmap plans, etc.). The final decision is left for the maintainers' discretion.
+The implementation of any features and/or their enhancements should be reasonable and must be backed by justified requirements (demanded by the community, roadmap plans, etc.). The final decision is left to the maintainers' discretion.
 
 All bugs should be confirmed as such (i.e. the behavior is unintended).
 
 Any issue should be properly triaged by the maintainers beforehand, which includes:
 
 1. Having a proper milestone set
-2. Having required labels assigned: accepted label, scope labels, etc.
+2. Having required labels assigned: "accepted" label, scope labels, etc.
 
 Formally, if these triage conditions are met, you can start to work on the issue.
 
@@ -37,7 +37,7 @@ With all these requirements met, feel free to pick the issue you want. Reach out
 
 ### Working on the issue
 
-Every issue “in-progress” needs to be assigned to a corresponding person. To keep the status of the issue clear to everyone, please keep the card's status updated ("project" card to the right of the issue should match the milestone’s name).
+Every issue “in progress” needs to be assigned to a corresponding person. To keep the status of the issue clear to everyone, please keep the card's status updated ("project" card to the right of the issue should match the milestone’s name).
 
 ### Setting up a local development environment
 
@@ -47,7 +47,7 @@ Please refer to this guide.
 
 ### Branch naming
 
-In order to keep branch names uniform and easy-to-understand, please use the following conventions for branch naming.
+In order to keep branch names uniform and easy to understand, please use the following conventions for branch naming.
 
 Generally speaking, it is a good idea to add a group/type prefix to a branch; e.g., if you are working on a specific branch, you could name it `issues/xxx`.
 
@@ -82,7 +82,7 @@ When creating a PR please do the following:
 4. If the PR does not close any of the issues, the PR itself might need to have a milestone set. Reach out to the maintainers to consult.
 5. Assign the PR to yourself. A PR assignee is someone whose goal is to get the PR merged.
 6. Add reviewers. As a rule, reviewers' suggestions are pretty good; please use them.
-7. Upon merging the PR, please use a meaningful commit message, task name should be fine in this case.
+7. Upon merging the PR, please use a meaningful commit message, the task name should be fine in this case.
 
 #### Pull Request checklist
 

+ 14 - 0
development/setting-up-git.md

@@ -0,0 +1,14 @@
+# Setting up git
+
+Set your git credentials:
+
+```
+git config --global user.name "Mona Lisa"
+git config --global user.email "monalisa@louvre.net"
+```
+
+More info on setting git credentials:
+
+[Setting your username in Git](https://docs.github.com/en/get-started/getting-started-with-git/setting-your-username-in-git)
+
+[Setting your commit email address](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address)

+ 0 - 0
development/building/wip-testing.md → development/wip-testing.md


+ 6 - 6
project/roadmap.md

@@ -4,21 +4,21 @@ description: Kafka-UI Project Roadmap
 
 # Roadmap
 
-Roadmap exists in a form of a github project board and is located [here](https://github.com/provectus/kafka-ui/projects/8).
+Roadmap exists in a form of a GitHub project board and is located [here](https://github.com/provectus/kafka-ui/projects/8).
 
 #### How to use this document
 
 The roadmap provides a list of features we decided to prioritize in project development. It should serve as a reference point to understand projects' goals.
 
-We do prioritize them based on the feedback from the community, our own vision and other conditions and circumstances.
+We do prioritize them based on the feedback from the community, our own vision, and other conditions and circumstances.
 
-The roadmap sets the general way of development. The roadmap is mostly about long-term features. All the features could be re-prioritized, rescheduled or canceled.
+The roadmap sets the general way of development. The roadmap is mostly about long-term features. All the features could be re-prioritized, rescheduled, or canceled.
 
-If there's no feature `X`, that **doesn't** mean we're **not** going to implement it. Feel free to raise the issue for the consideration.\
-If a feature you want to see live is not present on roadmap, but there's an issue for the feature, feel free to vote for it using reactions in the issue.
+If there's no feature `X`, that **doesn't** mean we're **not** going to implement it. Feel free to raise the issue for consideration.\
+If a feature you want to see live is not present on the roadmap, but there's an issue with the feature, feel free to vote for it using reactions to the issue.
 
 #### How to contribute
 
 Since the roadmap consists mostly of big long-term features, implementing them might be not easy for a beginner outside collaborator.
 
-A good starting point is checking the [CONTRIBUTING.md](https://github.com/provectus/kafka-ui/blob/master/CONTRIBUTING.md) document.
+A good starting point is checking the [contributing](../development/contributing.md) article.