0ct0pu5/kafka-ui
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Get rid of dockerfile-maven-plugin (#2594)

Browse source 
* Resolve #1932

Replacing spotify maven docker plugin to use fabric8 docker maven plugin instead

* Remove unused arg

Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
This commit is contained in:
Daniel Ching 2022-09-15 19:30:55 -06:00 • committed by GitHub
parent d149d26013
commit 71aa44a3d3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
kafka-ui-api/pom.xml
View file

@ -443,11 +443,22 @@
</executions> </executions>
</plugin> </plugin>
<plugin> <plugin>
<groupId>com.spotify</groupId> <groupId>io.fabric8</groupId>
<artifactId>dockerfile-maven-plugin</artifactId> <artifactId>docker-maven-plugin</artifactId>
<version>${dockerfile-maven-plugin.version}</version> <version>${fabric8-maven-plugin.version}</version>
<configuration> <configuration>
<skipPush>true</skipPush> <verbose>true</verbose>
<images>
<image>
<name>provectuslabs/kafka-ui:${git.revision}</name>
<build>
<contextDir>${project.basedir}</contextDir>
<args>
<JAR_FILE>${project.build.finalName}.jar</JAR_FILE>
</args>
</build>
</image>
</images>
</configuration> </configuration>
<executions> <executions>
<execution> <execution>
@ -456,14 +467,6 @@
<goals> <goals>
<goal>build</goal> <goal>build</goal>
</goals> </goals>
<configuration>
<tag>${git.revision}</tag>
<repository>provectuslabs/kafka-ui</repository>
<buildArgs>
<JAR_FILE>${project.build.finalName}.jar</JAR_FILE>
<JAR_NAME>${project.artifactId}.jar</JAR_NAME>
</buildArgs>
</configuration>
</execution> </execution>
</executions> </executions>
</plugin> </plugin>

2
pom.xml
View file

@ -23,7 +23,7 @@
<kafka-clients.version>3.2.0</kafka-clients.version> <kafka-clients.version>3.2.0</kafka-clients.version>
<node.version>v16.15.0</node.version> <node.version>v16.15.0</node.version>
<pnpm.version>v7.4.0</pnpm.version> <pnpm.version>v7.4.0</pnpm.version>
<dockerfile-maven-plugin.version>1.4.10</dockerfile-maven-plugin.version> <fabric8-maven-plugin.version>0.40.2</fabric8-maven-plugin.version>
<frontend-maven-plugin.version>1.12.1</frontend-maven-plugin.version> <frontend-maven-plugin.version>1.12.1</frontend-maven-plugin.version>
<maven-compiler-plugin.version>3.8.1</maven-compiler-plugin.version> <maven-compiler-plugin.version>3.8.1</maven-compiler-plugin.version>
<maven-clean-plugin.version>3.1.0</maven-clean-plugin.version> <maven-clean-plugin.version>3.1.0</maven-clean-plugin.version>