Browse Source

Get rid of dockerfile-maven-plugin (#2594)

* Resolve #1932

Replacing spotify maven docker plugin to use fabric8 docker maven plugin instead

* Remove unused arg

Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
Daniel Ching 2 years ago
parent
commit
71aa44a3d3
2 changed files with 16 additions and 13 deletions
  1. 15 12
      kafka-ui-api/pom.xml
  2. 1 1
      pom.xml

+ 15 - 12
kafka-ui-api/pom.xml

@@ -443,11 +443,22 @@
                         </executions>
                     </plugin>
                     <plugin>
-                        <groupId>com.spotify</groupId>
-                        <artifactId>dockerfile-maven-plugin</artifactId>
-                        <version>${dockerfile-maven-plugin.version}</version>
+                        <groupId>io.fabric8</groupId>
+                        <artifactId>docker-maven-plugin</artifactId>
+                        <version>${fabric8-maven-plugin.version}</version>
                         <configuration>
-                            <skipPush>true</skipPush>
+                            <verbose>true</verbose>
+                            <images>
+                                <image>
+                                    <name>provectuslabs/kafka-ui:${git.revision}</name>
+                                    <build>
+                                        <contextDir>${project.basedir}</contextDir>
+                                        <args>
+                                            <JAR_FILE>${project.build.finalName}.jar</JAR_FILE>
+                                        </args>
+                                    </build>
+                                </image>
+                            </images>
                         </configuration>
                         <executions>
                             <execution>
@@ -456,14 +467,6 @@
                                 <goals>
                                     <goal>build</goal>
                                 </goals>
-                                <configuration>
-                                    <tag>${git.revision}</tag>
-                                    <repository>provectuslabs/kafka-ui</repository>
-                                    <buildArgs>
-                                        <JAR_FILE>${project.build.finalName}.jar</JAR_FILE>
-                                        <JAR_NAME>${project.artifactId}.jar</JAR_NAME>
-                                    </buildArgs>
-                                </configuration>
                             </execution>
                         </executions>
                     </plugin>

+ 1 - 1
pom.xml

@@ -23,7 +23,7 @@
         <kafka-clients.version>3.2.0</kafka-clients.version>
         <node.version>v16.15.0</node.version>
         <pnpm.version>v7.4.0</pnpm.version>
-        <dockerfile-maven-plugin.version>1.4.10</dockerfile-maven-plugin.version>
+        <fabric8-maven-plugin.version>0.40.2</fabric8-maven-plugin.version>
         <frontend-maven-plugin.version>1.12.1</frontend-maven-plugin.version>
         <maven-compiler-plugin.version>3.8.1</maven-compiler-plugin.version>
         <maven-clean-plugin.version>3.1.0</maven-clean-plugin.version>