0ct0pu5/kafka-ui
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not try to connect to zookeeper if connection string is empty (#428)

Browse source 
Co-authored-by: Jakub Štiller <stiller@2n.cz>
This commit is contained in:
Jakub Štiller 2021-05-13 09:11:38 +02:00 • committed by GitHub
parent b60ff8acf6
commit 69c034c793
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ZookeeperService.java
View file

@ -7,6 +7,7 @@ import lombok.RequiredArgsConstructor;
import lombok.extern.log4j.Log4j2; import lombok.extern.log4j.Log4j2;
import org.I0Itec.zkclient.ZkClient; import org.I0Itec.zkclient.ZkClient;
import org.springframework.stereotype.Service; import org.springframework.stereotype.Service;
import org.springframework.util.StringUtils;
@Service @Service
@RequiredArgsConstructor @RequiredArgsConstructor
@ -17,11 +18,13 @@ public class ZookeeperService {
public boolean isZookeeperOnline(KafkaCluster kafkaCluster) { public boolean isZookeeperOnline(KafkaCluster kafkaCluster) {
var isConnected = false; var isConnected = false;
if (StringUtils.hasText(kafkaCluster.getZookeeper())) {
var zkClient = getOrCreateZkClient(kafkaCluster); var zkClient = getOrCreateZkClient(kafkaCluster);
log.debug("Start getting Zookeeper metrics for kafkaCluster: {}", kafkaCluster.getName()); log.debug("Start getting Zookeeper metrics for kafkaCluster: {}", kafkaCluster.getName());
if (zkClient != null) { if (zkClient != null) {
isConnected = isZkClientConnected(zkClient); isConnected = isZkClientConnected(zkClient);
} }
}
return isConnected; return isConnected;
} }