0ct0pu5/kafka-ui
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

minor tests refactoring

Browse source
This commit is contained in:
iliax 2023-05-05 12:19:27 +04:00
parent 121260afdb
commit 4dbdfc01fe
1 changed files with 21 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
kafka-ui-api/src/test/java/com/provectus/kafka/ui/service/acl/AclsServiceTest.java
View file

@ -58,12 +58,12 @@ class AclsServiceTest {
when(adminClientMock.listAcls(ResourcePatternFilter.ANY)) when(adminClientMock.listAcls(ResourcePatternFilter.ANY))
.thenReturn(Mono.just(List.of(existingBinding1, existingBinding2))); .thenReturn(Mono.just(List.of(existingBinding1, existingBinding2)));
ArgumentCaptor<?> createdCaptor = ArgumentCaptor.forClass(Collection.class); ArgumentCaptor<Collection<AclBinding>> createdCaptor = ArgumentCaptor.forClass(Collection.class);
when(adminClientMock.createAcls((Collection<AclBinding>) createdCaptor.capture())) when(adminClientMock.createAcls(createdCaptor.capture()))
.thenReturn(Mono.empty()); .thenReturn(Mono.empty());
ArgumentCaptor<?> deletedCaptor = ArgumentCaptor.forClass(Collection.class); ArgumentCaptor<Collection<AclBinding>> deletedCaptor = ArgumentCaptor.forClass(Collection.class);
when(adminClientMock.deleteAcls((Collection<AclBinding>) deletedCaptor.capture())) when(adminClientMock.deleteAcls(deletedCaptor.capture()))
.thenReturn(Mono.empty()); .thenReturn(Mono.empty());
aclsService.syncAclWithAclCsv( aclsService.syncAclWithAclCsv(
@ -73,12 +73,12 @@ class AclsServiceTest {
+ "User:test3,GROUP,PREFIXED,groupNew,DESCRIBE,DENY,localhost" + "User:test3,GROUP,PREFIXED,groupNew,DESCRIBE,DENY,localhost"
).block(); ).block();
Collection<AclBinding> createdBindings = (Collection<AclBinding>) createdCaptor.getValue(); Collection<AclBinding> createdBindings = createdCaptor.getValue();
assertThat(createdBindings) assertThat(createdBindings)
.hasSize(1) .hasSize(1)
.contains(newBindingToBeAdded); .contains(newBindingToBeAdded);
Collection<AclBinding> deletedBindings = (Collection<AclBinding>) deletedCaptor.getValue(); Collection<AclBinding> deletedBindings = deletedCaptor.getValue();
assertThat(deletedBindings) assertThat(deletedBindings)
.hasSize(1) .hasSize(1)
.contains(existingBinding2); .contains(existingBinding2);
@ -87,8 +87,8 @@ class AclsServiceTest {
@Test @Test
void createsConsumerDependantAcls() { void createsConsumerDependantAcls() {
ArgumentCaptor<?> createdCaptor = ArgumentCaptor.forClass(Collection.class); ArgumentCaptor<Collection<AclBinding>> createdCaptor = ArgumentCaptor.forClass(Collection.class);
when(adminClientMock.createAcls((Collection<AclBinding>) createdCaptor.capture())) when(adminClientMock.createAcls(createdCaptor.capture()))
.thenReturn(Mono.empty()); .thenReturn(Mono.empty());
var principal = UUID.randomUUID().toString(); var principal = UUID.randomUUID().toString();
@ -104,7 +104,7 @@ class AclsServiceTest {
).block(); ).block();
//Read, Describe on topics, Read on consumerGroups //Read, Describe on topics, Read on consumerGroups
Collection<AclBinding> createdBindings = (Collection<AclBinding>) createdCaptor.getValue(); Collection<AclBinding> createdBindings = createdCaptor.getValue();
assertThat(createdBindings) assertThat(createdBindings)
.hasSize(6) .hasSize(6)
.contains(new AclBinding( .contains(new AclBinding(
@ -129,8 +129,8 @@ class AclsServiceTest {
@Test @Test
void createsConsumerDependantAclsWhenTopicsAndGroupsSpecifiedByPrefix() { void createsConsumerDependantAclsWhenTopicsAndGroupsSpecifiedByPrefix() {
ArgumentCaptor<?> createdCaptor = ArgumentCaptor.forClass(Collection.class); ArgumentCaptor<Collection<AclBinding>> createdCaptor = ArgumentCaptor.forClass(Collection.class);
when(adminClientMock.createAcls((Collection<AclBinding>) createdCaptor.capture())) when(adminClientMock.createAcls(createdCaptor.capture()))
.thenReturn(Mono.empty()); .thenReturn(Mono.empty());
var principal = UUID.randomUUID().toString(); var principal = UUID.randomUUID().toString();
@ -146,7 +146,7 @@ class AclsServiceTest {
).block(); ).block();
//Read, Describe on topics, Read on consumerGroups //Read, Describe on topics, Read on consumerGroups
Collection<AclBinding> createdBindings = (Collection<AclBinding>) createdCaptor.getValue(); Collection<AclBinding> createdBindings = createdCaptor.getValue();
assertThat(createdBindings) assertThat(createdBindings)
.hasSize(3) .hasSize(3)
.contains(new AclBinding( .contains(new AclBinding(
@ -162,8 +162,8 @@ class AclsServiceTest {
@Test @Test
void createsProducerDependantAcls() { void createsProducerDependantAcls() {
ArgumentCaptor<?> createdCaptor = ArgumentCaptor.forClass(Collection.class); ArgumentCaptor<Collection<AclBinding>> createdCaptor = ArgumentCaptor.forClass(Collection.class);
when(adminClientMock.createAcls((Collection<AclBinding>) createdCaptor.capture())) when(adminClientMock.createAcls(createdCaptor.capture()))
.thenReturn(Mono.empty()); .thenReturn(Mono.empty());
var principal = UUID.randomUUID().toString(); var principal = UUID.randomUUID().toString();
@ -181,7 +181,7 @@ class AclsServiceTest {
//Write, Describe, Create permission on topics, Write, Describe on transactionalIds //Write, Describe, Create permission on topics, Write, Describe on transactionalIds
//IDEMPOTENT_WRITE on cluster if idempotent is enabled (true) //IDEMPOTENT_WRITE on cluster if idempotent is enabled (true)
Collection<AclBinding> createdBindings = (Collection<AclBinding>) createdCaptor.getValue(); Collection<AclBinding> createdBindings = createdCaptor.getValue();
assertThat(createdBindings) assertThat(createdBindings)
.hasSize(6) .hasSize(6)
.contains(new AclBinding( .contains(new AclBinding(
@ -207,8 +207,8 @@ class AclsServiceTest {
@Test @Test
void createsProducerDependantAclsWhenTopicsAndTxIdSpecifiedByPrefix() { void createsProducerDependantAclsWhenTopicsAndTxIdSpecifiedByPrefix() {
ArgumentCaptor<?> createdCaptor = ArgumentCaptor.forClass(Collection.class); ArgumentCaptor<Collection<AclBinding>> createdCaptor = ArgumentCaptor.forClass(Collection.class);
when(adminClientMock.createAcls((Collection<AclBinding>) createdCaptor.capture())) when(adminClientMock.createAcls(createdCaptor.capture()))
.thenReturn(Mono.empty()); .thenReturn(Mono.empty());
var principal = UUID.randomUUID().toString(); var principal = UUID.randomUUID().toString();
@ -226,7 +226,7 @@ class AclsServiceTest {
//Write, Describe, Create permission on topics, Write, Describe on transactionalIds //Write, Describe, Create permission on topics, Write, Describe on transactionalIds
//IDEMPOTENT_WRITE on cluster if idempotent is enabled (false) //IDEMPOTENT_WRITE on cluster if idempotent is enabled (false)
Collection<AclBinding> createdBindings = (Collection<AclBinding>) createdCaptor.getValue(); Collection<AclBinding> createdBindings = createdCaptor.getValue();
assertThat(createdBindings) assertThat(createdBindings)
.hasSize(5) .hasSize(5)
.contains(new AclBinding( .contains(new AclBinding(
@ -249,8 +249,8 @@ class AclsServiceTest {
@Test @Test
void createsStreamAppDependantAcls() { void createsStreamAppDependantAcls() {
ArgumentCaptor<?> createdCaptor = ArgumentCaptor.forClass(Collection.class); ArgumentCaptor<Collection<AclBinding>> createdCaptor = ArgumentCaptor.forClass(Collection.class);
when(adminClientMock.createAcls((Collection<AclBinding>) createdCaptor.capture())) when(adminClientMock.createAcls(createdCaptor.capture()))
.thenReturn(Mono.empty()); .thenReturn(Mono.empty());
var principal = UUID.randomUUID().toString(); var principal = UUID.randomUUID().toString();
@ -268,7 +268,7 @@ class AclsServiceTest {
// Read on input topics, Write on output topics // Read on input topics, Write on output topics
// ALL on applicationId-prefixed Groups and Topics // ALL on applicationId-prefixed Groups and Topics
Collection<AclBinding> createdBindings = (Collection<AclBinding>) createdCaptor.getValue(); Collection<AclBinding> createdBindings = createdCaptor.getValue();
assertThat(createdBindings) assertThat(createdBindings)
.hasSize(5) .hasSize(5)
.contains(new AclBinding( .contains(new AclBinding(