0ct0pu5/kafka-ui
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refetch topics list to display the updated data (#1900)

Browse source 
* refetch topics list to display the updated data

* fixing sonar code smells (#1826)

* fixing sonar code smells

* removing unnecessary change

* fixing some sonar code smell issues

* making requested changes

* Fix sonar badges in readme (#1906)

Co-authored-by: Robert Azizbekyan <103438454+rAzizbekyan@users.noreply.github.com>
Co-authored-by: Oleg Shur <workshur@gmail.com>
This commit is contained in:
Arsen Simonyan 2022-05-02 13:33:11 +04:00 • committed by Arsen Simonyan
parent 45931a63ed
commit 2b5917dd54
1 changed files with 12 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
kafka-ui-react-app/src/components/Topics/List/List.tsx
View file

@ -88,8 +88,8 @@ const List: React.FC<TopicsListProps> = ({
const [cachedPage, setCachedPage] = React.useState<number | null>(null);
const history = useHistory();
React.useEffect(() => {
fetchTopicsList({
const topicsListParams = React.useMemo(
() => ({
clusterName,
page,
perPage,
@ -97,17 +97,13 @@ const List: React.FC<TopicsListProps> = ({
sortOrder,
search,
showInternal,
});
}, [
fetchTopicsList,
clusterName,
page,
perPage,
orderBy,
sortOrder,
search,
showInternal,
]);
}),
[clusterName, page, perPage, orderBy, sortOrder, search, showInternal]
);
React.useEffect(() => {
fetchTopicsList(topicsListParams);
}, [fetchTopicsList, topicsListParams]);
const tableState = useTableState<
TopicWithDetailedInfo,
@ -190,6 +186,7 @@ const List: React.FC<TopicsListProps> = ({
}
closeConfirmationModal();
clearSelectedTopics();
fetchTopicsList(topicsListParams);
}, [
confirmationModal,
clearSelectedTopics,
@ -197,6 +194,8 @@ const List: React.FC<TopicsListProps> = ({
deleteTopics,
clearTopicsMessages,
tableState.selectedIds,
fetchTopicsList,
topicsListParams,
]);
const ActionsCell = React.memo<TableCellProps<TopicWithDetailedInfo, string>>(