浏览代码

FE: Fix topics unchecking w/ "Show Internal Topics" (#3585)

* bugfix/topics-selection remove selection reset useEffect, reseting only on pageChange

* bugfix/topics-selection implement rowId getter

* bugfix/topics-selection remove quotes from row name property for id generation
Nail Badiullin 2 年之前
父节点
当前提交
15b78c0a2e
共有 1 个文件被更改,包括 4 次插入4 次删除
  1. 4 4
      kafka-ui-react-app/src/components/common/NewTable/Table.tsx

+ 4 - 4
kafka-ui-react-app/src/components/common/NewTable/Table.tsx

@@ -142,15 +142,12 @@ const Table: React.FC<TableProps<any>> = ({
     (updater: UpdaterFn<PaginationState>) => {
       const newState = updatePaginationState(updater, searchParams);
       setSearchParams(searchParams);
+      setRowSelection({});
       return newState;
     },
     [searchParams]
   );
 
-  React.useEffect(() => {
-    setRowSelection({});
-  }, [searchParams]);
-
   const table = useReactTable({
     data,
     pageCount,
@@ -160,6 +157,9 @@ const Table: React.FC<TableProps<any>> = ({
       pagination: getPaginationFromSearchParams(searchParams),
       rowSelection,
     },
+    getRowId: (originalRow, index) => {
+      return originalRow.name ? originalRow.name : `${index}`;
+    },
     onSortingChange: onSortingChange as OnChangeFn<SortingState>,
     onPaginationChange: onPaginationChange as OnChangeFn<PaginationState>,
     onRowSelectionChange: setRowSelection,