Browse Source

fix(server): Filter out deleted partners (#2697)

* Filter out deleted partners

* Add separate filter clause for soft deleted users

---------

Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
Sergey Kondrikov 2 years ago
parent
commit
104e489000
1 changed files with 4 additions and 1 deletions
  1. 4 1
      server/src/domain/partner/partner.service.ts

+ 4 - 1
server/src/domain/partner/partner.service.ts

@@ -32,7 +32,10 @@ export class PartnerService {
   async getAll(authUser: AuthUserDto, direction: PartnerDirection): Promise<UserResponseDto[]> {
     const partners = await this.repository.getAll(authUser.id);
     const key = direction === PartnerDirection.SharedBy ? 'sharedById' : 'sharedWithId';
-    return partners.filter((partner) => partner[key] === authUser.id).map((partner) => this.map(partner, direction));
+    return partners
+      .filter((partner) => partner.sharedBy && partner.sharedWith) // Filter out soft deleted users
+      .filter((partner) => partner[key] === authUser.id)
+      .map((partner) => this.map(partner, direction));
   }
 
   private map(partner: PartnerEntity, direction: PartnerDirection): UserResponseDto {