Переглянути джерело

[GIN] Remove not-required err return

runGit never returns an error since it fails on an occuring error.
Removed the return error from the function signature.
M. Sonntag 4 роки тому
батько
коміт
646d4022d8
1 змінених файлів з 1 додано та 3 видалено
  1. 1 3
      internal/cmd/serv.go

+ 1 - 3
internal/cmd/serv.go

@@ -293,7 +293,7 @@ func runServ(c *cli.Context) error {
 
 // GIN specific: code altered from upstream, this function requires a review
 func runGit(cmd []string, requestMode db.AccessMode, user *db.User, owner *db.User,
-	repo *db.Repository) error {
+	repo *db.Repository) {
 	log.Info("Running %q", cmd)
 	gitCmd := exec.Command(cmd[0], cmd[1:]...)
 	if requestMode == db.AccessModeWrite {
@@ -313,8 +313,6 @@ func runGit(cmd []string, requestMode db.AccessMode, user *db.User, owner *db.Us
 	if err := gitCmd.Run(); err != nil {
 		fail("Internal error", "Failed to execute git command: %v", err)
 	}
-
-	return nil
 }
 
 // Make sure git-annex-shell does not make "bad" changes (refactored from repo)