code cleanup

src/main/java/org/codelibs/fess/es/config/exentity/CrawlingConfig.java

@@ -68,7 +68,7 @@ public interface CrawlingConfig {
     public enum ConfigType {
         WEB("W"), FILE("F"), DATA("D");
 
-        private final String typePrefix;
+        private String typePrefix;
 
         ConfigType(final String typePrefix) {
             this.typePrefix = typePrefix;

src/main/java/org/codelibs/fess/exception/JobProcessingException.java

@@ -27,7 +27,7 @@ public class JobProcessingException extends FessSystemException {
         super(message, e);
     }
 
-    public JobProcessingException(String message) {
+    public JobProcessingException(final String message) {
         super(message);
     }
 

src/main/java/org/codelibs/fess/exec/SuggestCreator.java

@@ -45,7 +45,6 @@ import org.lastaflute.di.core.external.GenericExternalContextComponentDefRegiste
 import org.lastaflute.di.core.factory.SingletonLaContainerFactory;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.slf4j.bridge.SLF4JBridgeHandler;
 
 public class SuggestCreator {
 

src/main/java/org/codelibs/fess/helper/ViewHelper.java

@@ -773,7 +773,7 @@ public class ViewHelper {
                 }
                 return data.getFacetResponse();
             });
-        } catch (ExecutionException e) {
+        } catch (final ExecutionException e) {
             throw new FessSystemException("Cannot load facet from cache.", e);
         }
     }

src/main/java/org/codelibs/fess/score/GoogleAnalyticsScoreBooster.java

@@ -137,7 +137,7 @@ public class GoogleAnalyticsScoreBooster extends ScoreBooster {
                     final List<MetricHeaderEntry> metricHeaders = header.getMetricHeader().getMetricHeaderEntries();
                     for (final ReportRow row : rows) {
                         final List<DateRangeValues> metrics = row.getMetrics();
-                        for (int j = 0; j < metrics.size(); j++) {
+                        for (final DateRangeValues values : metrics) {
                             String path = null;
                             Long count = null;
 
@@ -149,7 +149,6 @@ public class GoogleAnalyticsScoreBooster extends ScoreBooster {
                                 }
                             }
 
-                            final DateRangeValues values = metrics.get(j);
                             for (int k = 0; k < values.getValues().size() && k < metricHeaders.size(); k++) {
                                 final String name = metricHeaders.get(k).getName();
                                 if ("ga:pageviews".equals(name)) {