0ct0pu5/fess
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix #2866 Prevent URL decoding of filenames for specific schemes.

Browse source
This commit is contained in:
Shinsuke Sugaya 2025-01-09 18:02:12 +09:00
parent 541319b7ca
commit 162081c2e2
2 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/main/java/org/codelibs/fess/crawler/transformer/FessTransformer.java
View file

@ -187,7 +187,9 @@ public interface FessTransformer {
u = u.substring(0, idx);
}
}
u = decodeUrlAsName(u, u.startsWith("file:"));
if (!u.startsWith("smb:") && !u.startsWith("smb1:") && !u.startsWith("ftp:")) {
u = decodeUrlAsName(u, u.startsWith("file:"));
}
idx = u.lastIndexOf('/');
if (idx >= 0) {
if (u.length() > idx + 1) {

24
src/test/java/org/codelibs/fess/crawler/transformer/FessFileTransformerTest.java
View file

@ -109,6 +109,30 @@ public class FessFileTransformerTest extends UnitFessTestCase {
url = "smb://example.com/test?.txt";
exp = "test?.txt";
assertEquals(exp, transformer.getFileName(url, Constants.UTF_8));
url = "https://example.com/test%E3%81%82.txt";
exp = "testあ.txt";
assertEquals(exp, transformer.getFileName(url, Constants.UTF_8));
url = "file://example.com/test%E3%81%82.txt";
exp = "testあ.txt";
assertEquals(exp, transformer.getFileName(url, Constants.UTF_8));
url = "storage://example.com/test%E3%81%82.txt";
exp = "testあ.txt";
assertEquals(exp, transformer.getFileName(url, Constants.UTF_8));
url = "smb://example.com/test%E3%81%82.txt";
exp = "test%E3%81%82.txt";
assertEquals(exp, transformer.getFileName(url, Constants.UTF_8));
url = "smb1://example.com/test%E3%81%82.txt";
exp = "test%E3%81%82.txt";
assertEquals(exp, transformer.getFileName(url, Constants.UTF_8));
url = "ftp://example.com/test%E3%81%82.txt";
exp = "test%E3%81%82.txt";
assertEquals(exp, transformer.getFileName(url, Constants.UTF_8));
}
public void test_decodeUrl_null() throws Exception {