Commit graph

1367 commits

Author SHA1 Message Date
Manav Rathi
81d1563c3d
Also reproducible on latest beta 2024-04-16 10:17:51 +05:30
Manav Rathi
1e202a76c4
Works if we don't stream 2024-04-16 09:39:43 +05:30
Manav Rathi
d7b0beb949
[web] Clear search bar state when value is falsey
Updates https://github.com/ente-io/ente/pull/1453 so that we also clear the
existing state by calling the setFoo methods even when value is falsey.
2024-04-16 09:03:35 +05:30
Crowdin Bot
0f4624e829 New Crowdin translations by GitHub Action 2024-04-16 01:37:39 +00:00
Manav Rathi
2577cfe2f1
Replace cast with @ts-expect-error 2024-04-15 21:43:38 +05:30
Manav Rathi
020ed59d40
[web] Fix dev mode error on search input (#1453)
## Description
Ran into error after clearing search bar of queries by hitting
backspace.

>  The error is shown below
> Thank you to the team for considering 


## Tests
**Error**
![Screenshot 2024-04-15
184234](https://github.com/ente-io/ente/assets/82031202/f5f9845c-9420-4746-998b-2c67136d69cd)
**Fix**
Fixed by wrapping the line-causing error around by an `if` block.
2024-04-15 20:50:06 +05:30
daviddeepan
09c07e58e6 search-input runtime-error fix 2024-04-15 19:54:33 +05:30
Manav Rathi
83d2644bf4
Fix double slashing 2024-04-15 19:43:30 +05:30
Manav Rathi
67aacf8391
Replace everywhere 2024-04-15 19:40:50 +05:30
Manav Rathi
c99c4ac839
Use new method 2024-04-15 19:35:19 +05:30
Manav Rathi
6b331612b6
writeStream 2024-04-15 18:39:08 +05:30
Manav Rathi
a74d904989
Use a test stream
Example taken from https://developer.chrome.com/docs/capabilities/web-apis/fetch-streaming-requests
2024-04-15 16:00:25 +05:30
Manav Rathi
8cdb31783b
Enhance 2024-04-15 15:57:57 +05:30
Manav Rathi
2a425b0f9b
Add duplex parameter to a streaming request
Attempt to solve the following error in the browser's console when trying to
make the request:

    [error] download and save failed: TypeError: Failed to construct 'Request':
    The `duplex` member must be specified for a request with a streaming body
2024-04-15 14:22:00 +05:30
Manav Rathi
9eab93cfdf
Suppress webpack's critical dependency warnings for libheif
Supressing it for now since it obscures other important information in the console.

Upstream issue, which currently doesn't have a workaround:
https://github.com/catdad-experiments/libheif-js/issues/23

Full error message:

     ⚠ ../../node_modules/libheif-js/libheif-wasm/libheif-bundle.js
    Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

    Import trace for requested module:
    ../../node_modules/libheif-js/libheif-wasm/libheif-bundle.js
    ../../node_modules/libheif-js/wasm-bundle.js
    ../../node_modules/heic-decode/index.js
    ../../node_modules/heic-convert/index.js
    ./src/worker/convert.worker.ts
    ./src/utils/comlink/ComlinkConvertWorker.ts
    ./src/services/heic-convert/service.ts
    ...

Refs:
- https://stackoverflow.com/questions/38392697/webpack-umd-critical-dependency-cannot-be-statically-extracted
2024-04-15 13:47:46 +05:30
Manav Rathi
89b832d21f
Baby's first steps 2024-04-15 12:47:55 +05:30
Manav Rathi
3ea4879cf0
Remove text qualifier
The type already enforces that. And it reads better and the call sites this way.
2024-04-15 12:20:41 +05:30
Manav Rathi
73ef03a5d9
Move read/write whole files into fs 2024-04-15 12:17:33 +05:30
Manav Rathi
896cf0f785
Disable full file caches for now
This is only needed for ML indexing, let us revisit this once the ML flow is
done instead of adding a premature and possibly disk-space heavy optimization.
2024-04-15 11:50:23 +05:30
Manav Rathi
95c0f53d21
Preserve parameters
This was needed for the purchase success to be relayed back.
2024-04-15 10:59:07 +05:30
Manav Rathi
8d24a489f6
[desktop] Fix payment redirect
Fixes: https://github.com/ente-io/ente/issues/1440

There were two issues:

- It was a backward incompatible change to change the scheme from ente:// to
  next://. Revert.

- We also need to setup a top level redirect when the user presses back without
  making any changes to their subscription.

**Tested by**

Running payments app and desktop app locally, and verifying that after
interactions with the payments endpoint we go back to the desktop app's actual
contents correctly.
2024-04-15 10:47:14 +05:30
Manav Rathi
bcfd144ce9
[web] Use the public link origin provided by the server
When implementing https://github.com/ente-io/ente/pull/1443 it was found that
the Photos web app wasnt' using the sharedCollectionUrl prefix that is returned
by the server. Instead, it was using NEXT_PUBLIC_ENTE_ALBUMS_ENDPOINT as the
baseHost, while mobile client completely rely on the server for returning the
correct hostUrl.

**Tested by**

Running against the modified server, and verifying that changes to
apps.public-albums were being used.
2024-04-15 09:57:01 +05:30
Manav Rathi
18ac361688
Remove unused IPC method 2024-04-14 20:11:25 +05:30
Manav Rathi
87077417a2
Remove dup 2024-04-14 20:07:17 +05:30
Manav Rathi
d0ac3ea9ca
Remove newly dead code 2024-04-14 20:00:59 +05:30
Manav Rathi
a5f9fdd10d
Restructure selection 2024-04-14 19:59:13 +05:30
Manav Rathi
881a963fde
Inline 2024-04-14 19:46:26 +05:30
Manav Rathi
f9560ec533
Inline 2024-04-14 19:43:31 +05:30
Manav Rathi
22616bb77d
Remove top level error suppressors 2024-04-14 19:42:30 +05:30
Manav Rathi
4d19c46d7c
Replace exception handling for control flow 2024-04-14 19:39:35 +05:30
Manav Rathi
cc323905d5
Another 2024-04-14 19:33:49 +05:30
Manav Rathi
fca4b2aca6
Use also for the image 2024-04-14 19:29:22 +05:30
Manav Rathi
c4ac5e39a2
Refactor 2024-04-14 19:25:01 +05:30
Manav Rathi
28574e516d
[desktop] Fix export related IPC - Part 3/x (#1439) 2024-04-14 19:04:38 +05:30
Manav Rathi
22f221d481
Extract 2024-04-14 18:36:36 +05:30
Manav Rathi
eb64a00ed2
Remove unnecessary checks
It is simpler for us to parallel the rm command than our bespoke variant.
2024-04-14 18:22:46 +05:30
Manav Rathi
59b9e3e586
Move into fs 2024-04-14 18:12:19 +05:30
daviddeepan
2a9060bd39 css-alignment-issue-page-gallery 2024-04-14 13:53:00 +05:30
Manav Rathi
adb37f38e4
Shorten 2024-04-14 10:31:45 +05:30
Manav Rathi
14922b65f8
Inline 2024-04-14 10:28:27 +05:30
Manav Rathi
7438c3301e
Move mkdirIfNeeded into fs 2024-04-14 10:25:28 +05:30
Manav Rathi
0e8678715a
Remove layer 2024-04-14 10:03:16 +05:30
Manav Rathi
3824ebe91a
Remove exportService indirection 2024-04-14 09:57:58 +05:30
Manav Rathi
ea34eebfc9
Remove implicit electron dependency 2024-04-14 09:53:18 +05:30
Manav Rathi
eeb1952585
Use 2024-04-14 09:30:51 +05:30
Manav Rathi
72dd47fa7b
Audit rename 2024-04-14 09:27:52 +05:30
Manav Rathi
38db03c3a0
Start giving it more power 2024-04-13 21:50:56 +05:30
Manav Rathi
e268b9204e
Inline 2024-04-13 21:46:34 +05:30
Manav Rathi
acd50bb172
Inline 2024-04-13 21:39:36 +05:30
Manav Rathi
28d559bd84
Hoist 2024-04-13 21:35:58 +05:30