Manav Rathi
c090300175
Remove electron-builder-notarize
...
The environment variables we are passing get picked by the built in notarization
code in electron-builder which signs successfully.
notarization successful
But thereafter electron-builder-notarize starts throwing some errors:
Error: The appleIdPassword property is required when using notarization with password credentials
at validateNotaryToolAuthorizationArgs (/Users/runner/work/photos-desktop/photos-desktop/desktop/node_modules/electron-notarize/src/validate-args.ts:107:13)
Skipping notarization: The appleIdPassword property is required when using notarization with appleId
at module.exports (/Users/runner/work/photos-desktop/photos-desktop/desktop/node_modules/electron-builder-notarize/validate.js:42:18)
Since the notarization has already happened, we don't need this
2024-05-07 14:25:22 +05:30
Manav Rathi
08b5672f93
Migrate off from deprecated API
2024-05-07 09:46:12 +05:30
Manav Rathi
6efbaacdd1
Add note about keychain
2024-05-07 09:43:32 +05:30
Manav Rathi
939b228a0d
Note about appDir
2024-05-07 09:37:44 +05:30
Manav Rathi
555eda0619
Check
2024-05-06 19:28:05 +05:30
Manav Rathi
333f364d38
Serve legacy face crops
2024-05-06 19:20:25 +05:30
Manav Rathi
0af7d2c13e
Retain the devtools option for perhaps another build to help in extreme cases
2024-05-06 16:31:18 +05:30
Manav Rathi
8a8d29e6b9
Fix loading of preload scripts
2024-05-06 16:29:51 +05:30
Manav Rathi
a8d3a8bfe8
Remove duplicate notarization attempt
...
From build logs:
• notarization successful
Error: The appleIdPassword property is required when using notarization with password credentials
at validateNotaryToolAuthorizationArgs (/Users/runner/work/photos-desktop/photos-desktop/desktop/node_modules/electron-notarize/src/validate-args.ts:107:13)
Not sure, but at the face of it (since this was not enabled earlier too), our
notarization process kicks in during signing because of the presence of env
vars, and specifying it again here starts a separate process we haven't
configured.
2024-05-06 16:08:23 +05:30
Manav Rathi
5f964e533c
Show always (for temp debugging)
2024-05-06 16:07:35 +05:30
Manav Rathi
51e9383ce0
lint
2024-05-06 15:33:21 +05:30
Manav Rathi
c2f5c3968c
Note what I noticed
2024-05-06 15:31:07 +05:30
Manav Rathi
90d56f3886
Show dev tools always
2024-05-06 15:26:26 +05:30
Manav Rathi
aa81e14fed
Draft release for testing
2024-05-06 15:22:21 +05:30
Manav Rathi
2b9ee7824d
lint
2024-05-03 14:44:24 +05:30
Manav Rathi
ea812561c6
Run everywhere
2024-05-03 14:38:56 +05:30
Manav Rathi
3fafc5fd99
Use an Electron Builder version that supports notarytool
...
We need the following patch (from the release notes of v25.0.0-alpha.6)
https://github.com/electron-userland/electron-builder/releases
> feat: Make notarization with Apple ID more usable by
> https://github.com/electron-userland/electron-builder/pull/8159
2024-05-03 13:17:58 +05:30
Manav Rathi
b24d80a267
Move to new notarization mechanism
...
Refs:
- https://www.electron.build/configuration/mac.html#NotarizeLegacyOptions
- https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/macPackager.ts
- https://github.com/samuelmeuli/action-electron-builder/issues/101
2024-05-03 13:02:19 +05:30
Manav Rathi
0f3555468d
Provide repository
...
Fixes:
Cannot detect repository by .git/config. Please specify "repository" in the package.json (https://docs.npmjs.com/files/package.json#repository ).
Please see https://electron.build/configuration/publish failedTask=build stackTrace=Error: Cannot detect repository by .git/config. Please specify "repository" in the package.json (https://docs.npmjs.com/files/package.json#repository ).
2024-05-03 12:09:03 +05:30
Manav Rathi
e9feec37d5
Run the electron builder in the correct path
2024-05-03 11:28:06 +05:30
Manav Rathi
5d0e62cf5f
Use same convention as other preexisting tags in our repo
2024-05-03 11:08:06 +05:30
Manav Rathi
647cc0d803
[desktop] Fix ref ref in action
...
ref_name is the (from my understanding) the shorthand we need for prefixing. Untested, will do a test build.
2024-05-03 11:00:55 +05:30
Manav Rathi
ddad863b31
Prepare for release
2024-05-03 10:50:21 +05:30
Manav Rathi
0c4da8c86a
POSIX paths
2024-05-02 21:38:02 +05:30
Manav Rathi
6a99002064
Start using it
2024-05-02 21:25:44 +05:30
Manav Rathi
67eed1aa89
Upgrade to Electron 30
...
This picks up the stream fix we need
> Fixed data corruption when protocol.handle() processed incoming data asynchronously. #41933 (Also in 31)
>
> https://github.com/electron/electron/releases/tag/v30.0.2
2024-05-02 21:20:26 +05:30
Manav Rathi
2f2d15c9f2
lint
2024-05-02 20:22:40 +05:30
Manav Rathi
fecfb4a8b7
Hopes and dreams
2024-05-02 19:52:39 +05:30
Manav Rathi
3b3d24e9e0
It'll need to live in the releases repo, reword accordingly
2024-05-02 19:34:58 +05:30
Manav Rathi
fa182b951d
[desktop] Resurrect build
...
Untested
2024-05-02 12:55:08 +05:30
Manav Rathi
90b5054fcb
chokidar seemed to have gotten stuck after a close
...
Not sure if something else was off, but after a close new watches in the same
session (after logging in) stopped reacting.
2024-05-01 19:02:43 +05:30
Manav Rathi
932f26684d
Electron logout
2024-05-01 18:50:10 +05:30
Manav Rathi
4eb51061cb
For real
2024-05-01 18:21:45 +05:30
Manav Rathi
de4aa3a6ca
URL encode
2024-05-01 18:15:52 +05:30
Manav Rathi
b967d4bbea
URL encode better
...
e.g. fixes the reading of a file with a hash in the name
2024-05-01 17:39:28 +05:30
Manav Rathi
10f2c3db6f
Mention why we're normalizing
2024-05-01 15:12:50 +05:30
Manav Rathi
4c28e83dbb
Optimize
2024-05-01 15:07:58 +05:30
Manav Rathi
36984012a8
They're all optionals now
2024-05-01 15:00:18 +05:30
Manav Rathi
cb73bc143d
Research
2024-05-01 15:00:14 +05:30
Manav Rathi
15b013ea36
Verified with a console log
2024-05-01 10:19:21 +05:30
Manav Rathi
38969d6f45
Fix zip reader
2024-05-01 10:17:51 +05:30
Manav Rathi
bd2969daff
Fix inverted condition
2024-05-01 10:03:03 +05:30
Manav Rathi
eb1d8a8210
Add a workaround for broken yarn classic dependency resolution
...
...that causes `yarn install` to fail.
Ref:
- https://github.com/isaacs/jackspeak/issues/5
- https://github.com/yargs/cliui/issues/159
2024-05-01 09:27:56 +05:30
Manav Rathi
abee517f8c
Fix remote build by recreating yarn.lock
2024-05-01 09:13:20 +05:30
Manav Rathi
9cbf69f9b3
upgrade-interactive
2024-05-01 08:46:43 +05:30
Manav Rathi
6c716ad892
Tell prettier not to print the names of the files it processes
2024-05-01 08:30:35 +05:30
Manav Rathi
4e8f2e65f0
Handle undefined better
2024-05-01 08:25:55 +05:30
Manav Rathi
a0d44b58e2
Fix load
...
Using .on("ready" was not causing the window to start loading the renderer
unless createWindow was made async.
2024-04-30 22:48:46 +05:30
Manav Rathi
54e8d64b9e
Fix the loading of utils/index
...
Naming it index doesn't cause isDev to be loaded.
2024-04-30 22:46:04 +05:30
Manav Rathi
1eff04fe92
Enable lints
2024-04-30 18:57:19 +05:30
