Commit graph

414 commits

Author SHA1 Message Date
Neeraj Gupta
b12e6221d4 [mob][photos] Change button type to neutral 2024-04-29 13:46:18 +05:30
Neeraj Gupta
7411125194 [mob][photos] Add support for closing session 2024-04-29 11:20:17 +05:30
Neeraj Gupta
4b97f832b2 [mob][photos] Finish auto-pair integration 2024-04-29 10:23:19 +05:30
Laurens Priem
9eeab36392
[mob][photos] Generate face crops faster (#1542)
## Description

Have written two new methods, `generateImgFaceThumbnails()` and
`generateJpgFaceThumbnails()`.
Using `generateJpgFaceThumbnails()` now since it returns
`Future<List<Uint8List>>` and is easier to integrate within the code
base because the return type remains the same with the older
`generateFaceThumbnailsForImage()`

There is performance improvement with `generateImgFaceThumbnails()`, but
it's not very significant and it requires changes in codebase to work
with it's return type `Future<List<Image>>` (`Image` from the `Image`
package). Can consider using it if it feels necessary in future.

If multiple faces are being generated from the same image, the image can
be decoded once and passed to `generateImgFaceThumbnails()` or
`generateJpgFaceThumbnails()` to avoid repeated decoding of the same
image.

`generateImgFaceThumbnails()` and `generateJpgFaceThumbnails()` uses the
isolates available from the pool of 4 spawned by `Computer` and
processes multiple faces in parallel unlike
`generateImgFaceThumbnails()`, which processes only one at a time.
2024-04-27 12:05:32 +05:30
ashilkn
58cd9350c0 Merge branch 'mobile_face' into fix_face_thumbnail 2024-04-27 11:10:10 +05:30
ashilkn
ab5985a08b [mob][photos] Use generated face crops and crop it using the new method 2024-04-27 11:06:54 +05:30
ashilkn
19f2c5f00a [mob][photos] remove negation 2024-04-27 11:02:38 +05:30
laurenspriem
968eaaf5f6 [mob][photos] Better error logging 2024-04-27 09:39:12 +05:30
laurenspriem
2692d0a34f [mob][photos] Fix issue in displaying face thumbnails for videos 2024-04-26 14:50:14 +05:30
laurenspriem
811ffe0117 [mob][photos] Create new cluster when tapping unassigned face 2024-04-26 14:13:00 +05:30
ashilkn
a0e9913f43 Revert "[mob] Crop image instead of using scale and translate transforms on OG image in CroppedFaceImageView widget"
This reverts commit b022ef6d1e.
2024-04-26 12:56:12 +05:30
ashilkn
b256bb2757 Revert "[mob] perf: Decode images from which face is to be cropped, in an isolate to avoid jank"
This reverts commit 2f7e0cd1ef.
2024-04-26 12:55:29 +05:30
ashilkn
3eebfdd037 Revert "[mob] Two varients of CroppedFaceImageView for testing out which is more performant"
This reverts commit 7617817798.
2024-04-26 12:54:29 +05:30
ashilkn
a577611e65 [mob] merge mobile_face to fix_face_thumbnail 2024-04-26 11:32:33 +05:30
Neeraj Gupta
dddbb959b5 [mob][photos] Refactor 2024-04-25 17:45:03 +05:30
ashilkn
7617817798 [mob] Two varients of CroppedFaceImageView for testing out which is more performant 2024-04-25 16:58:58 +05:30
laurenspriem
f101468a8d [mob][photos] Show faces in file info regardless of blur value 2024-04-25 16:30:00 +05:30
Neeraj Gupta
483cfd1f39 [mob][photos] Lint suggestions 2024-04-25 16:28:30 +05:30
Neeraj Gupta
864f5c1fd4 [mob][photos] Extract strings 2024-04-25 16:25:04 +05:30
laurenspriem
f0ebdb211c [mob][photos] Functionality to remove selected images from suggestion 2024-04-25 14:13:58 +05:30
Neeraj Gupta
f777bdba1b [mob][photos] Extract strings 2024-04-25 12:44:46 +05:30
ashilkn
2f7e0cd1ef [mob] perf: Decode images from which face is to be cropped, in an isolate to avoid jank 2024-04-25 12:29:29 +05:30
Neeraj Gupta
e903fbf9bc [mob][photos] Continue showing pair dialog in case of error 2024-04-25 11:50:02 +05:30
laurenspriem
d0420ce477 [mob][photos] Better sorting of faces in file info 2024-04-25 10:03:05 +05:30
ashilkn
b022ef6d1e [mob] Crop image instead of using scale and translate transforms on OG image in CroppedFaceImageView widget 2024-04-25 09:35:55 +05:30
laurenspriem
3fbfa8c0e6 [mob][photos] Precompute face thumbnails for suggestions 2024-04-24 18:59:08 +05:30
laurenspriem
07458fb247 [mob][photos] Recompute suggestions on rejected suggestion 2024-04-24 17:15:11 +05:30
laurenspriem
462d1d4854 [mob][photos] Use cosineDistanceSIMD 2024-04-24 16:37:39 +05:30
Neeraj Gupta
aced4bb5cf [mob][photos] Update cast selection dialog 2024-04-24 15:22:24 +05:30
Neeraj Gupta
729e2adfd1 [mob] Use separate widget for auto-cast 2024-04-24 13:21:12 +05:30
Neeraj Gupta
bed14d8ee9 [mob][photos] Use cast Icon in appbar 2024-04-24 11:38:22 +05:30
vishnukvmd
0b212bf7a6 Move padding within to increase tap-able area 2024-04-24 11:00:18 +05:30
Neeraj Gupta
1251a014b0 [mob][cast] Show choice to auto and manual pair 2024-04-24 10:57:28 +05:30
vishnukvmd
50b6d95ec2 Fix update checker for iOS 2024-04-24 10:54:37 +05:30
Neeraj Gupta
bd225ced04 [mob][cast] Return name and castDevice as record 2024-04-23 16:08:16 +05:30
Neeraj Gupta
89646ac469 [mob][cast] Refactor + add multiple cast plugin to gracefully handle fdroid 2024-04-23 15:57:17 +05:30
Neeraj Gupta
8fd330c304 Merge branch 'main' into cast 2024-04-23 14:35:37 +05:30
Neeraj Gupta
73f35c1a0c [mobile] Use passkey flag for showing passkey option 2024-04-23 13:38:55 +05:30
laurenspriem
9e87b4a2cc [mob][photos] Highlight face in cluster 2024-04-23 11:58:39 +05:30
Neeraj Gupta
83075ea367 [mobile] Switch to feature flag plugin 2024-04-23 11:54:24 +05:30
ashilkn
4c25997bb6 [mob] use layoutBuilder in face thumbnail 2024-04-23 11:15:46 +05:30
ashilkn
731610ed94 [mob] Refactor 2024-04-23 08:30:59 +05:30
ashilkn
e875eb1389 [mob] Remove unnecessary ShapeDecoration and width constrain 2024-04-23 08:27:47 +05:30
ashilkn
3253a2bf26 [mob] Remove unnecessary LayoutBuilder 2024-04-23 08:26:29 +05:30
ashilkn
8225697e43 Merge branch 'mobile_face' into fix_face_thumbnail 2024-04-23 07:49:59 +05:30
laurenspriem
9cdd4fd713 [mob][photos] Face thumbnail generation from widgets 2024-04-22 17:24:34 +05:30
ashilkn
c1587cc5ea [mob] Remove redundant clippling and anti aliasing for performance gain 2024-04-22 11:52:39 +05:30
ashilkn
ae046e33b4 [mob] fix: face thumbnails getting cropped on the edges because the image uses BoxFit.cover 2024-04-22 11:45:54 +05:30
laurenspriem
37ab467da5 [mob][photos] Remove blur ranking debug option 2024-04-22 11:35:40 +05:30
Neeraj Gupta
da1d778eeb [mob][photos] Add hook to connect to cast device 2024-04-22 10:47:49 +05:30