Browse Source

Add support for setting no device limit

Neeraj Gupta 1 năm trước cách đây
mục cha
commit
e13b22f2f9

+ 2 - 1
lib/core/constants.dart

@@ -52,7 +52,8 @@ const double restrictedMaxWidth = 430;
 
 const double mobileSmallThreshold = 336;
 
-const publicLinkDeviceLimits = [50, 25, 10, 5, 2, 1];
+// Note: 0 indicates no device limit
+const publicLinkDeviceLimits = [0,50, 25, 10, 5, 2, 1];
 
 const kilometersPerDegree = 111.16;
 

+ 1 - 0
lib/generated/intl/messages_en.dart

@@ -1299,6 +1299,7 @@ class MessageLookup extends MessageLookupByLibrary {
         "unhiding": MessageLookupByLibrary.simpleMessage("Unhiding..."),
         "unhidingFilesToAlbum":
             MessageLookupByLibrary.simpleMessage("Unhiding files to album"),
+        "unlimited": MessageLookupByLibrary.simpleMessage("Unlimited"),
         "unlock": MessageLookupByLibrary.simpleMessage("Unlock"),
         "unpinAlbum": MessageLookupByLibrary.simpleMessage("Unpin album"),
         "unselectAll": MessageLookupByLibrary.simpleMessage("Unselect all"),

+ 10 - 0
lib/generated/l10n.dart

@@ -1530,6 +1530,16 @@ class S {
     );
   }
 
+  /// `Unlimited`
+  String get unlimited {
+    return Intl.message(
+      'Unlimited',
+      name: 'unlimited',
+      desc: '',
+      args: [],
+    );
+  }
+
   /// `Link expiry`
   String get linkExpiry {
     return Intl.message(

+ 1 - 0
lib/l10n/intl_en.arb

@@ -189,6 +189,7 @@
   "disableDownloadWarningBody": "Viewers can still take screenshots or save a copy of your photos using external tools",
   "allowDownloads": "Allow downloads",
   "linkDeviceLimit": "Device limit",
+  "unlimited": "Unlimited",
   "linkExpiry": "Link expiry",
   "linkExpired": "Expired",
   "linkEnabled": "Enabled",

+ 3 - 3
lib/ui/sharing/manage_links_widget.dart

@@ -135,9 +135,9 @@ class _ManageSharedLinkWidgetState extends State<ManageSharedLinkWidget> {
                   MenuItemWidget(
                     captionedTextWidget: CaptionedTextWidget(
                       title: S.of(context).linkDeviceLimit,
-                      subTitle: widget
-                          .collection!.publicURLs!.first!.deviceLimit
-                          .toString(),
+                      subTitle: url.deviceLimit == 0
+                          ? S.of(context).unlimited
+                          : "${url.deviceLimit}",
                     ),
                     trailingIcon: Icons.chevron_right,
                     menuItemColor: enteColorScheme.fillFaint,

+ 1 - 1
lib/ui/sharing/pickers/device_limit_picker_page.dart

@@ -115,7 +115,7 @@ class _ItemsWidgetState extends State<ItemsWidget> {
       key: ValueKey(deviceLimit),
       menuItemColor: getEnteColorScheme(context).fillFaint,
       captionedTextWidget: CaptionedTextWidget(
-        title: "$deviceLimit",
+        title: deviceLimit == 0 ? S.of(context).unlimited : "$deviceLimit",
       ),
       trailingIcon: currentDeviceLimit == deviceLimit ? Icons.check : null,
       alignCaptionedTextToLeft: true,