0ct0pu5/ente
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[mob] Clean up + rethrow remote fetch error

Browse source
This commit is contained in:
Neeraj Gupta 2024-04-11 15:40:31 +05:30
parent ff4e64819b
commit de96f108c2
2 changed files with 5 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
mobile/lib/services/machine_learning/semantic_search/embedding_store.dart
View file

@ -49,7 +49,7 @@ class EmbeddingStore {
_remoteSyncStatus = null;
return true;
} catch (e, s) {
_logger.severe("failed to fetch from remote", e, s);
_logger.severe("failed to fetch & store remote embeddings", e, s);
_remoteSyncStatus!.complete(false);
_remoteSyncStatus = null;
return false;
@ -125,9 +125,7 @@ class EmbeddingStore {
final remoteEmbeddings = <RemoteEmbedding>[];
try {
final sinceTime = _preferences.getInt(kEmbeddingsSyncTimeKey) ?? 0;
_logger.info(
"Fetching embeddings since $sinceTime (${DateTime.fromMicrosecondsSinceEpoch(sinceTime)})",
);
_logger.info("Fetching embeddings since $sinceTime");
final response = await _dio.get(
"/embeddings/diff",
queryParameters: {
@ -142,7 +140,8 @@ class EmbeddingStore {
remoteEmbeddings.add(embedding);
}
} catch (e, s) {
_logger.severe(e, s);
_logger.warning("Fetching embeddings failed", e, s);
rethrow;
}
_logger.info("${remoteEmbeddings.length} embeddings fetched");

8
mobile/lib/services/search_service.dart
View file

@ -1,7 +1,6 @@
import "dart:math";
import "package:flutter/cupertino.dart";
import "package:flutter/foundation.dart";
import "package:intl/intl.dart";
import 'package:logging/logging.dart';
import "package:photos/core/constants.dart";
@ -840,12 +839,7 @@ class SearchService {
_logger.severe("Error occurred during magic search", e, s);
return searchResults;
}
if (files.isNotEmpty) {
if (kDebugMode) {
debugPrint(
"getMagicSearchResults ($query) results: ${files.length} for $resultForQuery ",
);
}
if (files.isNotEmpty && resultForQuery == query) {
searchResults.add(GenericSearchResult(ResultType.magic, query, files));
}
return searchResults;