Explorar o código

[mob][photos] Remove optional parameter which should never be used

Since generatedID (_id) has NOT NULL constrain, it shouldn't be in a parameter set of a query
ashilkn hai 1 ano
pai
achega
cd023b621a
Modificáronse 1 ficheiros con 1 adicións e 12 borrados
  1. 1 12
      mobile/lib/db/files_db.dart

+ 1 - 12
mobile/lib/db/files_db.dart

@@ -1161,16 +1161,6 @@ class FilesDB {
   }
 
   Future<void> updateUploadedFileAcrossCollections(EnteFile file) async {
-    final db = await instance.sqliteAsyncDB;
-    final setClause = _getSetClauseForFileWithoutCollection(file);
-    await db.execute(
-      'UPDATE $filesTable SET '
-      '$setClause WHERE $columnUploadedFileID = ?',
-      [file.uploadedFileID],
-    );
-  }
-
-  Future<void> updateUploadedFileAcrossCollectionsNew(EnteFile file) async {
     final db = await instance.sqliteAsyncDB;
     final parameterSet = _getParameterSetForFile(file, omitCollectionId: true)
       ..add(file.uploadedFileID);
@@ -1832,7 +1822,6 @@ class FilesDB {
 
   List<Object?> _getParameterSetForFile(
     EnteFile file, {
-    bool omitNullGenId = true,
     bool omitCollectionId = false,
   }) {
     final values = <Object?>[];
@@ -1849,7 +1838,7 @@ class FilesDB {
         longitude = file.pubMagicMetadata!.long;
       }
     }
-    if (file.generatedID != null || !omitNullGenId) {
+    if (file.generatedID != null) {
       values.add(file.generatedID);
     }
     values.addAll([