0ct0pu5/ente
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[mob][photos] Remove optional parameter which should never be used

Browse source 
Since generatedID (_id) has NOT NULL constrain, it shouldn't be in a parameter set of a query
This commit is contained in:
ashilkn 2024-05-16 12:59:19 +05:30
parent 7fdc2b5e66
commit cd023b621a
1 changed files with 1 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
mobile/lib/db/files_db.dart
View file

@ -1161,16 +1161,6 @@ class FilesDB {
}
Future<void> updateUploadedFileAcrossCollections(EnteFile file) async {
final db = await instance.sqliteAsyncDB;
final setClause = _getSetClauseForFileWithoutCollection(file);
await db.execute(
'UPDATE $filesTable SET '
'$setClause WHERE $columnUploadedFileID = ?',
[file.uploadedFileID],
);
}
Future<void> updateUploadedFileAcrossCollectionsNew(EnteFile file) async {
final db = await instance.sqliteAsyncDB;
final parameterSet = _getParameterSetForFile(file, omitCollectionId: true)
..add(file.uploadedFileID);
@ -1832,7 +1822,6 @@ class FilesDB {
List<Object?> _getParameterSetForFile(
EnteFile file, {
bool omitNullGenId = true,
bool omitCollectionId = false,
}) {
final values = <Object?>[];
@ -1849,7 +1838,7 @@ class FilesDB {
longitude = file.pubMagicMetadata!.long;
}
}
if (file.generatedID != null || !omitNullGenId) {
if (file.generatedID != null) {
values.add(file.generatedID);
}
values.addAll([