0ct0pu5/ente
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor code for recursively fetching diff

Browse source
This commit is contained in:
Vishnu Mohandas 2020-05-26 02:13:17 +05:30
parent e47cc4fe20
commit bd049d00dd
1 changed files with 20 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
lib/photo_sync_manager.dart
View file

@ -73,21 +73,27 @@ class PhotoSyncManager {
}
if (photos.isEmpty) {
_isSyncInProgress = false;
_syncPhotosWithServer().then((_) {
_deletePhotosOnServer();
});
_syncWithRemote(prefs);
} else {
photos.sort((first, second) =>
first.createTimestamp.compareTo(second.createTimestamp));
_updateDatabase(photos, prefs, lastDBUpdateTimestamp).then((_) {
_isSyncInProgress = false;
_syncPhotosWithServer().then((_) {
_deletePhotosOnServer();
});
_syncWithRemote(prefs);
});
}
}
Future<void> _syncWithRemote(SharedPreferences prefs) {
// TODO: Fix race conditions triggered due to concurrent syncs.
// Add device_id/last_sync_timestamp to the upload request?
return _downloadDiff(prefs).then((_) {
_uploadDiff(prefs).then((_) {
_deletePhotosOnServer();
});
});
}
Future<bool> _updateDatabase(final List<Photo> photos,
SharedPreferences prefs, int lastDBUpdateTimestamp) async {
var photosToBeAdded = List<Photo>();
@ -100,25 +106,16 @@ class PhotoSyncManager {
photosToBeAdded, prefs, DateTime.now().microsecondsSinceEpoch);
}
_syncPhotosWithServer() async {
SharedPreferences prefs = await SharedPreferences.getInstance();
var shouldFetchDiff = true;
while (shouldFetchDiff) {
int lastSyncTimestamp = _getLastSyncTimestamp(prefs);
var diff = await _getDiff(lastSyncTimestamp, _diffLimit);
if (diff != null && diff.isNotEmpty) {
await _storeDiff(diff, prefs);
PhotoRepository.instance.reloadPhotos();
}
if (diff == null || diff.length < _diffLimit) {
shouldFetchDiff = false;
Future<void> _downloadDiff(SharedPreferences prefs) async {
int lastSyncTimestamp = _getLastSyncTimestamp(prefs);
var diff = await _getDiff(lastSyncTimestamp, _diffLimit);
if (diff != null && diff.isNotEmpty) {
await _storeDiff(diff, prefs);
PhotoRepository.instance.reloadPhotos();
if (diff.length == _diffLimit) {
return await _downloadDiff(prefs);
}
}
_uploadDiff(prefs);
// TODO: Fix race conditions triggered due to concurrent syncs.
// Add device_id/last_sync_timestamp to the upload request?
}
int _getLastSyncTimestamp(SharedPreferences prefs) {