0ct0pu5/ente
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove listeners properly

Browse source
This commit is contained in:
ashilkn 2022-11-18 18:27:39 +05:30
parent 264a7433fc
commit bb66f60829
2 changed files with 16 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/ui/components/expandable_menu_item_widget.dart
View file

@ -25,15 +25,13 @@ class _ExpandableMenuItemWidgetState extends State<ExpandableMenuItemWidget> {
final expandableController = ExpandableController(initialExpanded: false);
@override
void initState() {
expandableController.addListener(() {
setState(() {});
});
expandableController.addListener(_expandableControllerListener);
super.initState();
}
@override
void dispose() {
expandableController.removeListener(() {});
expandableController.removeListener(_expandableControllerListener);
super.dispose();
}
@ -81,4 +79,8 @@ class _ExpandableMenuItemWidgetState extends State<ExpandableMenuItemWidget> {
),
);
}
void _expandableControllerListener() {
setState(() {});
}
}

18
lib/ui/viewer/file/file_caption_widget.dart
View file

@ -22,13 +22,7 @@ class _FileCaptionWidgetState extends State<FileCaptionWidget> {
@override
void initState() {
_focusNode.addListener(() {
final caption = widget.file.caption;
if (_focusNode.hasFocus && caption != null) {
_textController.text = caption;
editedCaption = caption;
}
});
_focusNode.addListener(_focusNodeListener);
editedCaption = widget.file.caption;
if (editedCaption != null && editedCaption!.isNotEmpty) {
hintText = editedCaption!;
@ -42,7 +36,7 @@ class _FileCaptionWidgetState extends State<FileCaptionWidget> {
editFileCaption(null, widget.file, editedCaption);
}
_textController.dispose();
_focusNode.removeListener(() {});
_focusNode.removeListener(_focusNodeListener);
super.dispose();
}
@ -107,4 +101,12 @@ class _FileCaptionWidgetState extends State<FileCaptionWidget> {
},
);
}
void _focusNodeListener() {
final caption = widget.file.caption;
if (_focusNode.hasFocus && caption != null) {
_textController.text = caption;
editedCaption = caption;
}
}
}