Show loading states within MenuItemWidget

lib/ui/actions/collection/collection_sharing_actions.dart

@@ -36,21 +36,13 @@ class CollectionActions {
     Collection collection, {
     bool enableCollect = false,
   }) async {
-    final dialog = createProgressDialog(
-      context,
-      "Creating link...",
-      isDismissible: true,
-    );
     try {
-      await dialog.show();
       await CollectionsService.instance.createShareUrl(
         collection,
         enableCollect: enableCollect,
       );
-      dialog.hide();
       return true;
     } catch (e) {
-      dialog.hide();
       if (e is SharingNotPermittedForFreeAccountsError) {
         _showUnSupportedAlert(context);
       } else {

lib/ui/sharing/album_participants_page.dart

@@ -160,7 +160,7 @@ class _AlbumParticipantsPageState extends State<AlbumParticipantsPage> {
                           trailingIconIsMuted: true,
                           onTap: () async {
                             if (isOwner) {
-                              await _navigateToManageUser(currentUser);
+                              _navigateToManageUser(currentUser);
                             }
                           },
                           isTopBorderRadiusRemoved: listIndex > 0,
@@ -185,7 +185,7 @@ class _AlbumParticipantsPageState extends State<AlbumParticipantsPage> {
                       menuItemColor: getEnteColorScheme(context).fillFaint,
                       pressedColor: getEnteColorScheme(context).fillFaint,
                       onTap: () async {
-                        await _navigateToAddUser(false);
+                        _navigateToAddUser(false);
                       },
                       isTopBorderRadiusRemoved: collaborators.isNotEmpty,
                       borderRadius: 8,
@@ -259,7 +259,7 @@ class _AlbumParticipantsPageState extends State<AlbumParticipantsPage> {
                       menuItemColor: getEnteColorScheme(context).fillFaint,
                       pressedColor: getEnteColorScheme(context).fillFaint,
                       onTap: () async {
-                        await _navigateToAddUser(true);
+                        _navigateToAddUser(true);
                       },
                       isTopBorderRadiusRemoved: viewers.isNotEmpty,
                       borderRadius: 8,

lib/ui/sharing/manage_album_participant.dart

@@ -80,7 +80,6 @@ class _ManageIndividualParticipantState
                         widget.collection,
                         widget.user.email,
                         role: CollectionParticipantRole.collaborator,
-                        showProgress: true,
                       );
                       if ((result ?? false) && mounted) {
                         widget.user.role = CollectionParticipantRole
@@ -113,7 +112,6 @@ class _ManageIndividualParticipantState
                         widget.collection,
                         widget.user.email,
                         role: CollectionParticipantRole.viewer,
-                        showProgress: true,
                       );
                       if ((result ?? false) && mounted) {
                         widget.user.role =
@@ -139,6 +137,7 @@ class _ManageIndividualParticipantState
               leadingIconColor: warning500,
               menuItemColor: getEnteColorScheme(context).fillFaint,
               pressedColor: getEnteColorScheme(context).fillFaint,
+              surfaceExecutionStates: false,
               onTap: () async {
                 final result = await collectionActions.removeParticipant(
                   context,

lib/ui/sharing/manage_links_widget.dart

@@ -113,6 +113,7 @@ class _ManageSharedLinkWidgetState extends State<ManageSharedLinkWidget> {
                     ),
                     trailingIcon: Icons.chevron_right,
                     menuItemColor: enteColorScheme.fillFaint,
+                    surfaceExecutionStates: false,
                     onTap: () async {
                       await showPicker();
                     },
@@ -140,6 +141,7 @@ class _ManageSharedLinkWidgetState extends State<ManageSharedLinkWidget> {
                     onTap: () async {
                       await _showDeviceLimitPicker();
                     },
+                    surfaceExecutionStates: false,
                   ),
                   DividerWidget(
                     dividerType: DividerType.menuNoIcon,
@@ -225,6 +227,7 @@ class _ManageSharedLinkWidgetState extends State<ManageSharedLinkWidget> {
                     leadingIconColor: warning500,
                     menuItemColor: getEnteColorScheme(context).fillFaint,
                     pressedColor: getEnteColorScheme(context).fillFaint,
+                    surfaceExecutionStates: false,
                     onTap: () async {
                       final bool result = await sharingActions.disableUrl(
                         context,

lib/ui/sharing/share_collection_page.dart

@@ -170,6 +170,7 @@ class _ShareCollectionPageState extends State<ShareCollectionPage> {
               leadingIcon: Icons.copy,
               menuItemColor: getEnteColorScheme(context).fillFaint,
               pressedColor: getEnteColorScheme(context).fillFaint,
+              showOnlyLoadingState: true,
               onTap: () async {
                 await Clipboard.setData(ClipboardData(text: url));
                 showShortToast(context, "Link copied to clipboard");
@@ -239,6 +240,7 @@ class _ShareCollectionPageState extends State<ShareCollectionPage> {
           menuItemColor: getEnteColorScheme(context).fillFaint,
           pressedColor: getEnteColorScheme(context).fillFaint,
           isBottomBorderRadiusRemoved: true,
+          showOnlyLoadingState: true,
           onTap: () async {
             final bool result =
                 await collectionActions.enableUrl(context, widget.collection);
@@ -259,6 +261,7 @@ class _ShareCollectionPageState extends State<ShareCollectionPage> {
           leadingIcon: Icons.link,
           menuItemColor: getEnteColorScheme(context).fillFaint,
           pressedColor: getEnteColorScheme(context).fillFaint,
+          showOnlyLoadingState: true,
           onTap: () async {
             final bool result = await collectionActions.enableUrl(
               context,

lib/ui/tools/debug/app_storage_viewer.dart

@@ -164,6 +164,7 @@ class _AppStorageViewerState extends State<AppStorageViewer> {
                             pressedColor:
                                 getEnteColorScheme(context).fillFaintPressed,
                             borderRadius: 8,
+                            alwaysShowSuccessState: true,
                             onTap: () async {
                               for (var pathItem in paths) {
                                 if (pathItem.allowCacheClear) {

lib/ui/viewer/gallery/device_folder_page.dart

@@ -238,6 +238,7 @@ class _ResetIgnoredFilesWidgetState extends State<ResetIgnoredFilesWidget> {
           borderRadius: 8.0,
           menuItemColor: getEnteColorScheme(context).fillFaint,
           leadingIcon: Icons.cloud_off_outlined,
+          alwaysShowSuccessState: true,
           onTap: () async {
             await _removeFilesFromIgnoredFiles(
               widget.filesInDeviceCollection,