Explorar el Código

Fixed app fetching userDetails multiple times when opening settings by swiping

ashilkn hace 2 años
padre
commit
b4aab74254

+ 0 - 3
lib/ui/components/home_header_widget.dart

@@ -1,6 +1,4 @@
 import 'package:flutter/material.dart';
-import 'package:photos/core/event_bus.dart';
-import 'package:photos/events/opened_settings_event.dart';
 import 'package:photos/ui/components/icon_button_widget.dart';
 import 'package:photos/ui/viewer/search/search_widget.dart';
 
@@ -24,7 +22,6 @@ class _HomeHeaderWidgetState extends State<HomeHeaderWidget> {
           icon: Icons.menu_outlined,
           onTap: () {
             Scaffold.of(context).openDrawer();
-            Bus.instance.fire(OpenedSettingsEvent());
           },
         ),
         AnimatedSwitcher(

+ 0 - 3
lib/ui/extents_page_view.dart

@@ -3,8 +3,6 @@
 import 'package:flutter/gestures.dart';
 import 'package:flutter/rendering.dart';
 import 'package:flutter/widgets.dart' hide PageView;
-import 'package:photos/core/event_bus.dart';
-import 'package:photos/events/opened_settings_event.dart';
 
 /// This is copy-pasted from the Flutter framework with a support added for building
 /// pages off screen using [Viewport.cacheExtents] and a [LayoutBuilder]
@@ -295,7 +293,6 @@ class _PageViewState extends State<ExtentsPageView> {
         ? widget.controller.addListener(() {
             if (widget.controller.offset < -45) {
               widget.openDrawer();
-              Bus.instance.fire(OpenedSettingsEvent());
             }
           })
         : null;

+ 3 - 0
lib/ui/settings_page.dart

@@ -5,6 +5,8 @@ import 'dart:io';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:photos/core/configuration.dart';
+import 'package:photos/core/event_bus.dart';
+import 'package:photos/events/opened_settings_event.dart';
 import 'package:photos/services/feature_flag_service.dart';
 import 'package:photos/theme/colors.dart';
 import 'package:photos/theme/ente_theme.dart';
@@ -27,6 +29,7 @@ class SettingsPage extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
+    Bus.instance.fire(OpenedSettingsEvent());
     final enteColorScheme = getEnteColorScheme(context);
     return Scaffold(
       body: Container(