From acbbd8d049fef19ac6e68dcae28d5b409ebca7ac Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Tue, 5 Sep 2023 08:21:11 +0530 Subject: [PATCH] Minor imporvement --- lib/store/code_store.dart | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/lib/store/code_store.dart b/lib/store/code_store.dart index cf04f1aab..a20296c32 100644 --- a/lib/store/code_store.dart +++ b/lib/store/code_store.dart @@ -90,23 +90,19 @@ class CodeStore { Future importOfflineCodes() async { try { - _logger.info('starting offline imports'); Configuration config = Configuration.instance; - // Account isn't configured yet, so we can't import offline codes - if (!config.hasConfiguredAccount()) { - return; - } - // Never opted for offline mode, so we can't import offline codes - if (!config.hasOptedForOfflineMode()) { - return; - } - Uint8List? hasOfflineKey = config.getOfflineSecretKey(); - if (hasOfflineKey == null) { - // No offline key, so we can't import offline codes + if (!config.hasConfiguredAccount() || + !config.hasOptedForOfflineMode() || + config.getOfflineSecretKey() == null) { return; } + _logger.info('starting offline imports'); + List offlineCodes = await CodeStore.instance.getAllCodes(accountMode: AccountMode.offline); + if(offlineCodes.isEmpty) { + return; + } bool isOnlineSyncDone = await AuthenticatorService.instance.onlineSync(); if(!isOnlineSyncDone) { debugPrint("Skipping offline import since online sync failed"); @@ -122,7 +118,6 @@ class CodeStore { generatedIDs: [eachCode.generatedID!], ); } - OfflineAuthenticatorDB.instance.clearTable(); AuthenticatorService.instance.onlineSync().ignore(); } catch (e, s) { _logger.severe("error while importing offline codes", e, s);