Explorar o código

Validate empty list check in getFilesFromIDs

Neeraj Gupta %!s(int64=3) %!d(string=hai) anos
pai
achega
86842ad2f6
Modificáronse 2 ficheiros con 4 adicións e 4 borrados
  1. 4 1
      lib/db/files_db.dart
  2. 0 3
      lib/services/deduplication_service.dart

+ 4 - 1
lib/db/files_db.dart

@@ -875,6 +875,10 @@ class FilesDB {
   }
 
   Future<Map<int, File>> getFilesFromIDs(List<int> ids) async {
+    final result = <int, File>{};
+    if (ids.isEmpty) {
+      return result;
+    }
     String inParam = "";
     for (final id in ids) {
       inParam += "'" + id.toString() + "',";
@@ -886,7 +890,6 @@ class FilesDB {
       where: '$columnUploadedFileID IN ($inParam)',
     );
     final files = _convertToFiles(results);
-    final result = <int, File>{};
     for (final file in files) {
       result[file.uploadedFileID] = file;
     }

+ 0 - 3
lib/services/deduplication_service.dart

@@ -19,9 +19,6 @@ class DeduplicationService {
   Future<List<DuplicateFiles>> getDuplicateFiles() async {
     try {
       DuplicateFilesResponse dupes = await _fetchDuplicateFileIDs();
-      if (dupes.duplicates.isEmpty) {
-        return <DuplicateFiles>[];
-      }
       final ids = <int>[];
       for (final dupe in dupes.duplicates) {
         ids.addAll(dupe.fileIDs);