0ct0pu5/ente
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Flicker bug fix (#1067)

Browse source
This commit is contained in:
Ashil 2023-05-04 19:59:55 +05:30 • committed by GitHub
commit 85e361d667
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/ui/viewer/file/detail_page.dart
View file

@ -117,6 +117,7 @@ class _DetailPageState extends State<DetailPage> {
key: _appBarKey,
),
extendBodyBehindAppBar: true,
resizeToAvoidBottomInset: false,
body: Center(
child: Stack(
children: [

52
lib/ui/viewer/location/dynamic_location_gallery_widget.dart
View file

@ -91,27 +91,32 @@ class _DynamicLocationGalleryWidgetState
),
builder: (context, snapshot) {
if (snapshot.hasData) {
return SizedBox(
height: _galleryHeight(
min(
(widget.memoriesCountNotifier.value ?? 0),
galleryFilesLimit,
),
),
child: Gallery(
loadingWidget: const SizedBox.shrink(),
disableScroll: true,
asyncLoader: (
creationStartTime,
creationEndTime, {
limit,
asc,
}) async {
return snapshot.data as FileLoadResult;
},
tagPrefix: widget.tagPrefix,
shouldCollateFilesByDay: false,
),
return LayoutBuilder(
builder: (context, constrains) {
return SizedBox(
height: _galleryHeight(
min(
(widget.memoriesCountNotifier.value ?? 0),
galleryFilesLimit,
),
constrains.maxWidth,
),
child: Gallery(
loadingWidget: const SizedBox.shrink(),
disableScroll: true,
asyncLoader: (
creationStartTime,
creationEndTime, {
limit,
asc,
}) async {
return snapshot.data as FileLoadResult;
},
tagPrefix: widget.tagPrefix,
shouldCollateFilesByDay: false,
),
);
},
);
} else {
return const SizedBox.shrink();
@ -121,14 +126,13 @@ class _DynamicLocationGalleryWidgetState
);
}
double _galleryHeight(int fileCount) {
double _galleryHeight(int fileCount, double widthOfGrid) {
final photoGridSize = LocalSettings.instance.getPhotoGridSize();
final totalWhiteSpaceBetweenPhotos =
galleryGridSpacing * (photoGridSize - 1);
final thumbnailHeight =
((MediaQuery.of(context).size.width - totalWhiteSpaceBetweenPhotos) /
photoGridSize);
((widthOfGrid - totalWhiteSpaceBetweenPhotos) / photoGridSize);
final numberOfRows = (fileCount / photoGridSize).ceil();