0ct0pu5/ente
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[mob][photos] Put faces behind feature flag

Browse source
This commit is contained in:
laurenspriem 2024-05-20 14:51:35 +05:30
parent 76848c826e
commit 84f7d20966
4 changed files with 17 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
mobile/lib/main.dart
View file

@ -240,9 +240,15 @@ Future<void> _init(bool isBackground, {String via = ''}) async {
// See https://gitlab.com/fdroid/fdroiddata/-/merge_requests/12671#note_1294346819
if (!UpdateService.instance.isFdroidFlavor()) {
// unawaited(ObjectDetectionService.instance.init());
unawaited(FaceMlService.instance.init());
FaceMlService.instance.listenIndexOnDiffSync();
FaceMlService.instance.listenOnPeopleChangedSync();
if (flagService.faceSearchEnabled) {
unawaited(FaceMlService.instance.init());
FaceMlService.instance.listenIndexOnDiffSync();
FaceMlService.instance.listenOnPeopleChangedSync();
} else {
if (LocalSettings.instance.isFaceIndexingEnabled) {
unawaited(LocalSettings.instance.toggleFaceIndexing());
}
}
}
PersonService.init(
EntityService.instance,

5
mobile/lib/ui/settings/machine_learning_settings_page.dart
View file

@ -64,6 +64,7 @@ class _MachineLearningSettingsPageState
@override
Widget build(BuildContext context) {
final bool facesFlag = flagService.faceSearchEnabled;
return Scaffold(
body: CustomScrollView(
primary: false,
@ -96,7 +97,9 @@ class _MachineLearningSettingsPageState
children: [
_getMagicSearchSettings(context),
const SizedBox(height: 12),
_getFacesSearchSettings(context),
facesFlag
? _getFacesSearchSettings(context)
: const SizedBox.shrink(),
],
),
),

4
mobile/lib/ui/settings_page.dart
View file

@ -144,7 +144,9 @@ class SettingsPage extends StatelessWidget {
if (hasLoggedIn && flagService.internalUser) {
contents.addAll([sectionSpacing, const DebugSectionWidget()]);
contents.addAll([sectionSpacing, const FaceDebugSectionWidget()]);
if (flagService.faceSearchEnabled) {
contents.addAll([sectionSpacing, const FaceDebugSectionWidget()]);
}
}
contents.add(const AppVersionWidget());
contents.add(const DeveloperSettingsWidget());

2
mobile/plugins/ente_feature_flag/lib/src/service.dart
View file

@ -67,7 +67,7 @@ class FlagService {
bool get mapEnabled => flags.mapEnabled;
bool get faceSearchEnabled => flags.faceSearchEnabled;
bool get faceSearchEnabled => internalUser || flags.faceSearchEnabled;
bool get passKeyEnabled => flags.passKeyEnabled || internalOrBetaUser;