浏览代码

Perf: Avoid redundant copy and clear during collateFiles (#1065)

Neeraj Gupta 2 年之前
父节点
当前提交
7bfb4b9030
共有 2 个文件被更改,包括 6 次插入6 次删除
  1. 3 1
      .gitignore
  2. 3 5
      lib/ui/viewer/gallery/gallery.dart

+ 3 - 1
.gitignore

@@ -39,4 +39,6 @@ lib/generated_plugin_registrant.dart
 android/key.properties
 android/key.properties
 android/app/.settings/*
 android/app/.settings/*
 .env
 .env
-fastlane/report.xml
+
+
+fastlane/report.xml

+ 3 - 5
lib/ui/viewer/gallery/gallery.dart

@@ -296,7 +296,7 @@ class _GalleryState extends State<Gallery> {
   }
   }
 
 
   List<List<File>> _collateFiles(List<File> files) {
   List<List<File>> _collateFiles(List<File> files) {
-    final List<File> dailyFiles = [];
+    List<File> dailyFiles = [];
     final List<List<File>> collatedFiles = [];
     final List<List<File>> collatedFiles = [];
     for (int index = 0; index < files.length; index++) {
     for (int index = 0; index < files.length; index++) {
       if (index > 0 &&
       if (index > 0 &&
@@ -304,10 +304,8 @@ class _GalleryState extends State<Gallery> {
             files[index - 1].creationTime!,
             files[index - 1].creationTime!,
             files[index].creationTime!,
             files[index].creationTime!,
           )) {
           )) {
-        final List<File> collatedDailyFiles = [];
-        collatedDailyFiles.addAll(dailyFiles);
-        collatedFiles.add(collatedDailyFiles);
-        dailyFiles.clear();
+        collatedFiles.add(dailyFiles);
+        dailyFiles = [];
       }
       }
       dailyFiles.add(files[index]);
       dailyFiles.add(files[index]);
     }
     }