0ct0pu5/ente
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix error check for no-object found

Browse source
This commit is contained in:
Neeraj Gupta 2024-05-14 14:37:24 +05:30
parent 18d1bb60ca
commit 74a6e32538
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
server/pkg/controller/embedding/controller.go
View file

@ -421,11 +421,11 @@ func (c *Controller) getEmbeddingObject(ctx context.Context, objectKey string, d
return obj, nil
}
// Check if the error is due to context timeout or cancellation
if fetchCtx.Err() != nil {
if err == nil && fetchCtx.Err() != nil {
ctxLogger.Error("Fetch timed out or cancelled: ", fetchCtx.Err())
} else {
// check if the error is due to object not found
if s3Err, ok := err.(awserr.Error); ok {
if s3Err, ok := errors.Unwrap(err).(awserr.Error); ok {
if s3Err.Code() == s3.ErrCodeNoSuchKey {
ctxLogger.Warn("Object not found: ", s3Err)
return ente.EmbeddingObject{}, stacktrace.Propagate(errors.New("object not found"), "")
@ -446,7 +446,7 @@ func (c *Controller) downloadObject(ctx context.Context, objectKey string, downl
Key: &objectKey,
})
if err != nil {
return obj, stacktrace.Propagate(err, "downloadFailed")
return obj, err
}
err = json.Unmarshal(buff.Bytes(), &obj)
if err != nil {