Refactored by not calling getExif() twice and only once

lib/ui/viewer/file/file_details_widget.dart

@@ -248,7 +248,7 @@ class _FileDetailsWidgetState extends State<FileDetailsWidget> {
 
   Future<bool> _setLocationDataFromExif() async {
     final locationDataFromExif =
-        (await gpsDataFromExif(widget.file)).toLocationObj();
+        (await gpsDataFromExif(_exifNotifier.value!)).toLocationObj();
     if (locationDataFromExif?.latitude != null &&
         locationDataFromExif?.longitude != null) {
       widget.file.location = locationDataFromExif;

lib/utils/exif_util.dart

@@ -48,14 +48,13 @@ Future<DateTime?> getCreationTimeFromEXIF(io.File file) async {
   return null;
 }
 
-Future<GPSData> gpsDataFromExif(File file) async {
+Future<GPSData> gpsDataFromExif(Map<String, IfdTag> exif) async {
   final Map<String, dynamic> exifLocationData = {
     "lat": null,
     "long": null,
     "latRef": null,
     "longRef": null,
   };
-  final exif = await getExif(file);
   if (exif["GPS GPSLatitude"] != null) {
     exifLocationData["lat"] = exif["GPS GPSLatitude"]!
         .values

lib/utils/file_uploader_util.dart

@@ -160,13 +160,15 @@ Future<void> _decorateEnteFileData(ente.File file, AssetEntity asset) async {
       //In some devices, asset.latlngAsync() doesn't fetch the location data even
       //if it is present. In such cases, extract location data from EXIF.
       try {
-        final locationData = (await gpsDataFromExif(file)).toLocationObj();
+        final exif = await getExif(file);
+        final locationData = (await gpsDataFromExif(exif)).toLocationObj();
         latLong = LatLng(
           latitude: locationData?.latitude,
           longitude: locationData?.longitude,
         );
       } catch (e, s) {
         _logger.warning("Failed to get location from exif", e, s);
+        return;
       }
     }
     file.location =