From 6af54befc8f1820f4e60a3ba860aace8a990c035 Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Fri, 19 May 2023 13:20:18 +0530 Subject: [PATCH] Fix lint warnings --- lib/ui/actions/file/file_actions.dart | 2 +- lib/ui/home/header_error_widget.dart | 2 +- lib/ui/sharing/pickers/link_expiry_picker_page.dart | 2 +- .../viewer/gallery/component/non_recyclable_view_widget.dart | 2 +- lib/utils/device_info.dart | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/ui/actions/file/file_actions.dart b/lib/ui/actions/file/file_actions.dart index 9be0e5814..167558890 100644 --- a/lib/ui/actions/file/file_actions.dart +++ b/lib/ui/actions/file/file_actions.dart @@ -26,7 +26,7 @@ Future showSingleFileDeleteSheet( file.uploadedFileID != null && file.localID != null; final bool isLocalOnly = file.uploadedFileID == null && file.localID != null; final bool isRemoteOnly = file.uploadedFileID != null && file.localID == null; - String bodyHighlight = S.of(context).singleFileDeleteHighlight; + final String bodyHighlight = S.of(context).singleFileDeleteHighlight; String body = ""; if (isBothLocalAndRemote) { body = S.of(context).singleFileInBothLocalAndRemote(fileType); diff --git a/lib/ui/home/header_error_widget.dart b/lib/ui/home/header_error_widget.dart index 0ab7b9e3d..868866e32 100644 --- a/lib/ui/home/header_error_widget.dart +++ b/lib/ui/home/header_error_widget.dart @@ -107,7 +107,7 @@ class HeaderErrorWidget extends StatelessWidget { const Padding(padding: EdgeInsets.all(4)), Text( S.of(context).couldNotBackUpTryLater, - style: TextStyle(height: 1.4), + style: const TextStyle(height: 1.4), textAlign: TextAlign.center, ), const Padding(padding: EdgeInsets.all(8)), diff --git a/lib/ui/sharing/pickers/link_expiry_picker_page.dart b/lib/ui/sharing/pickers/link_expiry_picker_page.dart index 3aa6f54a9..e575f94d3 100644 --- a/lib/ui/sharing/pickers/link_expiry_picker_page.dart +++ b/lib/ui/sharing/pickers/link_expiry_picker_page.dart @@ -61,7 +61,7 @@ class LinkExpiryPickerPage extends StatelessWidget { class ItemsWidget extends StatefulWidget { final Collection collection; - ItemsWidget(this.collection, {super.key}); + const ItemsWidget(this.collection, {super.key}); @override State createState() => _ItemsWidgetState(); diff --git a/lib/ui/viewer/gallery/component/non_recyclable_view_widget.dart b/lib/ui/viewer/gallery/component/non_recyclable_view_widget.dart index 7b97fa71a..e5d27a270 100644 --- a/lib/ui/viewer/gallery/component/non_recyclable_view_widget.dart +++ b/lib/ui/viewer/gallery/component/non_recyclable_view_widget.dart @@ -42,7 +42,7 @@ class _NonRecyclableViewWidgetState extends State { @override Widget build(BuildContext context) { - if (!_shouldRender!) { + if (!_shouldRender) { return VisibilityDetector( key: Key("gallery" + widget.filesInDay.first.tag), onVisibilityChanged: (visibility) { diff --git a/lib/utils/device_info.dart b/lib/utils/device_info.dart index 1bb2a5ac4..459eb00ea 100644 --- a/lib/utils/device_info.dart +++ b/lib/utils/device_info.dart @@ -4,10 +4,10 @@ import "package:device_info/device_info.dart"; import 'package:flutter/foundation.dart'; import 'package:logging/logging.dart'; -late DeviceInfoPlugin deviceInfoPlugin = DeviceInfoPlugin(); +DeviceInfoPlugin deviceInfoPlugin = DeviceInfoPlugin(); // https://gist.github.com/adamawolf/3048717 -late Set iOSLowEndMachineCodes = { +final Set iOSLowEndMachineCodes = { "iPhone5,1", //iPhone 5 (GSM) "iPhone5,2", //iPhone 5 (GSM+CDMA) "iPhone5,3", //iPhone 5C (GSM)