0ct0pu5/ente
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[web] Exit fullscreen if needed when pressing the info button

Browse source 
Fixes: Info button is not working when videos are playing in full screen mode.

**Tested by**

Wasn't working before, but it works now. Still doesn't work with the keybinding,
have left a note about that in the code.
This commit is contained in:
Manav Rathi 2024-03-14 15:35:31 +05:30
parent 318e8643fb
commit 56b750c1ac
No known key found for this signature in database
1 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
web/apps/photos/src/components/PhotoViewer/index.tsx
View file

@ -178,6 +178,14 @@ function PhotoViewer(props: Iprops) {
switch (event.key) {
case "i":
case "I":
// Enhancement: This should be calling handleOpenInfo, but
// that handling the case where a keybinding triggers an
// exit from fullscreen and opening the info drawer is not
// currently working (the info drawer opens, but the exit
// from fullscreen doesn't happen).
//
// So for now, let the keybinding only work when not in
// fullscreen instead of doing a mish-mash.
setShowInfo(true);
break;
case "Backspace":
@ -616,7 +624,18 @@ function PhotoViewer(props: Iprops) {
const handleCloseInfo = () => {
setShowInfo(false);
};
const handleOpenInfo = () => {
const handleOpenInfo = (photoSwipe: any) => {
// Get out of full screen mode if needed first to be able to show info
if (isInFullScreenMode) {
const fullScreenApi: PhotoswipeFullscreenAPI =
photoSwipe?.ui?.getFullscreenAPI();
if (fullScreenApi && fullScreenApi.isFullscreen()) {
fullScreenApi.exit();
setIsInFullScreenMode(false);
}
}
setShowInfo(true);
};
@ -851,7 +870,7 @@ function PhotoViewer(props: Iprops) {
<button
className="pswp__button pswp__button--custom"
title={t("INFO_OPTION")}
onClick={handleOpenInfo}
onClick={() => handleOpenInfo(photoSwipe)}
>
<InfoIcon />
</button>