0ct0pu5/ente
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Vids

Browse source
This commit is contained in:
Manav Rathi 2024-05-11 08:38:39 +05:30
parent 3a2cc86136
commit 4cb0e51e34
No known key found for this signature in database
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
web/apps/photos/src/services/download/index.ts
View file

@ -32,9 +32,13 @@ export type SourceURLs = {
isRenderable: boolean;
type: "normal" | "livePhoto";
/**
* Best effort attempt at obtaining the MIME type. This should always be set
* ideally, over time we need to find and fix the types for the cases where
* it can be missing.
* Best effort attempt at obtaining the MIME type.
*
* Known cases where it is missing:
*
* - Live photos (these have a different code path for obtaining the URL).
* - A video that is passes the isPlayable test in the browser.
*
*/
mimeType?: string;
};
@ -518,6 +522,7 @@ async function getRenderableFileURL(
convertedBlob,
);
srcURLs = convertedURL;
mimeType = convertedBlob.type;
break;
}
default: {
@ -622,7 +627,7 @@ async function getPlayableVideo(
// TODO(MR): This might not work for very large (~ GB) videos. Test.
log.info(`Converting video ${videoNameTitle} to mp4`);
const convertedVideoData = await ffmpeg.convertToMP4(videoBlob);
return new Blob([convertedVideoData]);
return new Blob([convertedVideoData], { type: "video/mp4" });
}
} catch (e) {
log.error("Video conversion failed", e);