Fix warnings (#509)

auth/lib/core/logging/tunneled_transport.dart

@@ -27,6 +27,7 @@ class TunneledTransport implements Transport {
     _credentialBuilder = _CredentialBuilder(
       _dsn,
       _options.sentryClientName,
+      // ignore: invalid_use_of_internal_member
       _options.clock,
     );
   }

auth/lib/services/billing_service.dart

@@ -28,8 +28,6 @@ class BillingService {
   final _dio = Network.instance.getDio();
   final _config = Configuration.instance;
 
-  bool _isOnSubscriptionPage = false;
-
   Subscription? _cachedSubscription;
 
   Future<BillingPlans>? _future;
@@ -176,8 +174,4 @@ class BillingService {
       rethrow;
     }
   }
-
-  void setIsOnSubscriptionPage(bool isOnSubscriptionPage) {
-    _isOnSubscriptionPage = isOnSubscriptionPage;
-  }
 }

auth/lib/services/user_service.dart

@@ -486,6 +486,7 @@ class UserService {
         // ignore: need to calculate secret to get M1, unused_local_variable
         final clientS = client.calculateSecret(serverB);
         final clientM = client.calculateClientEvidenceMessage();
+        // ignore: unused_local_variable
         late Response srpCompleteResponse;
         if (setKeysRequest == null) {
           srpCompleteResponse = await _enteDio.post(

auth/lib/store/authenticator_db.dart

@@ -166,7 +166,7 @@ class AuthenticatorDB {
         batch.delete(entityTable, where: whereID, whereArgs: [id]);
       }
     }
-    final result = await batch.commit();
+    await batch.commit();
     debugPrint("Done");
   }
 

auth/lib/store/offline_authenticator_db.dart

@@ -151,7 +151,7 @@ class OfflineAuthenticatorDB {
         batch.delete(entityTable, where: whereID, whereArgs: [id]);
       }
     }
-    final result = await batch.commit();
+    await batch.commit();
     debugPrint("Done");
   }
 

auth/lib/store/user_store.dart

@@ -3,6 +3,7 @@ import 'package:shared_preferences/shared_preferences.dart';
 class UserStore {
   UserStore._privateConstructor();
 
+  // ignore: unused_field
   late SharedPreferences _preferences;
 
   static final UserStore instance = UserStore._privateConstructor();

auth/lib/ui/account/password_entry_page.dart

@@ -317,8 +317,7 @@ class _PasswordEntryPageState extends State<PasswordEntryPage> {
                     onChanged: (cnfPassword) {
                       setState(() {
                         _passwordInInputConfirmationBox = cnfPassword;
-                        if (_passwordInInputBox != null ||
-                            _passwordInInputBox != '') {
+                        if (_passwordInInputBox != '') {
                           _passwordsMatch = _passwordInInputBox ==
                               _passwordInInputConfirmationBox;
                         }

auth/lib/ui/settings/data/data_section_widget.dart

@@ -9,11 +9,8 @@ import 'package:ente_auth/ui/settings/data/export_widget.dart';
 import 'package:ente_auth/ui/settings/data/import_page.dart';
 import 'package:ente_auth/utils/navigation_util.dart';
 import 'package:flutter/material.dart';
-import 'package:logging/logging.dart';
 
 class DataSectionWidget extends StatelessWidget {
-  final _logger = Logger("AccountSectionWidget");
-
   DataSectionWidget({Key? key}) : super(key: key);
 
   @override

auth/lib/ui/settings/data/import_page.dart

@@ -21,7 +21,7 @@ enum ImportType {
 }
 
 class ImportCodePage extends StatelessWidget {
-  late List<ImportType> importOptions = [
+  final List<ImportType> importOptions = [
     ImportType.plainText,
     ImportType.encrypted,
     ImportType.twoFas,

mobile/lib/ui/viewer/gallery/gallery_app_bar_widget.dart

@@ -837,13 +837,13 @@ class _GalleryAppBarWidgetState extends State<GalleryAppBarWidget> {
       hintText: context.l10n.deviceCodeHint,
       onSubmit: (String text) async {
         try {
-          String code = text.trim();
+          final code = text.trim();
           final String? publicKey = await gw.getPublicKey(code);
           if (publicKey == null) {
             showToast(context, S.of(context).deviceNotFound);
             return;
           }
-          final String castToken = Uuid().v4().toString();
+          final String castToken = const Uuid().v4().toString();
           final castPayload = CollectionsService.instance
               .getCastData(castToken, widget.collection!, publicKey);
           await gw.publishCastPayload(

mobile/lib/ui/viewer/search_tab/search_tab.dart

@@ -98,6 +98,7 @@ class _AllSearchSectionsState extends State<AllSearchSections> {
                   padding: const EdgeInsets.only(bottom: 180),
                   physics: const BouncingScrollPhysics(),
                   itemCount: searchTypes.length,
+                  // ignore: body_might_complete_normally_nullable
                   itemBuilder: (context, index) {
                     switch (searchTypes[index]) {
                       case SectionType.album:

mobile/plugins/clip_ggml

@@ -1 +1 @@
-Subproject commit ec5cba9e7c7915c4788d45887e49c1311a3cb4d2
+Subproject commit 16c7daea5d6b80235ac473f1a823b0ff44f5305e