Browse Source

Remove baseUrl that didn't work

From what I've understood, there isn't a way for us to use the baseUrl for
absolute imports without also using a bundler. The baseUrl works for the
tsconfig, but not for the generated JS.

Since this setting was anyways not working, remove it. Tested by doing `yarn
dev`, `yarn build` and also doing a quick perusal in VSCode to see that it is
not reporting any errors.

Refs:

- https://stackoverflow.com/questions/50679031/why-are-these-tsconfig-paths-not-working
- https://github.com/electron-react-boilerplate/electron-react-boilerplate/issues/2737
- https://stackoverflow.com/questions/40407342/resolving-paths-in-typescript-outdir
- https://stackoverflow.com/questions/51683827/using-paths-in-typescript-in-a-nodejs-project
Manav Rathi 1 year ago
parent
commit
2038b036c5
2 changed files with 1 additions and 7 deletions
  1. 1 1
      desktop/src/api/upload.ts
  2. 0 6
      desktop/tsconfig.json

+ 1 - 1
desktop/src/api/upload.ts

@@ -1,10 +1,10 @@
+import { getElectronFile } from "../services/fs";
 import {
     getElectronFilesFromGoogleZip,
     getSavedFilePaths,
 } from "../services/upload";
 import { uploadStatusStore } from "../stores/upload.store";
 import { ElectronFile, FILE_PATH_TYPE } from "../types";
-import { getElectronFile } from "./../services/fs";
 
 export const getPendingUploads = async () => {
     const filePaths = getSavedFilePaths(FILE_PATH_TYPE.FILES);

+ 0 - 6
desktop/tsconfig.json

@@ -50,12 +50,6 @@
         "outDir": "app",
         /* Generate source maps */
         "sourceMap": true,
-        /* Allow absolute imports starting with src as root */
-        "baseUrl": "src",
-        /* Allow imports of paths from node_modules */
-        "paths": {
-            "*": ["node_modules/*"]
-        },
 
         /* Temporary overrides to get things to compile with the older config */
         "strict": false,