diff --git a/.github/workflows/docs-deploy.yml b/.github/workflows/docs-deploy.yml index a6414878f..d41c74b4c 100644 --- a/.github/workflows/docs-deploy.yml +++ b/.github/workflows/docs-deploy.yml @@ -19,11 +19,6 @@ jobs: run: working-directory: docs - # cloudflare/pages-action needs these to create deployments - permissions: - contents: read - deployments: write - steps: - name: Checkout code uses: actions/checkout@v4 @@ -49,5 +44,4 @@ jobs: apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }} projectName: docs-3d7 directory: docs/docs/.vitepress/dist - gitHubToken: ${{ secrets.GITHUB_TOKEN }} wranglerVersion: "3" diff --git a/web/docs/deploy-new.md b/web/docs/deploy-new.md index 7b77d3975..eaaaf40c6 100644 --- a/web/docs/deploy-new.md +++ b/web/docs/deploy-new.md @@ -68,16 +68,3 @@ As a concrete example, the GitHub workflow that deploys `docs/` passes "help" as the branch name. The resulting deployment is available at "help.ente.pages.dev". Finally, we add a custom domain to point to it from [help.ente.io](https://help.ente.io). - -## GitHub deployments - -In our workflow we use the `deployments: write` permission and pass the -resulting `GITHUB_TOKEN` to the Cloudflare Pages Action -([docs](https://github.com/cloudflare/pages-action)). - -This will create "GitHub Deployments" for each deploy. We can see them on the -[Deployments](https://github.com/ente-io/ente/deployments) dashboard; they also -appear on the main repository in the right sidebar. - -TODO(MR): This document is not complete - all these steps have not been -integrated yet, this outlines the general plan.