Browse Source

fix(api): improve non-field error messages

Co-Authored-By: Peter Thomassen <peter@desec.io>
Nils Wisiol 6 years ago
parent
commit
1870c86aed
2 changed files with 3 additions and 1 deletions
  1. 2 0
      api/desecapi/serializers.py
  2. 1 1
      api/desecapi/views.py

+ 2 - 0
api/desecapi/serializers.py

@@ -34,6 +34,8 @@ class RRSerializer(serializers.ModelSerializer):
 
 
 class RRsetBulkListSerializer(BulkListSerializer):
+    default_error_messages = {'not_a_list': 'Invalid input, expected a list of RRsets.'}
+
     @transaction.atomic
     def update(self, queryset, validated_data):
         q = models.Q(pk__isnull=True)

+ 1 - 1
api/desecapi/views.py

@@ -217,7 +217,7 @@ class RRsetDetail(generics.RetrieveUpdateDestroyAPIView):
     def update(self, request, *args, **kwargs):
         if not isinstance(request.data, dict):
             raise ValidationError({
-                api_settings.NON_FIELD_ERRORS_KEY: ['Invalid data. Expected a JSON object.']
+                api_settings.NON_FIELD_ERRORS_KEY: ['Invalid input, expected a JSON object.']
             }, code='invalid')
 
         if request.data.get('records') == []: