0ct0pu5/crowdsec
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

grammar (#1257)

Browse source
This commit is contained in:
mmetc 2022-02-14 13:47:15 +01:00 • committed by GitHub
parent 76e3612088
commit ef4bf6a8ab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cmd/crowdsec-cli/decisions.go
View file

@ -192,7 +192,7 @@ cscli decisions list -t ban
if NoSimu != nil && *NoSimu {
filter.IncludeSimulated = new(bool)
}
/*nulify the empty entries to avoid bad filter*/
/* nullify the empty entries to avoid bad filter */
if *filter.Until == "" {
filter.Until = nil
} else {

11
cmd/crowdsec/crowdsec.go
View file

@ -231,15 +231,16 @@ func waitOnTomb() {
log.Warningf("Acquisition is finished, shutting down")
/*
While it might make sense to want to shut-down parser/buckets/etc. as soon as acquisition is finished,
we might have some pending buckets : buckets that overflowed, but which LeakRoutine are still alive because they
are waiting to be able to "commit" (push to api). This can happens specifically in a context where a lot of logs
we might have some pending buckets: buckets that overflowed, but whose LeakRoutine are still alive because they
are waiting to be able to "commit" (push to api). This can happen specifically in a context where a lot of logs
are going to trigger overflow (ie. trigger buckets with ~100% of the logs triggering an overflow).
To avoid this (which would mean that we would "lose" some overflows), let's monitor the number of live buckets.
However, because of the blackhole mechanism, you can't really wait for the number of LeakRoutine to go to zero (we might have to wait $blackhole_duration).
However, because of the blackhole mechanism, we can't really wait for the number of LeakRoutine to go to zero
(we might have to wait $blackhole_duration).
So : we are waiting for the number of buckets to stop decreasing before returning. "how long" we should wait is a bit of the trick question,
as some operations (ie. reverse dns or such in post-overflow) can take some time :)
So: we are waiting for the number of buckets to stop decreasing before returning. "how long" we should wait
is a bit of the trick question, as some operations (ie. reverse dns or such in post-overflow) can take some time :)
*/
return

2
cmd/crowdsec/main.go
View file

@ -192,7 +192,7 @@ func (f *Flags) Parse() {
flag.Parse()
}
// LoadConfig return configuration parsed from configuration file
// LoadConfig returns a configuration parsed from configuration file
func LoadConfig(cConfig *csconfig.Config) error {
if dumpFolder != "" {