Browse Source

fix check uid, gid values (#1309)

mmetc 3 years ago
parent
commit
e35efc5b2d
1 changed files with 2 additions and 2 deletions
  1. 2 2
      pkg/csplugin/broker.go

+ 2 - 2
pkg/csplugin/broker.go

@@ -425,14 +425,14 @@ func getProcessAtr(username string, groupname string) (*syscall.SysProcAttr, err
 	if err != nil {
 		return nil, err
 	}
-	if uid < 0 && uid > math.MaxInt32 {
+	if uid < 0 || uid > math.MaxInt32 {
 		return nil, fmt.Errorf("out of bound uid")
 	}
 	gid, err := strconv.ParseInt(g.Gid, 10, 32)
 	if err != nil {
 		return nil, err
 	}
-	if gid < 0 && gid > math.MaxInt32 {
+	if gid < 0 || gid > math.MaxInt32 {
 		return nil, fmt.Errorf("out of bound gid")
 	}
 	return &syscall.SysProcAttr{