瀏覽代碼

Break on success when alert already has decision (#997) (#999)

* Break on success when alert already has decision (#997)

Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
AlteredCoder 3 年之前
父節點
當前提交
0ccc69696b
共有 2 個文件被更改,包括 6 次插入7 次删除
  1. 3 7
      .github/workflows/ci_hubtest.yml
  2. 3 0
      pkg/apiserver/controllers/v1/alerts.go

+ 3 - 7
.github/workflows/ci_hubtest.yml

@@ -12,8 +12,6 @@ jobs:
   hubtest:
     name: Hub tests
     runs-on: ubuntu-latest
-    env:
-      PUSH_COVERAGE: ${{ github.ref == 'refs/heads/master' }}
     steps:
     - name: Set up Go 1.16
       uses: actions/setup-go@v1
@@ -54,7 +52,7 @@ jobs:
           echo "SCENARIO_BADGE_COLOR=$(if [ $SCENARIOS_COV_NUMBER -lt '70' ]; then echo 'red'; else echo 'green'; fi)" >> $GITHUB_ENV
     - name: Create Parsers badge
       uses: schneegans/dynamic-badges-action@v1.1.0
-      if: ${{ env.PUSH_COVERAGE }}
+      if: ${{ github.ref == 'refs/heads/master' }}
       with:
         auth: ${{ secrets.GIST_BADGES_SECRET }}
         gistID: ${{ secrets.GIST_BADGES_ID }}
@@ -64,13 +62,11 @@ jobs:
         color: ${{ env.SCENARIO_BADGE_COLOR }}
     - name: Create Scenarios badge
       uses: schneegans/dynamic-badges-action@v1.1.0
-      if: ${{ env.PUSH_COVERAGE }}
+      if: ${{ github.ref == 'refs/heads/master' }}
       with:
         auth: ${{ secrets.GIST_BADGES_SECRET }}
         gistID: ${{ secrets.GIST_BADGES_ID }}
         filename: crowdsec_scenarios_badge.json
         label: Hub Scenarios
         message: ${{ env.SCENARIOS_COV }}
-        color: ${{ env.SCENARIO_BADGE_COLOR }}
-
-
+        color: ${{ env.SCENARIO_BADGE_COLOR }}

+ 3 - 0
pkg/apiserver/controllers/v1/alerts.go

@@ -138,6 +138,9 @@ func (c *Controller) CreateAlert(gctx *gin.Context) {
 					continue
 				}
 				c.sendAlertToPluginChannel(alert, uint(pIdx))
+				if profile.OnSuccess == "break" {
+					break
+				}
 			}
 			continue
 		}