0ct0pu5/bulma
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Document how to try the changes (#1920)

Browse source 
* Document how to try the changes

Add to the contributing guide how to rebuild the css and where the
documentation to try the documentation changes is.

* Remove Bulma dependencies installation form PR template

Install Bulma dependencies is not needed to send a PR.

* Add how to try your changes to PR templates

And after that ask if you tried the changes.
This commit is contained in:
Ana María Martínez Gómez 2018-06-06 01:45:21 +02:00 • committed by Jeremy Thomas
parent 62d62be799
commit 13199b8f51
2 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
.github/CONTRIBUTING.md vendored
View file

@ -13,6 +13,17 @@ Thanks for helping out! 😇
* Limit the first line to 72 characters or fewer
* Reference issues and pull requests liberally
### Try your changes
When modifying any `.sass`, you will need to rebuild the css. You can do this by running:
```
npm install
npm run build
```
To see documentation changes check [the documentation readme](docs/README.md).
### Bulma Sass styleguide
* **No semi-colons** `;` or **curly braces** `{` `}`

11
.github/PULL_REQUEST_TEMPLATE.md vendored
View file

@ -16,13 +16,14 @@ This is a **new feature | improvement | bugfix | documentation fix**.
<!-- Think of performance, build time, usability, complexity, coupling…) -->
### Testing Done
<!-- How have you confirmed this feature works? -->
<!-- Please explain more than "Yes". -->
<!-- BEFORE SUBMITTING YOUR PR, MAKE SURE TO FOLLOW THESE STEPS: -->
<!-- 1. Pull the latest `master` branch -->
<!-- 2. Run `npm install` to install all Bulma dependencies -->
<!-- 3. Make sure your Sass code is compliant with the [Bulma Sass styleguide](https://github.com/jgthms/bulma/blob/master/.github/CONTRIBUTING.md#bulma-sass-styleguide) -->
<!-- 4. Make sure your PR only affects `.sass` or documentation files -->
<!-- 2. Make sure your Sass code is compliant with the [Bulma Sass styleguide](https://github.com/jgthms/bulma/blob/master/.github/CONTRIBUTING.md#bulma-sass-styleguide) -->
<!-- 3. Make sure your PR only affects `.sass` or documentation files -->
<!-- 4. [Try your changes](https://github.com/jgthms/bulma/blob/master/.github/CONTRIBUTING.md#try-your-changes). -->
<!-- How have you confirmed this feature works? -->
<!-- Please explain more than "Yes". -->
<!-- Thanks! -->