bromite/build/patches/build-remove-calling-untrusted-hooks.patch
Carl c8e8919714
Updated patches for v79 (#440)
* Updated patches for v79

Remaining issue:
* blank tabs when running on x86 emulators

Waiting on upstream to fix that.

The other upstream storage bug (https://bugs.chromium.org/p/chromium/issues/detail?id=1033655) is fixed in this version.
2019-12-19 23:55:40 +01:00

179 lines
5.9 KiB
Diff

From: Jan Engelhardt <jengelh@inai.de>
Date: Thu, 20 Apr 2017 16:25:49 +0200
Subject: build: remove calling untrusted hooks
Avoid downloading untrusted executables and wasting time with a
sysroot.
---
DEPS | 121 ++---------------------------------------------------------
1 file changed, 3 insertions(+), 118 deletions(-)
diff --git a/DEPS b/DEPS
--- a/DEPS
+++ b/DEPS
@@ -75,7 +75,7 @@ vars = {
# Check out and download nacl by default. This can be disabled e.g. with
# custom_vars.
- 'checkout_nacl': True,
+ 'checkout_nacl': False,
# By default, do not check out src-internal. This can be overridden e.g. with
# custom_vars.
@@ -99,8 +99,8 @@ vars = {
# support for other platforms may be added in the future.
'checkout_openxr' : 'checkout_win',
- 'checkout_traffic_annotation_tools': 'checkout_configuration != "small"',
- 'checkout_instrumented_libraries': 'checkout_linux and checkout_configuration != "small"',
+ 'checkout_traffic_annotation_tools': False,
+ 'checkout_instrumented_libraries': False,
# By default, do not check out WebKit for iOS, as it is not needed unless
# running against ToT WebKit rather than system WebKit. This can be overridden
@@ -3141,49 +3141,6 @@ hooks = [
'sync', '--extract',
],
},
- {
- 'name': 'sysroot_arm',
- 'pattern': '.',
- 'condition': 'checkout_linux and checkout_arm',
- 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
- '--arch=arm'],
- },
- {
- 'name': 'sysroot_arm64',
- 'pattern': '.',
- 'condition': 'checkout_linux and checkout_arm64',
- 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
- '--arch=arm64'],
- },
- {
- 'name': 'sysroot_x86',
- 'pattern': '.',
- 'condition': 'checkout_linux and (checkout_x86 or checkout_x64)',
- 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
- '--arch=x86'],
- },
- {
- 'name': 'sysroot_mips',
- 'pattern': '.',
- 'condition': 'checkout_linux and checkout_mips',
- 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
- '--arch=mips'],
- },
- {
- 'name': 'sysroot_mips64',
- 'pattern': '.',
- 'condition': 'checkout_linux and checkout_mips64',
- 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
- '--arch=mips64el'],
- },
-
- {
- 'name': 'sysroot_x64',
- 'pattern': '.',
- 'condition': 'checkout_linux and checkout_x64',
- 'action': ['python', 'src/build/linux/sysroot_scripts/install-sysroot.py',
- '--arch=x64'],
- },
{
# Case-insensitivity for the Win SDK. Must run before win_toolchain below.
'name': 'ciopfs_linux',
@@ -3211,43 +3168,6 @@ hooks = [
'condition': 'checkout_mac',
'action': ['python', 'src/build/mac_toolchain.py'],
},
- # Pull binutils for linux, enabled debug fission for faster linking /
- # debugging when used with clang on Ubuntu Precise.
- # https://code.google.com/p/chromium/issues/detail?id=352046
- {
- 'name': 'binutils',
- 'pattern': 'src/third_party/binutils',
- 'condition': 'host_os == "linux" and host_cpu != "mips64"',
- 'action': [
- 'python',
- 'src/third_party/binutils/download.py',
- ],
- },
- {
- # Update the prebuilt clang toolchain.
- # Note: On Win, this should run after win_toolchain, as it may use it.
- 'name': 'clang',
- 'pattern': '.',
- 'condition': 'not llvm_force_head_revision',
- 'action': ['python', 'src/tools/clang/scripts/update.py'],
- },
- {
- # Build the clang toolchain from tip-of-tree.
- # Note: On Win, this should run after win_toolchain, as it may use it.
- 'name': 'clang_tot',
- 'pattern': '.',
- 'condition': 'llvm_force_head_revision',
- 'action': ['python', 'src/tools/clang/scripts/build.py',
- '--llvm-force-head-revision',
- '--with-android={checkout_android}'],
- },
- {
- # This is supposed to support the same set of platforms as 'clang' above.
- 'name': 'clang_coverage',
- 'pattern': '.',
- 'condition': 'checkout_clang_coverage_tools',
- 'action': ['python', 'src/tools/code_coverage/update_clang_coverage_tools.py'],
- },
{
# Mac doesn't use lld so it's not included in the default clang bundle
# there. lld is however needed in win and Fuchsia cross builds, so
@@ -3307,18 +3227,6 @@ hooks = [
'-s', 'src/buildtools/mac/clang-format.sha1',
],
},
- {
- 'name': 'clang_format_linux',
- 'pattern': '.',
- 'condition': 'host_os == "linux"',
- 'action': [ 'python',
- 'src/third_party/depot_tools/download_from_google_storage.py',
- '--no_resume',
- '--no_auth',
- '--bucket', 'chromium-clang-format',
- '-s', 'src/buildtools/linux64/clang-format.sha1',
- ],
- },
# Pull rc binaries using checked-in hashes.
{
'name': 'rc_win',
@@ -3344,29 +3252,6 @@ hooks = [
'-s', 'src/build/toolchain/win/rc/mac/rc.sha1',
],
},
- {
- 'name': 'rc_linux',
- 'pattern': '.',
- 'condition': 'checkout_win and host_os == "linux"',
- 'action': [ 'python',
- 'src/third_party/depot_tools/download_from_google_storage.py',
- '--no_resume',
- '--no_auth',
- '--bucket', 'chromium-browser-clang/rc',
- '-s', 'src/build/toolchain/win/rc/linux64/rc.sha1',
- ]
- },
- {
- 'name': 'test_fonts',
- 'pattern': '.',
- 'action': [ 'download_from_google_storage',
- '--no_resume',
- '--extract',
- '--no_auth',
- '--bucket', 'chromium-fonts',
- '-s', 'src/third_party/test_fonts/test_fonts.tar.gz.sha1',
- ],
- },
# Pull order files for the win/clang build.
{
'name': 'orderfiles_win',
--
2.17.1