c8e8919714
* Updated patches for v79 Remaining issue: * blank tabs when running on x86 emulators Waiting on upstream to fix that. The other upstream storage bug (https://bugs.chromium.org/p/chromium/issues/detail?id=1033655) is fixed in this version.
71 lines
3 KiB
Diff
71 lines
3 KiB
Diff
From: csagan5 <32685696+csagan5@users.noreply.github.com>
|
|
Date: Mon, 2 Dec 2019 21:15:32 +0100
|
|
Subject: Revert "flags: remove disable-pull-to-refresh-effect"
|
|
|
|
This reverts commit 4e598f38a0e6dd3dbede009c6a99b2a520a94e1f.
|
|
---
|
|
chrome/browser/about_flags.cc | 4 ++++
|
|
chrome/browser/flag-metadata.json | 5 +++++
|
|
chrome/browser/flag_descriptions.cc | 4 ++++
|
|
chrome/browser/flag_descriptions.h | 3 +++
|
|
4 files changed, 16 insertions(+)
|
|
|
|
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
|
|
--- a/chrome/browser/about_flags.cc
|
|
+++ b/chrome/browser/about_flags.cc
|
|
@@ -1997,6 +1997,10 @@ const FeatureEntry kFeatureEntries[] = {
|
|
SINGLE_VALUE_TYPE(switches::kHostedAppQuitNotification)},
|
|
#endif // OS_MACOSX
|
|
#if defined(OS_ANDROID)
|
|
+ {"disable-pull-to-refresh-effect",
|
|
+ flag_descriptions::kPullToRefreshEffectName,
|
|
+ flag_descriptions::kPullToRefreshEffectDescription, kOsAndroid,
|
|
+ SINGLE_DISABLE_VALUE_TYPE(switches::kDisablePullToRefreshEffect)},
|
|
{"translate-force-trigger-on-english",
|
|
flag_descriptions::kTranslateForceTriggerOnEnglishName,
|
|
flag_descriptions::kTranslateForceTriggerOnEnglishDescription, kOsAndroid,
|
|
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
|
|
--- a/chrome/browser/flag-metadata.json
|
|
+++ b/chrome/browser/flag-metadata.json
|
|
@@ -712,6 +712,11 @@
|
|
"quickoffice-chrome-eng@google.com" ],
|
|
"expiry_milestone": 88
|
|
},
|
|
+ {
|
|
+ "name": "disable-pull-to-refresh-effect",
|
|
+ // "owners": [ "your-team" ],
|
|
+ "expiry_milestone": -1
|
|
+ },
|
|
{
|
|
// See https://crbug.com/882238.
|
|
"name": "disable-pushstate-throttle",
|
|
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
|
|
--- a/chrome/browser/flag_descriptions.cc
|
|
+++ b/chrome/browser/flag_descriptions.cc
|
|
@@ -2748,6 +2748,10 @@ extern const char kProcessSharingWithStrictSiteInstancesDescription[] =
|
|
"separated like strict site isolation, but process selection puts multiple "
|
|
"site instances in a single process.";
|
|
|
|
+const char kPullToRefreshEffectName[] = "The pull-to-refresh effect";
|
|
+const char kPullToRefreshEffectDescription[] =
|
|
+ "Page reloads triggered by vertically overscrolling content.";
|
|
+
|
|
const char kReaderModeHeuristicsName[] = "Reader Mode triggering";
|
|
const char kReaderModeHeuristicsDescription[] =
|
|
"Determines what pages the Reader Mode infobar is shown on.";
|
|
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
|
|
--- a/chrome/browser/flag_descriptions.h
|
|
+++ b/chrome/browser/flag_descriptions.h
|
|
@@ -1615,6 +1615,9 @@ extern const char kProcessSharingWithDefaultSiteInstancesDescription[];
|
|
extern const char kProcessSharingWithStrictSiteInstancesName[];
|
|
extern const char kProcessSharingWithStrictSiteInstancesDescription[];
|
|
|
|
+extern const char kPullToRefreshEffectName[];
|
|
+extern const char kPullToRefreshEffectDescription[];
|
|
+
|
|
extern const char kReaderModeHeuristicsName[];
|
|
extern const char kReaderModeHeuristicsDescription[];
|
|
extern const char kReaderModeHeuristicsMarkup[];
|
|
--
|
|
2.17.1
|
|
|