73 lines
3.2 KiB
Diff
73 lines
3.2 KiB
Diff
From: csagan5 <32685696+csagan5@users.noreply.github.com>
|
|
Date: Mon, 2 Dec 2019 21:15:32 +0100
|
|
Subject: Revert "flags: remove disable-pull-to-refresh-effect"
|
|
|
|
This reverts commit 4e598f38a0e6dd3dbede009c6a99b2a520a94e1f.
|
|
|
|
Original License: BSD-3-Clause - https://spdx.org/licenses/BSD-3-Clause.html
|
|
License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
|
---
|
|
chrome/browser/about_flags.cc | 4 ++++
|
|
chrome/browser/flag-metadata.json | 5 +++++
|
|
chrome/browser/flag_descriptions.cc | 4 ++++
|
|
chrome/browser/flag_descriptions.h | 3 +++
|
|
4 files changed, 16 insertions(+)
|
|
|
|
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
|
|
--- a/chrome/browser/about_flags.cc
|
|
+++ b/chrome/browser/about_flags.cc
|
|
@@ -4100,6 +4100,10 @@ const FeatureEntry kFeatureEntries[] = {
|
|
kOsWin | kOsLinux | kOsLacros | kOsAndroid,
|
|
FEATURE_VALUE_TYPE(features::kVulkan)},
|
|
#if BUILDFLAG(IS_ANDROID)
|
|
+ {switches::kDisablePullToRefreshEffect,
|
|
+ flag_descriptions::kDisablePullToRefreshEffectName,
|
|
+ flag_descriptions::kDisablePullToRefreshEffectDescription, kOsAndroid,
|
|
+ SINGLE_DISABLE_VALUE_TYPE(switches::kDisablePullToRefreshEffect)},
|
|
{"translate-force-trigger-on-english",
|
|
flag_descriptions::kTranslateForceTriggerOnEnglishName,
|
|
flag_descriptions::kTranslateForceTriggerOnEnglishDescription, kOsAndroid,
|
|
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
|
|
--- a/chrome/browser/flag-metadata.json
|
|
+++ b/chrome/browser/flag-metadata.json
|
|
@@ -1375,6 +1375,11 @@
|
|
"yangsharon@google.com", "alexmos@google.com", "creis@google.com" ],
|
|
"expiry_milestone": 110
|
|
},
|
|
+ {
|
|
+ "name": "disable-pull-to-refresh-effect",
|
|
+ // "owners": [ "your-team" ],
|
|
+ "expiry_milestone": -1
|
|
+ },
|
|
{
|
|
"name": "disable-quick-answers-v2-translation",
|
|
"owners": [ "croissant-eng" ],
|
|
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
|
|
--- a/chrome/browser/flag_descriptions.cc
|
|
+++ b/chrome/browser/flag_descriptions.cc
|
|
@@ -3759,6 +3759,10 @@ const char kReadLaterDescription[] =
|
|
"Allow users to save tabs for later. Enables a new button and menu for "
|
|
"accessing tabs saved for later.";
|
|
|
|
+const char kDisablePullToRefreshEffectName[] = "The pull-to-refresh effect";
|
|
+const char kDisablePullToRefreshEffectDescription[] =
|
|
+ "Page reloads triggered by vertically overscrolling content.";
|
|
+
|
|
const char kReaderModeHeuristicsName[] = "Reader Mode triggering";
|
|
const char kReaderModeHeuristicsDescription[] =
|
|
"Determines what pages the Reader Mode infobar is shown on.";
|
|
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
|
|
--- a/chrome/browser/flag_descriptions.h
|
|
+++ b/chrome/browser/flag_descriptions.h
|
|
@@ -2141,6 +2141,9 @@ extern const char kQueryTilesSegmentationDescription[];
|
|
extern const char kQueryTilesSwapTrendingName[];
|
|
extern const char kQueryTilesSwapTrendingDescription[];
|
|
|
|
+extern const char kDisablePullToRefreshEffectName[];
|
|
+extern const char kDisablePullToRefreshEffectDescription[];
|
|
+
|
|
extern const char kReaderModeHeuristicsName[];
|
|
extern const char kReaderModeHeuristicsDescription[];
|
|
extern const char kReaderModeHeuristicsMarkup[];
|
|
--
|
|
2.25.1
|