User-agent-customization.patch 61 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245
  1. From: uazo <uazo@users.noreply.github.com>
  2. Date: Mon, 26 Oct 2020 16:50:15 +0000
  3. Subject: User agent customization
  4. Add flag to always view the desktop site for all websites
  5. Add possibility to define a custom User agent for mobile and desktop mode.
  6. Add possibility to reactivate the metatag view for desktop mode, allowing users to choose
  7. to use the flag in the hamburger menu to navigate with a custom useragent leaving the standard navigation unchanged.
  8. ---
  9. base/base_switches.cc | 2 +
  10. base/base_switches.h | 2 +
  11. chrome/android/chrome_java_resources.gni | 2 +
  12. chrome/android/chrome_java_sources.gni | 1 +
  13. .../layout/custom_useragent_preferences.xml | 108 ++++++++++
  14. .../android/java/res/xml/main_preferences.xml | 5 +
  15. .../java/res/xml/useragent_preferences.xml | 31 +++
  16. .../chrome/browser/app/ChromeActivity.java | 21 +-
  17. .../init/ChromeBrowserInitializer.java | 3 +
  18. .../settings/PrivacyPreferencesManager.java | 35 ++++
  19. .../settings/UserAgentPreferences.java | 185 ++++++++++++++++++
  20. .../chromium/chrome/browser/tab/TabImpl.java | 83 +++++++-
  21. .../browser/android/content/content_utils.cc | 28 +++
  22. .../preferences/browser_prefs_android.cc | 7 +
  23. .../privacy_preferences_manager.cc | 113 +++++++++++
  24. chrome/browser/android/tab_android.cc | 5 +-
  25. chrome/browser/android/tab_android.h | 3 +-
  26. .../browser/chrome_content_browser_client.cc | 8 +
  27. .../preferences/ChromePreferenceKeys.java | 7 +-
  28. .../org/chromium/chrome/browser/tab/Tab.java | 2 +
  29. .../browser/tabmodel/TabWindowManager.java | 8 +
  30. .../tabmodel/TabWindowManagerImpl.java | 18 ++
  31. .../strings/android_chrome_strings.grd | 35 ++++
  32. chrome/common/pref_names.cc | 13 ++
  33. chrome/common/pref_names.h | 8 +
  34. .../widget/RadioButtonWithEditText.java | 11 ++
  35. .../navigation_controller_android.cc | 6 +-
  36. .../navigation_controller_android.h | 3 +-
  37. .../renderer_host/render_process_host_impl.cc | 1 +
  38. .../browser/web_contents/web_contents_impl.cc | 4 +-
  39. .../framehost/NavigationControllerImpl.java | 6 +-
  40. content/renderer/render_thread_impl.cc | 1 -
  41. 32 files changed, 751 insertions(+), 14 deletions(-)
  42. create mode 100644 chrome/android/java/res/layout/custom_useragent_preferences.xml
  43. create mode 100644 chrome/android/java/res/xml/useragent_preferences.xml
  44. create mode 100644 chrome/android/java/src/org/chromium/chrome/browser/settings/UserAgentPreferences.java
  45. diff --git a/base/base_switches.cc b/base/base_switches.cc
  46. --- a/base/base_switches.cc
  47. +++ b/base/base_switches.cc
  48. @@ -160,4 +160,6 @@ const char kForceFieldTrialParams[] = "force-fieldtrial-params";
  49. const char kEnableThreadInstructionCount[] = "enable-thread-instruction-count";
  50. #endif
  51. +const char kDesktopModeViewportMetaEnabled[] = "dm-viewport-meta-enabled";
  52. +
  53. } // namespace switches
  54. diff --git a/base/base_switches.h b/base/base_switches.h
  55. --- a/base/base_switches.h
  56. +++ b/base/base_switches.h
  57. @@ -59,6 +59,8 @@ extern const char kForceFieldTrialParams[];
  58. extern const char kEnableThreadInstructionCount[];
  59. #endif
  60. +extern const char kDesktopModeViewportMetaEnabled[];
  61. +
  62. } // namespace switches
  63. #endif // BASE_BASE_SWITCHES_H_
  64. diff --git a/chrome/android/chrome_java_resources.gni b/chrome/android/chrome_java_resources.gni
  65. --- a/chrome/android/chrome_java_resources.gni
  66. +++ b/chrome/android/chrome_java_resources.gni
  67. @@ -1071,4 +1071,6 @@ chrome_java_resources = [
  68. "java/res/xml/sync_and_services_preferences.xml",
  69. "java/res/xml/theme_preferences.xml",
  70. "java/res/xml/tracing_preferences.xml",
  71. + "java/res/xml/useragent_preferences.xml",
  72. + "java/res/layout/custom_useragent_preferences.xml",
  73. ]
  74. diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java_sources.gni
  75. --- a/chrome/android/chrome_java_sources.gni
  76. +++ b/chrome/android/chrome_java_sources.gni
  77. @@ -1290,6 +1290,7 @@ chrome_java_sources = [
  78. "java/src/org/chromium/chrome/browser/payments/ui/DimmingDialog.java",
  79. "java/src/org/chromium/chrome/browser/payments/ui/LineItem.java",
  80. "java/src/org/chromium/chrome/browser/payments/ui/PaymentAppComparator.java",
  81. + "java/src/org/chromium/chrome/browser/settings/UserAgentPreferences.java",
  82. "java/src/org/chromium/chrome/browser/payments/ui/PaymentInformation.java",
  83. "java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestBottomBar.java",
  84. "java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestHeader.java",
  85. diff --git a/chrome/android/java/res/layout/custom_useragent_preferences.xml b/chrome/android/java/res/layout/custom_useragent_preferences.xml
  86. new file mode 100644
  87. --- /dev/null
  88. +++ b/chrome/android/java/res/layout/custom_useragent_preferences.xml
  89. @@ -0,0 +1,108 @@
  90. +<?xml version="1.0" encoding="utf-8"?>
  91. +<!--
  92. + This file is part of Bromite.
  93. +
  94. + Bromite is free software: you can redistribute it and/or modify
  95. + it under the terms of the GNU General Public License as published by
  96. + the Free Software Foundation, either version 3 of the License, or
  97. + (at your option) any later version.
  98. +
  99. + Bromite is distributed in the hope that it will be useful,
  100. + but WITHOUT ANY WARRANTY; without even the implied warranty of
  101. + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  102. + GNU General Public License for more details.
  103. +
  104. + You should have received a copy of the GNU General Public License
  105. + along with Bromite. If not, see <https://www.gnu.org/licenses/>.
  106. +-->
  107. +
  108. +<!-- Layout used by the UserAgentPreferences. -->
  109. +
  110. +<ScrollView
  111. + xmlns:android="http://schemas.android.com/apk/res/android"
  112. + xmlns:app="http://schemas.android.com/apk/res-auto"
  113. + android:layout_weight="0"
  114. + android:gravity="top"
  115. + android:layout_width="match_parent"
  116. + android:layout_height="wrap_content">
  117. +
  118. + <LinearLayout
  119. + android:layout_width="match_parent"
  120. + android:layout_height="wrap_content"
  121. + android:focusable="false"
  122. + android:orientation="vertical"
  123. + android:divider="?android:dividerHorizontal">
  124. +
  125. + <TextView
  126. + android:layout_width="match_parent"
  127. + android:layout_height="wrap_content"
  128. + android:textAppearance="@style/TextAppearance.AccessibilityTextPreference"
  129. + android:background="@color/default_bg_color_secondary"
  130. + android:padding="16dp"
  131. + android:text="@string/custom_ua_text"/>
  132. +
  133. + <org.chromium.components.browser_ui.widget.RadioButtonWithDescriptionLayout
  134. + android:id="@+id/ua_radio_button_layout"
  135. + android:layout_width="match_parent"
  136. + android:layout_height="wrap_content">
  137. +
  138. + <org.chromium.components.browser_ui.widget.RadioButtonWithDescription
  139. + android:id="@+id/default_ua_switch"
  140. + android:layout_width="match_parent"
  141. + android:layout_height="wrap_content"
  142. + android:paddingStart="?android:attr/listPreferredItemPaddingStart"
  143. + app:primaryText="@string/custom_ua_flag_off" />
  144. +
  145. + <org.chromium.components.browser_ui.widget.RadioButtonWithEditText
  146. + android:id="@+id/custom_ua_switch"
  147. + android:layout_width="match_parent"
  148. + android:layout_height="wrap_content"
  149. + android:paddingStart="?android:attr/listPreferredItemPaddingStart"
  150. + android:inputType="text"
  151. + android:hint="@string/custom_ua_placeholder"
  152. + app:descriptionText="@string/custom_ua_flag_on" />
  153. +
  154. + </org.chromium.components.browser_ui.widget.RadioButtonWithDescriptionLayout>
  155. +
  156. + <TextView
  157. + android:layout_width="match_parent"
  158. + android:layout_height="wrap_content"
  159. + android:textAppearance="@style/TextAppearance.AccessibilityTextPreference"
  160. + android:background="@color/default_bg_color_secondary"
  161. + android:padding="16dp"
  162. + android:text="@string/custom_desktop_ua_text"/>
  163. +
  164. + <org.chromium.components.browser_ui.widget.RadioButtonWithDescriptionLayout
  165. + android:id="@+id/ua_radio_button_layout_dm"
  166. + android:layout_width="match_parent"
  167. + android:layout_height="wrap_content">
  168. +
  169. + <org.chromium.components.browser_ui.widget.RadioButtonWithDescription
  170. + android:id="@+id/default_ua_switch_dm"
  171. + android:layout_width="match_parent"
  172. + android:layout_height="wrap_content"
  173. + android:paddingStart="?android:attr/listPreferredItemPaddingStart"
  174. + app:primaryText="@string/custom_ua_flag_off" />
  175. +
  176. + <org.chromium.components.browser_ui.widget.RadioButtonWithEditText
  177. + android:id="@+id/custom_ua_switch_dm"
  178. + android:layout_width="match_parent"
  179. + android:layout_height="wrap_content"
  180. + android:paddingStart="?android:attr/listPreferredItemPaddingStart"
  181. + android:inputType="text"
  182. + android:hint="@string/custom_ua_placeholder"
  183. + app:descriptionText="@string/custom_ua_flag_on" />
  184. +
  185. + </org.chromium.components.browser_ui.widget.RadioButtonWithDescriptionLayout>
  186. +
  187. + <CheckBox
  188. + android:id="@+id/desktop_mode_viewportmeta"
  189. + android:layout_width="wrap_content"
  190. + android:layout_height="wrap_content"
  191. + android:layout_centerVertical="true"
  192. + android:layout_marginLeft="?android:attr/listPreferredItemPaddingStart"
  193. + android:text="@string/desktop_mode_viewportmeta_checkbox" />
  194. +
  195. + </LinearLayout>
  196. +
  197. +</ScrollView>
  198. diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/java/res/xml/main_preferences.xml
  199. --- a/chrome/android/java/res/xml/main_preferences.xml
  200. +++ b/chrome/android/java/res/xml/main_preferences.xml
  201. @@ -104,6 +104,11 @@
  202. android:key="content_settings"
  203. android:order="19"
  204. android:title="@string/prefs_site_settings"/>
  205. + <Preference
  206. + android:fragment="org.chromium.chrome.browser.settings.UserAgentPreferences"
  207. + android:key="useragent_settings"
  208. + android:order="20"
  209. + android:title="@string/prefs_useragent_settings"/>
  210. <Preference
  211. android:fragment="org.chromium.chrome.browser.language.settings.LanguageSettings"
  212. android:key="languages"
  213. diff --git a/chrome/android/java/res/xml/useragent_preferences.xml b/chrome/android/java/res/xml/useragent_preferences.xml
  214. new file mode 100644
  215. --- /dev/null
  216. +++ b/chrome/android/java/res/xml/useragent_preferences.xml
  217. @@ -0,0 +1,31 @@
  218. +<?xml version="1.0" encoding="utf-8"?>
  219. +<!--
  220. + This file is part of Bromite.
  221. +
  222. + Bromite is free software: you can redistribute it and/or modify
  223. + it under the terms of the GNU General Public License as published by
  224. + the Free Software Foundation, either version 3 of the License, or
  225. + (at your option) any later version.
  226. +
  227. + Bromite is distributed in the hope that it will be useful,
  228. + but WITHOUT ANY WARRANTY; without even the implied warranty of
  229. + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  230. + GNU General Public License for more details.
  231. +
  232. + You should have received a copy of the GNU General Public License
  233. + along with Bromite. If not, see <https://www.gnu.org/licenses/>.
  234. +-->
  235. +
  236. +<!-- Layout used by the UserAgentPreferences. -->
  237. +
  238. +<PreferenceScreen
  239. + xmlns:android="http://schemas.android.com/apk/res/android"
  240. + xmlns:app="http://schemas.android.com/apk/res-auto">
  241. +
  242. + <org.chromium.components.browser_ui.settings.ChromeSwitchPreference
  243. + android:key="desktop_mode_switch"
  244. + android:title="@string/option_desktop_flag"
  245. + android:summaryOn="@string/option_desktop_flag_on"
  246. + android:summaryOff="@string/option_desktop_flag_off" />
  247. +
  248. +</PreferenceScreen>
  249. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
  250. --- a/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
  251. +++ b/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
  252. @@ -69,6 +69,7 @@ import org.chromium.chrome.browser.app.appmenu.AppMenuPropertiesDelegateImpl;
  253. import org.chromium.chrome.browser.app.flags.ChromeCachedFlags;
  254. import org.chromium.chrome.browser.app.tab_activity_glue.ReparentingDelegateFactory;
  255. import org.chromium.chrome.browser.app.tabmodel.AsyncTabParamsManagerSingleton;
  256. +import org.chromium.chrome.browser.app.tabmodel.TabWindowManagerSingleton;
  257. import org.chromium.chrome.browser.bookmarks.BookmarkBridge;
  258. import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkItem;
  259. import org.chromium.chrome.browser.bookmarks.BookmarkModel;
  260. @@ -206,6 +207,13 @@ import org.chromium.ui.modaldialog.ModalDialogManager;
  261. import org.chromium.ui.widget.Toast;
  262. import org.chromium.url.Origin;
  263. import org.chromium.webapk.lib.client.WebApkNavigationClient;
  264. +import org.chromium.chrome.browser.tabmodel.TabWindowManager;
  265. +import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
  266. +import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
  267. +
  268. +import org.chromium.chrome.browser.tabmodel.TabWindowManager;
  269. +import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
  270. +import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
  271. import org.chromium.url.GURL;
  272. @@ -2074,11 +2082,18 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
  273. } else if (id == R.id.view_source_id) {
  274. currentTab.getWebContents().getNavigationController().loadUrl(new LoadUrlParams("view-source:"+currentTab.getUrlString()));
  275. } else if (id == R.id.request_desktop_site_id || id == R.id.request_desktop_site_check_id) {
  276. - final boolean reloadOnChange = !currentTab.isNativePage();
  277. final boolean usingDesktopUserAgent =
  278. currentTab.getWebContents().getNavigationController().getUseDesktopUserAgent();
  279. - currentTab.getWebContents().getNavigationController().setUseDesktopUserAgent(
  280. - !usingDesktopUserAgent, reloadOnChange);
  281. + SharedPreferencesManager.getInstance().writeBoolean(
  282. + ChromePreferenceKeys.USERAGENT_ALWAYS_DESKTOP_MODE, !usingDesktopUserAgent);
  283. +
  284. + final boolean stickyDesktopModeEnabled = SharedPreferencesManager.getInstance().readBoolean(
  285. + ChromePreferenceKeys.USERAGENT_STICKY_DESKTOP_MODE, false);
  286. + if (stickyDesktopModeEnabled) {
  287. + TabWindowManagerSingleton.getInstance().SetOverrideUserAgentForAllTabs(!usingDesktopUserAgent);
  288. + } else {
  289. + currentTab.SetOverrideUserAgent(!usingDesktopUserAgent);
  290. + }
  291. RecordUserAction.record("MobileMenuRequestDesktopSite");
  292. } else if (id == R.id.reader_mode_prefs_id) {
  293. DomDistillerUIUtils.openSettings(currentTab.getWebContents());
  294. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java b/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
  295. --- a/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
  296. +++ b/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
  297. @@ -48,6 +48,7 @@ import org.chromium.content_public.browser.SpeechRecognition;
  298. import org.chromium.content_public.browser.UiThreadTaskTraits;
  299. import org.chromium.net.NetworkChangeNotifier;
  300. import org.chromium.ui.resources.ResourceExtractor;
  301. +import org.chromium.chrome.browser.privacy.settings.PrivacyPreferencesManager;
  302. import java.io.File;
  303. import java.util.ArrayList;
  304. @@ -324,11 +325,13 @@ public class ChromeBrowserInitializer {
  305. @Override
  306. public void onSuccess() {
  307. + PrivacyPreferencesManager.getInstance().UpdateOverrideUserAgent();
  308. tasks.start(false);
  309. }
  310. });
  311. } else {
  312. startChromeBrowserProcessesSync();
  313. + PrivacyPreferencesManager.getInstance().UpdateOverrideUserAgent();
  314. tasks.start(true);
  315. }
  316. }
  317. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacyPreferencesManager.java b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacyPreferencesManager.java
  318. --- a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacyPreferencesManager.java
  319. +++ b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacyPreferencesManager.java
  320. @@ -315,6 +315,34 @@ public class PrivacyPreferencesManager implements CrashReportingPermissionManage
  321. return PrivacyPreferencesManagerJni.get().isMetricsReportingManaged();
  322. }
  323. + public void UpdateOverrideUserAgent() {
  324. + PrivacyPreferencesManagerJni.get().updateOverrideUserAgent();
  325. + }
  326. +
  327. + public boolean isOverrideUserAgentEnabled(boolean desktopMode) {
  328. + return PrivacyPreferencesManagerJni.get().isOverrideUserAgentEnabled(desktopMode);
  329. + }
  330. +
  331. + public void setOverrideUserAgentEnabled(boolean enabled, boolean desktopMode) {
  332. + PrivacyPreferencesManagerJni.get().setOverrideUserAgentEnabled(enabled, desktopMode);
  333. + }
  334. +
  335. + public String getOverrideUserAgentValue(boolean desktopMode) {
  336. + return PrivacyPreferencesManagerJni.get().getOverrideUserAgentValue(desktopMode);
  337. + }
  338. +
  339. + public void setOverrideUserAgentValue(String user_agent, boolean desktopMode) {
  340. + PrivacyPreferencesManagerJni.get().setOverrideUserAgentValue(user_agent, desktopMode);
  341. + }
  342. +
  343. + public boolean isDesktopModeViewportMetaEnabled() {
  344. + return PrivacyPreferencesManagerJni.get().isDesktopModeViewportMetaEnabled();
  345. + }
  346. +
  347. + public void setDesktopModeViewportMetaEnabled(boolean enabled) {
  348. + PrivacyPreferencesManagerJni.get().setDesktopModeViewportMetaEnabled(enabled);
  349. + }
  350. +
  351. @NativeMethods
  352. public interface Natives {
  353. boolean canPrefetchAndPrerender();
  354. @@ -325,5 +353,12 @@ public class PrivacyPreferencesManager implements CrashReportingPermissionManage
  355. boolean isMetricsReportingEnabled();
  356. void setMetricsReportingEnabled(boolean enabled);
  357. boolean isMetricsReportingManaged();
  358. + void updateOverrideUserAgent();
  359. + boolean isOverrideUserAgentEnabled(boolean desktopMode);
  360. + void setOverrideUserAgentEnabled(boolean enabled, boolean desktopMode);
  361. + String getOverrideUserAgentValue(boolean desktopMode);
  362. + void setOverrideUserAgentValue(String timezone, boolean desktopMode);
  363. + boolean isDesktopModeViewportMetaEnabled();
  364. + void setDesktopModeViewportMetaEnabled(boolean enabled);
  365. }
  366. }
  367. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/UserAgentPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/UserAgentPreferences.java
  368. new file mode 100644
  369. --- /dev/null
  370. +++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/UserAgentPreferences.java
  371. @@ -0,0 +1,185 @@
  372. +/*
  373. + This file is part of Bromite.
  374. +
  375. + Bromite is free software: you can redistribute it and/or modify
  376. + it under the terms of the GNU General Public License as published by
  377. + the Free Software Foundation, either version 3 of the License, or
  378. + (at your option) any later version.
  379. +
  380. + Bromite is distributed in the hope that it will be useful,
  381. + but WITHOUT ANY WARRANTY; without even the implied warranty of
  382. + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  383. + GNU General Public License for more details.
  384. +
  385. + You should have received a copy of the GNU General Public License
  386. + along with Bromite. If not, see <https://www.gnu.org/licenses/>.
  387. +*/
  388. +
  389. +package org.chromium.chrome.browser.settings;
  390. +
  391. +import android.os.Bundle;
  392. +import androidx.preference.Preference;
  393. +import androidx.preference.PreferenceFragmentCompat;
  394. +import androidx.preference.PreferenceViewHolder;
  395. +import androidx.annotation.NonNull;
  396. +import androidx.annotation.Nullable;
  397. +import android.view.LayoutInflater;
  398. +import android.widget.RadioGroup;
  399. +import android.content.Context;
  400. +import android.util.AttributeSet;
  401. +import android.view.View;
  402. +import android.view.ViewGroup;
  403. +import android.widget.LinearLayout;
  404. +import android.widget.ScrollView;
  405. +import android.widget.CheckBox;
  406. +import android.widget.CompoundButton;
  407. +import androidx.recyclerview.widget.RecyclerView;
  408. +
  409. +import org.chromium.components.browser_ui.settings.ChromeSwitchPreference;
  410. +import org.chromium.components.browser_ui.widget.RadioButtonWithDescription;
  411. +import org.chromium.components.browser_ui.widget.RadioButtonWithEditText;
  412. +import org.chromium.components.browser_ui.settings.SettingsUtils;
  413. +
  414. +import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
  415. +import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
  416. +
  417. +import org.chromium.chrome.browser.app.tabmodel.TabWindowManagerSingleton;
  418. +import org.chromium.chrome.browser.tabmodel.TabWindowManager;
  419. +import org.chromium.chrome.browser.privacy.settings.PrivacyPreferencesManager;
  420. +import org.chromium.chrome.R;
  421. +
  422. +/**
  423. + * Fragment that allows the user to configure User Agent related preferences.
  424. + */
  425. +public class UserAgentPreferences
  426. + extends PreferenceFragmentCompat implements RadioGroup.OnCheckedChangeListener {
  427. +
  428. + private static final String PREF_STICK_DESKTOP_MODE_SWITCH = "desktop_mode_switch";
  429. + private RadioButtonWithDescription useDefaultAgentSwitch;
  430. + private RadioButtonWithEditText useCustomAgentSwitch;
  431. + private RadioButtonWithDescription useDefaultAgentSwitchDesktopMode;
  432. + private RadioButtonWithEditText useCustomAgentSwitchDesktopMode;
  433. + private RadioGroup mRadioGroup;
  434. + private RadioGroup mRadioGroupDesktopMode;
  435. + private CheckBox mDesktopModeViewportmeta;
  436. +
  437. + @Override
  438. + public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
  439. + getActivity().setTitle(R.string.useragent_settings_title);
  440. + SettingsUtils.addPreferencesFromResource(this, R.xml.useragent_preferences);
  441. +
  442. + ChromeSwitchPreference alwaysDesktopModeSwitch =
  443. + (ChromeSwitchPreference) findPreference(PREF_STICK_DESKTOP_MODE_SWITCH);
  444. + boolean enabled = SharedPreferencesManager.getInstance().readBoolean(
  445. + ChromePreferenceKeys.USERAGENT_STICKY_DESKTOP_MODE, false);
  446. + alwaysDesktopModeSwitch.setChecked(enabled);
  447. + alwaysDesktopModeSwitch.setOnPreferenceChangeListener((preference, newValue) -> {
  448. + SharedPreferencesManager.getInstance().writeBoolean(
  449. + ChromePreferenceKeys.USERAGENT_STICKY_DESKTOP_MODE, (boolean) newValue);
  450. + UpdateAllTabs();
  451. + return true;
  452. + });
  453. + }
  454. +
  455. + @Override
  456. + public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container,
  457. + @Nullable Bundle savedInstanceState) {
  458. + LinearLayout viewGroup = (LinearLayout) super.onCreateView(inflater, container, savedInstanceState);
  459. + ScrollView view = (ScrollView) inflater.inflate(R.layout.custom_useragent_preferences, viewGroup, false);
  460. + viewGroup.addView(view);
  461. +
  462. + boolean enabledCustomUA = PrivacyPreferencesManager.getInstance().isOverrideUserAgentEnabled(false);
  463. + boolean enabledCustomUADesktopMode = PrivacyPreferencesManager.getInstance().isOverrideUserAgentEnabled(true);
  464. + boolean enabledDesktopModeViewportmeta = PrivacyPreferencesManager.getInstance().isDesktopModeViewportMetaEnabled();
  465. +
  466. + useDefaultAgentSwitch =
  467. + (RadioButtonWithDescription) view.findViewById(R.id.default_ua_switch);
  468. + useCustomAgentSwitch =
  469. + (RadioButtonWithEditText) view.findViewById(R.id.custom_ua_switch);
  470. + useDefaultAgentSwitchDesktopMode =
  471. + (RadioButtonWithDescription) view.findViewById(R.id.default_ua_switch_dm);
  472. + useCustomAgentSwitchDesktopMode =
  473. + (RadioButtonWithEditText) view.findViewById(R.id.custom_ua_switch_dm);
  474. +
  475. + mRadioGroup = (RadioGroup) view.findViewById(R.id.ua_radio_button_layout);
  476. + mRadioGroup.setOnCheckedChangeListener(this);
  477. +
  478. + mRadioGroupDesktopMode = (RadioGroup) view.findViewById(R.id.ua_radio_button_layout_dm);
  479. + mRadioGroupDesktopMode.setOnCheckedChangeListener(this);
  480. +
  481. + mDesktopModeViewportmeta = (CheckBox) view.findViewById(R.id.desktop_mode_viewportmeta);
  482. + mDesktopModeViewportmeta.setChecked(enabledDesktopModeViewportmeta);
  483. + mDesktopModeViewportmeta.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
  484. + @Override
  485. + public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
  486. + PrivacyPreferencesManager.getInstance().setDesktopModeViewportMetaEnabled(
  487. + mDesktopModeViewportmeta.isChecked());
  488. + }
  489. + });
  490. +
  491. + useDefaultAgentSwitch.setChecked(!enabledCustomUA);
  492. + useCustomAgentSwitch.setChecked(enabledCustomUA);
  493. +
  494. + useDefaultAgentSwitchDesktopMode.setChecked(!enabledCustomUADesktopMode);
  495. + useCustomAgentSwitchDesktopMode.setChecked(enabledCustomUADesktopMode);
  496. +
  497. + useCustomAgentSwitch.setPrimaryText(
  498. + PrivacyPreferencesManager.getInstance().getOverrideUserAgentValue(false));
  499. + useCustomAgentSwitch.addTextChangeListener(new RadioButtonWithEditText.OnTextChangeListener() {
  500. + @Override
  501. + public void onTextChanged(CharSequence newText) {
  502. + PrivacyPreferencesManager.getInstance().setOverrideUserAgentValue(
  503. + newText.toString(), false);
  504. + }
  505. + });
  506. + useCustomAgentSwitch.setFocusChangeListener( hasFocus -> {
  507. + if( hasFocus )
  508. + PrivacyPreferencesManager.getInstance().setOverrideUserAgentEnabled(true, false);
  509. + });
  510. +
  511. + useCustomAgentSwitchDesktopMode.setPrimaryText(
  512. + PrivacyPreferencesManager.getInstance().getOverrideUserAgentValue(true));
  513. + useCustomAgentSwitchDesktopMode.addTextChangeListener(new RadioButtonWithEditText.OnTextChangeListener() {
  514. + @Override
  515. + public void onTextChanged(CharSequence newText) {
  516. + PrivacyPreferencesManager.getInstance().setOverrideUserAgentValue(
  517. + newText.toString(), true);
  518. + }
  519. + });
  520. + useCustomAgentSwitchDesktopMode.setFocusChangeListener( hasFocus -> {
  521. + if( hasFocus )
  522. + PrivacyPreferencesManager.getInstance().setOverrideUserAgentEnabled(true, true);
  523. + });
  524. +
  525. + return viewGroup;
  526. + }
  527. +
  528. + private void UpdateAllTabs() {
  529. + final boolean alwaysDesktopModeEnabled = SharedPreferencesManager.getInstance().readBoolean(
  530. + ChromePreferenceKeys.USERAGENT_ALWAYS_DESKTOP_MODE, false);
  531. + TabWindowManagerSingleton.getInstance().SetOverrideUserAgentForAllTabs(alwaysDesktopModeEnabled);
  532. + }
  533. +
  534. + @Override
  535. + public void onCheckedChanged(RadioGroup group, int checkedId) {
  536. + if (useDefaultAgentSwitch.isChecked()) {
  537. + PrivacyPreferencesManager.getInstance().setOverrideUserAgentEnabled(false, false);
  538. + } else if (useCustomAgentSwitch.isChecked()) {
  539. + PrivacyPreferencesManager.getInstance().setOverrideUserAgentEnabled(true, false);
  540. + }
  541. +
  542. + if (useDefaultAgentSwitchDesktopMode.isChecked()) {
  543. + PrivacyPreferencesManager.getInstance().setOverrideUserAgentEnabled(false, true);
  544. + } else if (useCustomAgentSwitchDesktopMode.isChecked()) {
  545. + PrivacyPreferencesManager.getInstance().setOverrideUserAgentEnabled(true, true);
  546. + }
  547. +
  548. + UpdateAllTabs();
  549. + }
  550. +
  551. + @Override
  552. + public void onStop() {
  553. + super.onStop();
  554. + UpdateAllTabs();
  555. + }
  556. +}
  557. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabImpl.java
  558. --- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabImpl.java
  559. +++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabImpl.java
  560. @@ -57,6 +57,18 @@ import org.chromium.ui.base.WindowAndroid;
  561. import org.chromium.ui.util.ColorUtils;
  562. import org.chromium.url.GURL;
  563. import org.chromium.url.Origin;
  564. +import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
  565. +import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
  566. +import org.chromium.content_public.browser.navigation_controller.UserAgentOverrideOption;
  567. +import org.chromium.content_public.browser.NavigationController;
  568. +import org.chromium.components.embedder_support.util.UrlUtilities;
  569. +import org.chromium.components.url_formatter.UrlFormatter;
  570. +import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
  571. +import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
  572. +import org.chromium.content_public.browser.navigation_controller.UserAgentOverrideOption;
  573. +import org.chromium.content_public.browser.NavigationController;
  574. +import org.chromium.components.embedder_support.util.UrlUtilities;
  575. +import org.chromium.components.url_formatter.UrlFormatter;
  576. /**
  577. * Implementation of the interface {@link Tab}. Contains and manages a {@link ContentView}.
  578. @@ -454,6 +466,31 @@ public class TabImpl implements Tab, TabObscuringHandler.Observer {
  579. throw new RuntimeException("Tab.loadUrl called when no native side exists");
  580. }
  581. + final boolean stickyDesktopModeEnabled = SharedPreferencesManager.getInstance().readBoolean(
  582. + ChromePreferenceKeys.USERAGENT_STICKY_DESKTOP_MODE, false);
  583. + if (stickyDesktopModeEnabled) {
  584. + boolean alwaysDesktopModeEnabled = SharedPreferencesManager.getInstance().readBoolean(
  585. + ChromePreferenceKeys.USERAGENT_ALWAYS_DESKTOP_MODE, false);
  586. +
  587. + if (UrlUtilities.isInternalScheme(UrlFormatter.fixupUrl(params.getUrl()))) {
  588. + alwaysDesktopModeEnabled = false;
  589. + }
  590. +
  591. + WebContents webContents = this.getWebContents();
  592. + if (webContents != null) {
  593. + NavigationController navigationController = webContents.getNavigationController();
  594. + boolean currentUseDesktopUserAgent = navigationController.getUseDesktopUserAgent();
  595. + if (currentUseDesktopUserAgent != alwaysDesktopModeEnabled)
  596. + navigationController.setUseDesktopUserAgent(alwaysDesktopModeEnabled, false);
  597. + }
  598. +
  599. + if (alwaysDesktopModeEnabled) {
  600. + params.setOverrideUserAgent((int)UserAgentOverrideOption.TRUE);
  601. + } else {
  602. + params.setOverrideUserAgent((int)UserAgentOverrideOption.FALSE);
  603. + }
  604. + }
  605. +
  606. // We load the URL from the tab rather than directly from the ContentView so the tab has
  607. // a chance of using a prerenderer page is any.
  608. int loadType = TabImplJni.get().loadUrl(mNativeTabAndroid, TabImpl.this,
  609. @@ -466,7 +503,8 @@ public class TabImpl implements Tab, TabObscuringHandler.Observer {
  610. params.getReferrer() != null ? params.getReferrer().getPolicy() : 0,
  611. params.getIsRendererInitiated(), params.getShouldReplaceCurrentEntry(),
  612. params.getHasUserGesture(), params.getShouldClearHistoryList(),
  613. - params.getInputStartTimestamp(), params.getIntentReceivedTimestamp());
  614. + params.getInputStartTimestamp(), params.getIntentReceivedTimestamp(),
  615. + params.getUserAgentOverrideOption());
  616. for (TabObserver observer : mObservers) {
  617. observer.onLoadUrl(this, params, loadType);
  618. @@ -1433,6 +1471,10 @@ public class TabImpl implements Tab, TabObscuringHandler.Observer {
  619. if (mWebContents != null) mWebContents.getNavigationController().loadIfNecessary();
  620. mIsBeingRestored = true;
  621. for (TabObserver observer : mObservers) observer.onRestoreStarted(this);
  622. +
  623. + if(overrideUserAgentWhenUnFrozen != UserAgentOverrideOption.INHERIT) {
  624. + SetOverrideUserAgent(overrideUserAgentWhenUnFrozen == (int)UserAgentOverrideOption.TRUE ? true : false);
  625. + }
  626. } finally {
  627. TraceEvent.end("Tab.restoreIfNeeded");
  628. }
  629. @@ -1550,6 +1592,42 @@ public class TabImpl implements Tab, TabObscuringHandler.Observer {
  630. }
  631. }
  632. + int overrideUserAgentWhenUnFrozen = (int)UserAgentOverrideOption.INHERIT;
  633. +
  634. + public void SetOverrideUserAgent(boolean usingDesktopUserAgent) {
  635. + WebContents webContents = this.getWebContents();
  636. + overrideUserAgentWhenUnFrozen = UserAgentOverrideOption.INHERIT;
  637. +
  638. + if (usingDesktopUserAgent) {
  639. + GURL url = this.getUrl();
  640. + if (webContents == null && this.getPendingLoadParams() != null) {
  641. + url = UrlFormatter.fixupUrl(this.getPendingLoadParams().getUrl());
  642. + }
  643. + if (UrlUtilities.isInternalScheme(url) == true)
  644. + usingDesktopUserAgent = false;
  645. + }
  646. +
  647. + if (webContents != null) {
  648. + ContentUtils.setUserAgentOverride(webContents);
  649. +
  650. + NavigationController navigationController = webContents.getNavigationController();
  651. + navigationController.setUseDesktopUserAgent(
  652. + usingDesktopUserAgent, !this.isNativePage());
  653. + }
  654. + else if (this.getPendingLoadParams() != null) {
  655. + if (usingDesktopUserAgent) {
  656. + this.getPendingLoadParams().setOverrideUserAgent((int)UserAgentOverrideOption.TRUE);
  657. + }
  658. + else {
  659. + this.getPendingLoadParams().setOverrideUserAgent((int)UserAgentOverrideOption.FALSE);
  660. + }
  661. + }
  662. + else {
  663. + overrideUserAgentWhenUnFrozen = usingDesktopUserAgent ? UserAgentOverrideOption.TRUE :
  664. + UserAgentOverrideOption.FALSE;
  665. + }
  666. + }
  667. +
  668. @NativeMethods
  669. interface Natives {
  670. TabImpl fromWebContents(WebContents webContents);
  671. @@ -1571,7 +1649,8 @@ public class TabImpl implements Tab, TabObscuringHandler.Observer {
  672. String referrerUrl, int referrerPolicy, boolean isRendererInitiated,
  673. boolean shoulReplaceCurrentEntry, boolean hasUserGesture,
  674. boolean shouldClearHistoryList, long inputStartTimestamp,
  675. - long intentReceivedTimestamp);
  676. + long intentReceivedTimestamp,
  677. + int userAgentOverrideOption);
  678. void setActiveNavigationEntryTitleForUrl(
  679. long nativeTabAndroid, TabImpl caller, String url, String title);
  680. void loadOriginalImage(long nativeTabAndroid, TabImpl caller);
  681. diff --git a/chrome/browser/android/content/content_utils.cc b/chrome/browser/android/content/content_utils.cc
  682. --- a/chrome/browser/android/content/content_utils.cc
  683. +++ b/chrome/browser/android/content/content_utils.cc
  684. @@ -8,6 +8,20 @@
  685. #include "components/embedder_support/android/util/user_agent_utils.h"
  686. #include "components/version_info/version_info.h"
  687. +#include "base/android/jni_android.h"
  688. +#include "base/android/scoped_java_ref.h"
  689. +#include "chrome/browser/browser_process.h"
  690. +#include "components/prefs/pref_service.h"
  691. +#include "chrome/common/pref_names.h"
  692. +
  693. +using base::android::ConvertJavaStringToUTF8;
  694. +using base::android::ConvertUTF16ToJavaString;
  695. +using base::android::ConvertUTF8ToJavaString;
  696. +using base::android::JavaParamRef;
  697. +using base::android::JavaRef;
  698. +using base::android::ScopedJavaGlobalRef;
  699. +using base::android::ScopedJavaLocalRef;
  700. +
  701. static base::android::ScopedJavaLocalRef<jstring>
  702. JNI_ContentUtils_GetBrowserUserAgent(JNIEnv* env) {
  703. return base::android::ConvertUTF8ToJavaString(env, GetUserAgent());
  704. @@ -16,6 +30,20 @@ JNI_ContentUtils_GetBrowserUserAgent(JNIEnv* env) {
  705. static void JNI_ContentUtils_SetUserAgentOverride(
  706. JNIEnv* env,
  707. const base::android::JavaParamRef<jobject>& jweb_contents) {
  708. + bool enabled =
  709. + g_browser_process->local_state()->GetBoolean(prefs::kOverrideUserAgentDesktopModeEnabled);
  710. +
  711. + if (enabled == true) {
  712. + std::string ua = g_browser_process->local_state()->GetString(prefs::kOverrideUserAgentDesktopMode);
  713. + blink::UserAgentOverride spoofed_ua;
  714. + spoofed_ua.ua_string_override = ua;
  715. +
  716. + content::WebContents* web_contents =
  717. + content::WebContents::FromJavaWebContents(jweb_contents);
  718. + web_contents->SetUserAgentOverride(spoofed_ua, false);
  719. + return;
  720. + }
  721. +
  722. content::WebContents* web_contents =
  723. content::WebContents::FromJavaWebContents(jweb_contents);
  724. embedder_support::SetDesktopUserAgentOverride(web_contents,
  725. diff --git a/chrome/browser/android/preferences/browser_prefs_android.cc b/chrome/browser/android/preferences/browser_prefs_android.cc
  726. --- a/chrome/browser/android/preferences/browser_prefs_android.cc
  727. +++ b/chrome/browser/android/preferences/browser_prefs_android.cc
  728. @@ -10,11 +10,18 @@
  729. #include "chrome/browser/notifications/notification_platform_bridge_android.h"
  730. #include "components/pref_registry/pref_registry_syncable.h"
  731. #include "components/prefs/pref_registry_simple.h"
  732. +#include "chrome/common/pref_names.h"
  733. namespace android {
  734. void RegisterPrefs(PrefRegistrySimple* registry) {
  735. RegisterClipboardAndroidPrefs(registry);
  736. +
  737. + registry->RegisterBooleanPref(prefs::kOverrideUserAgentEnabled, false);
  738. + registry->RegisterStringPref(prefs::kOverrideUserAgent, "");
  739. + registry->RegisterBooleanPref(prefs::kOverrideUserAgentDesktopModeEnabled, false);
  740. + registry->RegisterStringPref(prefs::kOverrideUserAgentDesktopMode, "");
  741. + registry->RegisterBooleanPref(prefs::kDesktopModeViewportMetaEnabled, false);
  742. }
  743. void RegisterUserProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
  744. diff --git a/chrome/browser/android/preferences/privacy_preferences_manager.cc b/chrome/browser/android/preferences/privacy_preferences_manager.cc
  745. --- a/chrome/browser/android/preferences/privacy_preferences_manager.cc
  746. +++ b/chrome/browser/android/preferences/privacy_preferences_manager.cc
  747. @@ -11,6 +11,25 @@
  748. #include "chrome/common/pref_names.h"
  749. #include "components/metrics/metrics_pref_names.h"
  750. #include "components/prefs/pref_service.h"
  751. +#include "base/command_line.h"
  752. +#include "base/base_switches.h"
  753. +#include "chrome/common/chrome_switches.h"
  754. +#include "content/browser/renderer_host/render_process_host_impl.h"
  755. +#include "content/common/renderer.mojom.h"
  756. +#include "chrome/browser/chrome_content_browser_client.h"
  757. +
  758. +#include "base/android/jni_android.h"
  759. +#include "base/android/jni_array.h"
  760. +#include "base/android/jni_string.h"
  761. +#include "base/android/scoped_java_ref.h"
  762. +
  763. +using base::android::ConvertJavaStringToUTF8;
  764. +using base::android::ConvertUTF16ToJavaString;
  765. +using base::android::ConvertUTF8ToJavaString;
  766. +using base::android::JavaParamRef;
  767. +using base::android::JavaRef;
  768. +using base::android::ScopedJavaGlobalRef;
  769. +using base::android::ScopedJavaLocalRef;
  770. namespace {
  771. @@ -74,3 +93,97 @@ JNI_PrivacyPreferencesManager_ObsoleteNetworkPredictionOptionsHasUserSetting(
  772. return GetPrefService()->GetUserPrefValue(prefs::kNetworkPredictionOptions) !=
  773. nullptr;
  774. }
  775. +
  776. +static void UpdateOverrideUserAgent() {
  777. + bool overrideUserAgentEnabled =
  778. + g_browser_process->local_state()->GetBoolean(prefs::kOverrideUserAgentEnabled);
  779. + std::string ua = g_browser_process->local_state()->GetString(prefs::kOverrideUserAgent);
  780. + if (ua.empty()) {
  781. + ua = ChromeContentBrowserClient().GetUserAgent();
  782. + }
  783. +
  784. + base::CommandLine* parsed_command_line =
  785. + base::CommandLine::ForCurrentProcess();
  786. + parsed_command_line->RemoveSwitch(switches::kUserAgent);
  787. + if (!ua.empty()) {
  788. + if (overrideUserAgentEnabled) {
  789. + parsed_command_line->AppendSwitchASCII(switches::kUserAgent, ua);
  790. + }
  791. +
  792. + for (auto iter = content::RenderProcessHost::AllHostsIterator(); !iter.IsAtEnd();
  793. + iter.Advance()) {
  794. + if (iter.GetCurrentValue()->IsInitializedAndNotDead()) {
  795. + iter.GetCurrentValue()->GetRendererInterface()->SetUserAgent(ua);
  796. + }
  797. + }
  798. + }
  799. +
  800. + parsed_command_line->RemoveSwitch(switches::kDesktopModeViewportMetaEnabled);
  801. + if (g_browser_process->local_state()->GetBoolean(prefs::kDesktopModeViewportMetaEnabled))
  802. + parsed_command_line->AppendSwitch(switches::kDesktopModeViewportMetaEnabled);
  803. +}
  804. +
  805. +static void JNI_PrivacyPreferencesManager_UpdateOverrideUserAgent(
  806. + JNIEnv* env) {
  807. + UpdateOverrideUserAgent();
  808. +}
  809. +
  810. +static jboolean JNI_PrivacyPreferencesManager_IsOverrideUserAgentEnabled(
  811. + JNIEnv* env, jboolean desktopMode) {
  812. + if (desktopMode == false)
  813. + return g_browser_process->local_state()->GetBoolean(prefs::kOverrideUserAgentEnabled);
  814. + else
  815. + return g_browser_process->local_state()->GetBoolean(prefs::kOverrideUserAgentDesktopModeEnabled);
  816. +}
  817. +
  818. +static void JNI_PrivacyPreferencesManager_SetOverrideUserAgentEnabled(
  819. + JNIEnv* env,
  820. + jboolean enabled, jboolean desktopMode) {
  821. + if (desktopMode == false) {
  822. + g_browser_process->local_state()->SetBoolean(prefs::kOverrideUserAgentEnabled,
  823. + enabled);
  824. + UpdateOverrideUserAgent();
  825. + } else {
  826. + g_browser_process->local_state()->SetBoolean(prefs::kOverrideUserAgentDesktopModeEnabled,
  827. + enabled);
  828. + }
  829. +}
  830. +
  831. +static void JNI_PrivacyPreferencesManager_SetOverrideUserAgentValue(
  832. + JNIEnv* env,
  833. + const JavaParamRef<jstring>& ua, jboolean desktopMode) {
  834. + std::string new_ua = ConvertJavaStringToUTF8(env, ua);
  835. + if (desktopMode == false) {
  836. + g_browser_process->local_state()->SetString(prefs::kOverrideUserAgent,
  837. + new_ua);
  838. + UpdateOverrideUserAgent();
  839. + } else {
  840. + g_browser_process->local_state()->SetString(prefs::kOverrideUserAgentDesktopMode,
  841. + new_ua);
  842. + }
  843. +}
  844. +
  845. +static base::android::ScopedJavaLocalRef<jstring>
  846. + JNI_PrivacyPreferencesManager_GetOverrideUserAgentValue(
  847. + JNIEnv* env, jboolean desktopMode) {
  848. + if (desktopMode == false) {
  849. + std::string ua = g_browser_process->local_state()->GetString(prefs::kOverrideUserAgent);
  850. + return ConvertUTF8ToJavaString(env, ua);
  851. + } else {
  852. + std::string ua = g_browser_process->local_state()->GetString(prefs::kOverrideUserAgentDesktopMode);
  853. + return ConvertUTF8ToJavaString(env, ua);
  854. + }
  855. +}
  856. +
  857. +static jboolean JNI_PrivacyPreferencesManager_IsDesktopModeViewportMetaEnabled(
  858. + JNIEnv* env) {
  859. + return g_browser_process->local_state()->GetBoolean(prefs::kDesktopModeViewportMetaEnabled);
  860. +}
  861. +
  862. +static void JNI_PrivacyPreferencesManager_SetDesktopModeViewportMetaEnabled(
  863. + JNIEnv* env,
  864. + jboolean enabled) {
  865. + g_browser_process->local_state()->SetBoolean(prefs::kDesktopModeViewportMetaEnabled,
  866. + enabled);
  867. + UpdateOverrideUserAgent();
  868. +}
  869. diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc
  870. --- a/chrome/browser/android/tab_android.cc
  871. +++ b/chrome/browser/android/tab_android.cc
  872. @@ -379,7 +379,8 @@ TabAndroid::TabLoadStatus TabAndroid::LoadUrl(
  873. jboolean has_user_gesture,
  874. jboolean should_clear_history_list,
  875. jlong input_start_timestamp,
  876. - jlong intent_received_timestamp) {
  877. + jlong intent_received_timestamp,
  878. + jint user_agent_override_option) {
  879. if (!web_contents())
  880. return PAGE_LOAD_FAILED;
  881. @@ -436,6 +437,8 @@ TabAndroid::TabLoadStatus TabAndroid::LoadUrl(
  882. load_params.input_start =
  883. base::TimeTicks::FromUptimeMillis(intent_received_timestamp);
  884. }
  885. + load_params.override_user_agent = static_cast<NavigationController::UserAgentOverrideOption>(
  886. + user_agent_override_option);
  887. web_contents()->GetController().LoadURLWithParams(load_params);
  888. }
  889. return DEFAULT_PAGE_LOAD;
  890. diff --git a/chrome/browser/android/tab_android.h b/chrome/browser/android/tab_android.h
  891. --- a/chrome/browser/android/tab_android.h
  892. +++ b/chrome/browser/android/tab_android.h
  893. @@ -173,7 +173,8 @@ class TabAndroid : public base::SupportsUserData {
  894. jboolean has_user_gesture,
  895. jboolean should_clear_history_list,
  896. jlong omnibox_input_received_timestamp,
  897. - jlong intent_received_timestamp);
  898. + jlong intent_received_timestamp,
  899. + jint user_agent_override_option);
  900. void SetActiveNavigationEntryTitleForUrl(
  901. JNIEnv* env,
  902. const base::android::JavaParamRef<jobject>& obj,
  903. diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
  904. --- a/chrome/browser/chrome_content_browser_client.cc
  905. +++ b/chrome/browser/chrome_content_browser_client.cc
  906. @@ -1262,6 +1262,13 @@ std::string GetUserAgent() {
  907. blink::UserAgentMetadata GetUserAgentMetadata() {
  908. blink::UserAgentMetadata metadata;
  909. + base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
  910. + if (command_line->HasSwitch(switches::kUserAgent)) {
  911. + std::string ua = command_line->GetSwitchValueASCII(switches::kUserAgent);
  912. +
  913. + return metadata;
  914. + }
  915. +
  916. metadata.brand_version_list = GetBrandVersionList();
  917. metadata.full_version = version_info::GetVersionNumber();
  918. metadata.platform = version_info::GetOSType();
  919. @@ -2345,6 +2352,7 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
  920. switches::kDisableTargetBlankImpliesNoOpener);
  921. }
  922. +
  923. #if defined(OS_ANDROID)
  924. // Communicating to content/ for BackForwardCache.
  925. if (prefs->HasPrefPath(policy::policy_prefs::kBackForwardCacheEnabled) &&
  926. diff --git a/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java b/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
  927. --- a/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
  928. +++ b/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
  929. @@ -800,6 +800,9 @@ public final class ChromePreferenceKeys {
  930. public static final KeyPrefix KEY_ZERO_SUGGEST_HEADER_GROUP_COLLAPSED_BY_DEFAULT_PREFIX =
  931. new KeyPrefix("zero_suggest_header_group_collapsed_by_default*");
  932. + public static final String USERAGENT_STICKY_DESKTOP_MODE = "Chrome.UserAgent.StickyDesktopMode";
  933. + public static final String USERAGENT_ALWAYS_DESKTOP_MODE = "Chrome.UserAgent.AlwaysDesktopMode";
  934. +
  935. /**
  936. * These values are currently used as SharedPreferences keys, along with the keys in
  937. * {@link GrandfatheredChromePreferenceKeys#getKeysInUse()}. Add new SharedPreferences keys
  938. @@ -854,7 +857,9 @@ public final class ChromePreferenceKeys {
  939. SETTINGS_SAFETY_CHECK_RUN_COUNTER,
  940. SIGNIN_PROMO_IMPRESSIONS_COUNT_NTP,
  941. TWA_DISCLOSURE_SEEN_PACKAGES,
  942. - VIDEO_TUTORIALS_SHARE_URL_SET
  943. + VIDEO_TUTORIALS_SHARE_URL_SET,
  944. + USERAGENT_STICKY_DESKTOP_MODE,
  945. + USERAGENT_ALWAYS_DESKTOP_MODE
  946. );
  947. // clang-format on
  948. }
  949. diff --git a/chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/Tab.java
  950. --- a/chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/Tab.java
  951. +++ b/chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/Tab.java
  952. @@ -266,6 +266,8 @@ public interface Tab extends TabLifecycle {
  953. */
  954. void setIsTabStateDirty(boolean isTabStateDirty);
  955. + void SetOverrideUserAgent(boolean usingDesktopUserAgent);
  956. +
  957. /**
  958. * If set to true, any future navigations in the tab automatically get
  959. * PageTransition.FROM_API_2 applied.
  960. diff --git a/chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManager.java b/chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManager.java
  961. --- a/chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManager.java
  962. +++ b/chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManager.java
  963. @@ -10,6 +10,11 @@ import org.chromium.chrome.browser.tab.Tab;
  964. import org.chromium.chrome.browser.tabmodel.NextTabPolicy.NextTabPolicySupplier;
  965. import org.chromium.ui.base.WindowAndroid;
  966. +import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
  967. +import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
  968. +
  969. +import java.util.List;
  970. +
  971. /**
  972. * Manages multiple {@link TabModelSelector} instances, each owned by different {@link Activity}s.
  973. *
  974. @@ -76,4 +81,7 @@ public interface TabWindowManager {
  975. * @return Specified {@link Tab} or {@code null} if the {@link Tab} is not found.
  976. */
  977. Tab getTabById(int tabId);
  978. +
  979. + void SetOverrideUserAgentForAllTabs(boolean usingDesktopUserAgent);
  980. +
  981. }
  982. diff --git a/chrome/browser/tabmodel/internal/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManagerImpl.java b/chrome/browser/tabmodel/internal/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManagerImpl.java
  983. --- a/chrome/browser/tabmodel/internal/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManagerImpl.java
  984. +++ b/chrome/browser/tabmodel/internal/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManagerImpl.java
  985. @@ -119,6 +119,24 @@ public class TabWindowManagerImpl implements ActivityStateListener, TabWindowMan
  986. return null;
  987. }
  988. + @Override
  989. + public void SetOverrideUserAgentForAllTabs(boolean usingDesktopUserAgent) {
  990. + for (int selectorIndex = 0; selectorIndex < mSelectors.size(); selectorIndex++) {
  991. + TabModelSelector selector = mSelectors.get(selectorIndex);
  992. + if (selector != null) {
  993. + List<TabModel> models = selector.getModels();
  994. + for (int modelIndex = 0; modelIndex < models.size(); modelIndex++) {
  995. + TabModel model = models.get(modelIndex);
  996. +
  997. + for (int tabIdex = 0; tabIdex < model.getCount(); tabIdex++) {
  998. + Tab theTab = model.getTabAt(tabIdex);
  999. + theTab.SetOverrideUserAgent(usingDesktopUserAgent);
  1000. + }
  1001. + }
  1002. + }
  1003. + }
  1004. + }
  1005. +
  1006. @Override
  1007. public Tab getTabById(int tabId) {
  1008. for (int i = 0; i < mSelectors.size(); i++) {
  1009. diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
  1010. --- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
  1011. +++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
  1012. @@ -228,6 +228,41 @@ CHAR-LIMIT guidelines:
  1013. Visit help page
  1014. </message>
  1015. + <!-- User Agent settings -->
  1016. + <message name="IDS_PREFS_USERAGENT_SETTINGS" desc="Title of the User Agent preference. [CHAR-LIMIT=32]">
  1017. + User Agent
  1018. + </message>
  1019. + <message name="IDS_USERAGENT_SETTINGS_TITLE" desc="Title of the User Agent screen. [CHAR-LIMIT=32]">
  1020. + Customize User Agent
  1021. + </message>
  1022. + <message name="IDS_OPTION_DESKTOP_FLAG" desc="The label of the option that allows users to sticky desktop mode view flag under hambuger menu.">
  1023. + Current behaviour for desktop mode toggle in hamburger menu
  1024. + </message>
  1025. + <message name="IDS_OPTION_DESKTOP_FLAG_ON" desc="The label of the option that allows users to sticky desktop mode view flag under hambuger menu. [CHAR-LIMIT=32]">
  1026. + Applies to all tabs (sticky mode)
  1027. + </message>
  1028. + <message name="IDS_OPTION_DESKTOP_FLAG_OFF" desc="The label of the option that revert the hambuger menu flag to actual behaviour. [CHAR-LIMIT=32]">
  1029. + Applies to current tab only
  1030. + </message>
  1031. + <message name="IDS_CUSTOM_UA_FLAG_ON" desc="The label of the option that allows users to define custom user agent.">
  1032. + Use custom user agent
  1033. + </message>
  1034. + <message name="IDS_CUSTOM_UA_FLAG_OFF" desc="The label of the option that revert the user agent to actual value.">
  1035. + Use standard user agent
  1036. + </message>
  1037. + <message name="IDS_CUSTOM_UA_PLACEHOLDER" desc="The label of the placeholder for user agent textbox.">
  1038. + Insert a valid user agent
  1039. + </message>
  1040. + <message name="IDS_CUSTOM_UA_TEXT" desc="The label of the placeholder for user agent textbox.">
  1041. + Mobile User Agent
  1042. + </message>
  1043. + <message name="IDS_CUSTOM_DESKTOP_UA_TEXT" desc="The label of the placeholder for user agent textbox.">
  1044. + Desktop Mode User Agent
  1045. + </message>
  1046. + <message name="IDS_DESKTOP_MODE_VIEWPORTMETA_CHECKBOX" desc="The label of the enable viewport meta checkbox for user desktop mode.">
  1047. + Enable processing of the viewport meta tag also for desktop mode
  1048. + </message>
  1049. +
  1050. <!-- Notification channels -->
  1051. <message name="IDS_NOTIFICATION_CATEGORY_GROUP_GENERAL" desc='Subheading for "General" section of a list of notification categories. [CHAR-LIMIT=32]'>
  1052. General
  1053. diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc
  1054. --- a/chrome/common/pref_names.cc
  1055. +++ b/chrome/common/pref_names.cc
  1056. @@ -3124,4 +3124,17 @@ const char kIncognitoTabHistoryEnabled[] =
  1057. "incognito_tab_history_enabled";
  1058. #endif
  1059. +#if defined(OS_ANDROID)
  1060. +const char kOverrideUserAgentEnabled[] =
  1061. + "override_user_agent_enabled";
  1062. +const char kOverrideUserAgent[] =
  1063. + "override_user_agent";
  1064. +const char kOverrideUserAgentDesktopModeEnabled[] =
  1065. + "override_user_agent_dm_enabled";
  1066. +const char kOverrideUserAgentDesktopMode[] =
  1067. + "override_user_agent_dm";
  1068. +const char kDesktopModeViewportMetaEnabled[] =
  1069. + "dm-viewport-meta-enabled";
  1070. +#endif
  1071. +
  1072. } // namespace prefs
  1073. diff --git a/chrome/common/pref_names.h b/chrome/common/pref_names.h
  1074. --- a/chrome/common/pref_names.h
  1075. +++ b/chrome/common/pref_names.h
  1076. @@ -1097,6 +1097,14 @@ extern const char kSecurityTokenSessionNotificationSeconds[];
  1077. extern const char kIncognitoTabHistoryEnabled[];
  1078. #endif
  1079. +#if defined(OS_ANDROID)
  1080. +extern const char kOverrideUserAgentEnabled[];
  1081. +extern const char kOverrideUserAgent[];
  1082. +extern const char kOverrideUserAgentDesktopModeEnabled[];
  1083. +extern const char kOverrideUserAgentDesktopMode[];
  1084. +extern const char kDesktopModeViewportMetaEnabled[];
  1085. +#endif
  1086. +
  1087. } // namespace prefs
  1088. #endif // CHROME_COMMON_PREF_NAMES_H_
  1089. diff --git a/components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/RadioButtonWithEditText.java b/components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/RadioButtonWithEditText.java
  1090. --- a/components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/RadioButtonWithEditText.java
  1091. +++ b/components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/RadioButtonWithEditText.java
  1092. @@ -167,6 +167,17 @@ public class RadioButtonWithEditText extends RadioButtonWithDescription {
  1093. mEditText.setCursorVisible(false);
  1094. KeyboardVisibilityDelegate.getInstance().hideKeyboard(mEditText);
  1095. }
  1096. + if (mRadioButtonWithEditTextFocusListener != null) {
  1097. + mRadioButtonWithEditTextFocusListener.onRadioButtonWithEditTextFocusChanged(hasFocus);
  1098. + }
  1099. + }
  1100. +
  1101. + public interface RadioButtonWithEditTextFocusListener {
  1102. + void onRadioButtonWithEditTextFocusChanged(boolean hasFocus);
  1103. + }
  1104. + private RadioButtonWithEditTextFocusListener mRadioButtonWithEditTextFocusListener;
  1105. + public void setFocusChangeListener(RadioButtonWithEditTextFocusListener listener) {
  1106. + mRadioButtonWithEditTextFocusListener = listener;
  1107. }
  1108. /**
  1109. diff --git a/content/browser/renderer_host/navigation_controller_android.cc b/content/browser/renderer_host/navigation_controller_android.cc
  1110. --- a/content/browser/renderer_host/navigation_controller_android.cc
  1111. +++ b/content/browser/renderer_host/navigation_controller_android.cc
  1112. @@ -237,7 +237,8 @@ void NavigationControllerAndroid::LoadUrl(
  1113. const JavaParamRef<jstring>& data_url_as_string,
  1114. jboolean can_load_local_resources,
  1115. jboolean is_renderer_initiated,
  1116. - jboolean should_replace_current_entry) {
  1117. + jboolean should_replace_current_entry,
  1118. + jint user_agent_override_option) {
  1119. DCHECK(url);
  1120. NavigationController::LoadURLParams params(
  1121. GURL(ConvertJavaStringToUTF8(env, url)));
  1122. @@ -291,6 +292,9 @@ void NavigationControllerAndroid::LoadUrl(
  1123. Referrer::ConvertToPolicy(referrer_policy));
  1124. }
  1125. + params.override_user_agent = static_cast<NavigationController::UserAgentOverrideOption>(
  1126. + user_agent_override_option);
  1127. +
  1128. navigation_controller_->LoadURLWithParams(params);
  1129. }
  1130. diff --git a/content/browser/renderer_host/navigation_controller_android.h b/content/browser/renderer_host/navigation_controller_android.h
  1131. --- a/content/browser/renderer_host/navigation_controller_android.h
  1132. +++ b/content/browser/renderer_host/navigation_controller_android.h
  1133. @@ -80,7 +80,8 @@ class CONTENT_EXPORT NavigationControllerAndroid {
  1134. const base::android::JavaParamRef<jstring>& data_url_as_string,
  1135. jboolean can_load_local_resources,
  1136. jboolean is_renderer_initiated,
  1137. - jboolean should_replace_current_entry);
  1138. + jboolean should_replace_current_entry,
  1139. + jint user_agent_override_option);
  1140. void ClearSslPreferences(
  1141. JNIEnv* env,
  1142. const base::android::JavaParamRef<jobject>& /* obj */);
  1143. diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
  1144. --- a/content/browser/renderer_host/render_process_host_impl.cc
  1145. +++ b/content/browser/renderer_host/render_process_host_impl.cc
  1146. @@ -3456,6 +3456,7 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(
  1147. switches::kIpcDumpDirectory,
  1148. switches::kIpcFuzzerTestcase,
  1149. #endif
  1150. + switches::kDesktopModeViewportMetaEnabled,
  1151. };
  1152. renderer_cmd->CopySwitchesFrom(browser_cmd, kSwitchNames,
  1153. base::size(kSwitchNames));
  1154. diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
  1155. --- a/content/browser/web_contents/web_contents_impl.cc
  1156. +++ b/content/browser/web_contents/web_contents_impl.cc
  1157. @@ -38,6 +38,7 @@
  1158. #include "base/strings/string_util.h"
  1159. #include "base/strings/utf_string_conversions.h"
  1160. #include "base/system/sys_info.h"
  1161. +#include "base/base_switches.h"
  1162. #include "base/threading/thread_task_runner_handle.h"
  1163. #include "base/time/time.h"
  1164. #include "base/trace_event/optional_trace_event.h"
  1165. @@ -2467,7 +2468,8 @@ const blink::web_pref::WebPreferences WebContentsImpl::ComputeWebPreferences() {
  1166. prefs.threaded_scrolling_enabled =
  1167. !command_line.HasSwitch(blink::switches::kDisableThreadedScrolling);
  1168. - if (IsOverridingUserAgent())
  1169. + if (IsOverridingUserAgent() &&
  1170. + !command_line.HasSwitch(switches::kDesktopModeViewportMetaEnabled))
  1171. prefs.viewport_meta_enabled = false;
  1172. prefs.main_frame_resizes_are_orientation_changes =
  1173. diff --git a/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java b/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java
  1174. --- a/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java
  1175. +++ b/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java
  1176. @@ -168,7 +168,8 @@ import org.chromium.content_public.common.ResourceRequestBody;
  1177. params.getUserAgentOverrideOption(), params.getExtraHeadersString(),
  1178. params.getPostData(), params.getBaseUrl(), params.getVirtualUrlForDataUrl(),
  1179. params.getDataUrlAsString(), params.getCanLoadLocalResources(),
  1180. - params.getIsRendererInitiated(), params.getShouldReplaceCurrentEntry());
  1181. + params.getIsRendererInitiated(), params.getShouldReplaceCurrentEntry(),
  1182. + params.getUserAgentOverrideOption());
  1183. }
  1184. }
  1185. @@ -347,7 +348,8 @@ import org.chromium.content_public.common.ResourceRequestBody;
  1186. int referrerPolicy, int uaOverrideOption, String extraHeaders,
  1187. ResourceRequestBody postData, String baseUrlForDataUrl, String virtualUrlForDataUrl,
  1188. String dataUrlAsString, boolean canLoadLocalResources, boolean isRendererInitiated,
  1189. - boolean shouldReplaceCurrentEntry);
  1190. + boolean shouldReplaceCurrentEntry,
  1191. + int userAgentOverrideOption);
  1192. void clearHistory(long nativeNavigationControllerAndroid, NavigationControllerImpl caller);
  1193. int getNavigationHistory(long nativeNavigationControllerAndroid,
  1194. NavigationControllerImpl caller, Object history);
  1195. diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
  1196. --- a/content/renderer/render_thread_impl.cc
  1197. +++ b/content/renderer/render_thread_impl.cc
  1198. @@ -1697,7 +1697,6 @@ void RenderThreadImpl::SetWebKitSharedTimersSuspended(bool suspend) {
  1199. }
  1200. void RenderThreadImpl::SetUserAgent(const std::string& user_agent) {
  1201. - DCHECK(user_agent_.IsNull());
  1202. user_agent_ = WebString::FromUTF8(user_agent);
  1203. GetContentClient()->renderer()->DidSetUserAgent(user_agent);
  1204. }
  1205. --
  1206. 2.17.1