Bromite-AdBlockUpdaterService.patch 76 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823
  1. From: csagan5 <32685696+csagan5@users.noreply.github.com>
  2. Date: Sat, 14 Sep 2019 10:20:08 +0200
  3. Subject: Bromite AdBlockUpdaterService
  4. Add option to configure the ad blocker filters URL
  5. Disable look-alike, metrics, ablation and navigation throttles
  6. Do not use experiments to enable/disable presets
  7. Always enable ad filtering
  8. Download filters by checking Last-Modified header first
  9. Fix RestoreForeignSessionTab by recreating the tab (issue #681)
  10. ---
  11. chrome/android/chrome_java_resources.gni | 2 +
  12. chrome/android/chrome_java_sources.gni | 2 +
  13. .../java/res/layout/adblock_editor.xml | 67 +++++
  14. chrome/android/java/res/values/values.xml | 2 +
  15. .../java/res/xml/adblock_preferences.xml | 25 ++
  16. .../android/java/res/xml/main_preferences.xml | 5 +
  17. .../browser/settings/AdBlockEditor.java | 92 +++++++
  18. .../browser/settings/AdBlockPreferences.java | 61 +++++
  19. .../chrome/browser/tabmodel/TabModelImpl.java | 2 +-
  20. chrome/app/generated_resources.grd | 10 +
  21. chrome/browser/after_startup_task_utils.cc | 5 +
  22. chrome/browser/browser_process.h | 7 +
  23. chrome/browser/browser_process_impl.cc | 29 ++
  24. chrome/browser/browser_process_impl.h | 3 +
  25. chrome/browser/chrome_browser_main.cc | 2 +
  26. .../browser/chrome_content_browser_client.cc | 16 --
  27. .../flags/android/cached_feature_flags.cc | 11 +
  28. .../browser/flags/CachedFeatureFlags.java | 10 +
  29. .../net/system_network_context_manager.cc | 4 +
  30. .../sessions/session_restore_android.cc | 4 +-
  31. .../strings/android_chrome_strings.grd | 14 +
  32. chrome/common/pref_names.cc | 3 +
  33. chrome/common/pref_names.h | 1 +
  34. components/component_updater/BUILD.gn | 6 +
  35. .../adblock_updater_service.cc | 248 ++++++++++++++++++
  36. .../adblock_updater_service.h | 100 +++++++
  37. .../download_filters_task.cc | 222 ++++++++++++++++
  38. .../component_updater/download_filters_task.h | 129 +++++++++
  39. ...ent_subresource_filter_throttle_manager.cc | 11 +
  40. .../content/browser/ruleset_service.cc | 33 ++-
  41. .../content/browser/ruleset_service.h | 7 +-
  42. .../content/browser/ruleset_version.h | 4 +
  43. .../browser/verified_ruleset_dealer.cc | 3 +
  44. .../browser/subresource_filter_features.cc | 113 +-------
  45. .../core/common/common_features.cc | 2 +-
  46. .../navigation_throttle_runner.cc | 5 -
  47. 36 files changed, 1120 insertions(+), 140 deletions(-)
  48. create mode 100644 chrome/android/java/res/layout/adblock_editor.xml
  49. create mode 100644 chrome/android/java/res/xml/adblock_preferences.xml
  50. create mode 100644 chrome/android/java/src/org/chromium/chrome/browser/settings/AdBlockEditor.java
  51. create mode 100644 chrome/android/java/src/org/chromium/chrome/browser/settings/AdBlockPreferences.java
  52. create mode 100644 components/component_updater/adblock_updater_service.cc
  53. create mode 100644 components/component_updater/adblock_updater_service.h
  54. create mode 100644 components/component_updater/download_filters_task.cc
  55. create mode 100644 components/component_updater/download_filters_task.h
  56. diff --git a/chrome/android/chrome_java_resources.gni b/chrome/android/chrome_java_resources.gni
  57. --- a/chrome/android/chrome_java_resources.gni
  58. +++ b/chrome/android/chrome_java_resources.gni
  59. @@ -781,6 +781,7 @@ chrome_java_resources = [
  60. "java/res/layout/account_picker_new_account_row_legacy.xml",
  61. "java/res/layout/account_picker_row.xml",
  62. "java/res/layout/account_picker_row_legacy.xml",
  63. + "java/res/layout/adblock_editor.xml",
  64. "java/res/layout/add_languages_main.xml",
  65. "java/res/layout/add_to_homescreen_dialog.xml",
  66. "java/res/layout/add_to_menu_dialog.xml",
  67. @@ -1046,6 +1047,7 @@ chrome_java_resources = [
  68. "java/res/xml/about_chrome_preferences.xml",
  69. "java/res/xml/accessibility_preferences.xml",
  70. "java/res/xml/account_management_preferences.xml",
  71. + "java/res/xml/adblock_preferences.xml",
  72. "java/res/xml/autofill_assistant_preferences.xml",
  73. "java/res/xml/autofill_server_profile_preferences.xml",
  74. "java/res/xml/bookmark_widget_info.xml",
  75. diff --git a/chrome/android/chrome_java_sources.gni b/chrome/android/chrome_java_sources.gni
  76. --- a/chrome/android/chrome_java_sources.gni
  77. +++ b/chrome/android/chrome_java_sources.gni
  78. @@ -1301,6 +1301,8 @@ chrome_java_sources = [
  79. "java/src/org/chromium/chrome/browser/payments/ui/ShoppingCart.java",
  80. "java/src/org/chromium/chrome/browser/permissions/PermissionSettingsBridge.java",
  81. "java/src/org/chromium/chrome/browser/photo_picker/DecoderServiceImpl.java",
  82. + "java/src/org/chromium/chrome/browser/settings/AdBlockEditor.java",
  83. + "java/src/org/chromium/chrome/browser/settings/AdBlockPreferences.java",
  84. "java/src/org/chromium/chrome/browser/policy/EnterpriseInfo.java",
  85. "java/src/org/chromium/chrome/browser/policy/PolicyAuditor.java",
  86. "java/src/org/chromium/chrome/browser/prerender/ChromePrerenderServiceImpl.java",
  87. diff --git a/chrome/android/java/res/layout/adblock_editor.xml b/chrome/android/java/res/layout/adblock_editor.xml
  88. new file mode 100644
  89. --- /dev/null
  90. +++ b/chrome/android/java/res/layout/adblock_editor.xml
  91. @@ -0,0 +1,67 @@
  92. +<?xml version="1.0" encoding="utf-8"?>
  93. +<!-- Copyright 2015 The Chromium Authors. All rights reserved.
  94. + Use of this source code is governed by a BSD-style license that can be
  95. + found in the LICENSE file. -->
  96. +
  97. +<FrameLayout
  98. + xmlns:android="http://schemas.android.com/apk/res/android"
  99. + xmlns:app="http://schemas.android.com/apk/res-auto"
  100. + xmlns:tools="http://schemas.android.com/tools"
  101. + android:layout_width="match_parent"
  102. + android:layout_height="match_parent" >
  103. +
  104. + <ScrollView
  105. + android:layout_width="match_parent"
  106. + android:layout_height="match_parent"
  107. + android:id="@+id/scroll_view"
  108. + android:fillViewport="true" >
  109. +
  110. + <LinearLayout
  111. + android:layout_width="match_parent"
  112. + android:layout_height="wrap_content"
  113. + android:orientation="vertical"
  114. + android:focusableInTouchMode="true" >
  115. +
  116. + <com.google.android.material.textfield.TextInputLayout
  117. + android:id="@+id/adblock_url"
  118. + android:paddingTop="16dp"
  119. + android:paddingStart="@dimen/pref_autofill_content_spacing"
  120. + android:paddingEnd="@dimen/pref_autofill_content_spacing"
  121. + android:layout_width="match_parent"
  122. + android:layout_height="wrap_content" >
  123. + <!-- TODO(crbug.com/900912): Fix and remove lint ignore -->
  124. + <EditText
  125. + tools:ignore="Autofill"
  126. + android:id="@+id/adblock_url_edit"
  127. + android:layout_width="match_parent"
  128. + android:layout_height="wrap_content"
  129. + android:inputType="textUri"
  130. + android:singleLine="true"
  131. + android:hint="@string/options_adblock_edit_label" />
  132. + </com.google.android.material.textfield.TextInputLayout>
  133. +
  134. + <Space style="@style/ButtonBarTopSpacer" />
  135. + <View style="@style/ButtonBarTopDivider" />
  136. +
  137. + <LinearLayout style="@style/ButtonBar" >
  138. + <org.chromium.ui.widget.ButtonCompat
  139. + android:id="@+id/adblock_reset"
  140. + style="@style/ButtonBarButton"
  141. + android:text="@string/reset" />
  142. +
  143. + <org.chromium.ui.widget.ButtonCompat
  144. + android:id="@+id/adblock_cancel"
  145. + style="@style/ButtonBarButton"
  146. + android:text="@string/cancel" />
  147. +
  148. + <org.chromium.ui.widget.ButtonCompat
  149. + android:id="@+id/adblock_save"
  150. + style="@style/ButtonBarButton"
  151. + android:text="@string/save" />
  152. + </LinearLayout>
  153. + </LinearLayout>
  154. + </ScrollView>
  155. +
  156. + <include layout="@layout/settings_action_bar_shadow"/>
  157. +
  158. +</FrameLayout>
  159. diff --git a/chrome/android/java/res/values/values.xml b/chrome/android/java/res/values/values.xml
  160. --- a/chrome/android/java/res/values/values.xml
  161. +++ b/chrome/android/java/res/values/values.xml
  162. @@ -32,6 +32,8 @@
  163. <integer name="reload_button_level_reload">0</integer>
  164. <integer name="reload_button_level_stop">1</integer>
  165. + <string name="adblock_help_url">https://www.bromite.org/custom-filters</string>
  166. +
  167. <string name="proxy_title">Proxy configuration</string>
  168. <string name="proxy_url">chrome://proxy</string>
  169. diff --git a/chrome/android/java/res/xml/adblock_preferences.xml b/chrome/android/java/res/xml/adblock_preferences.xml
  170. new file mode 100644
  171. --- /dev/null
  172. +++ b/chrome/android/java/res/xml/adblock_preferences.xml
  173. @@ -0,0 +1,25 @@
  174. +<?xml version="1.0" encoding="utf-8"?>
  175. +<!-- Copyright 2015 The Chromium Authors. All rights reserved.
  176. + Use of this source code is governed by a BSD-style license that can be
  177. + found in the LICENSE file. -->
  178. +
  179. +<PreferenceScreen
  180. + xmlns:android="http://schemas.android.com/apk/res/android"
  181. + xmlns:app="http://schemas.android.com/apk/res-auto">
  182. +
  183. + <org.chromium.components.browser_ui.settings.ChromeSwitchPreference
  184. + android:key="adblock_switch"
  185. + android:summaryOn="@string/text_on"
  186. + android:summaryOff="@string/text_off" />
  187. +
  188. + <org.chromium.chrome.browser.about_settings.HyperlinkPreference
  189. + android:key="adblock_help"
  190. + android:title="@string/adblock_help"
  191. + app:url="@string/adblock_help_url" />
  192. +
  193. + <Preference
  194. + android:key="adblock_edit"
  195. + android:title="@string/options_adblock_edit_label"
  196. + android:fragment="org.chromium.chrome.browser.settings.AdBlockEditor" />
  197. +
  198. +</PreferenceScreen>
  199. diff --git a/chrome/android/java/res/xml/main_preferences.xml b/chrome/android/java/res/xml/main_preferences.xml
  200. --- a/chrome/android/java/res/xml/main_preferences.xml
  201. +++ b/chrome/android/java/res/xml/main_preferences.xml
  202. @@ -64,6 +64,11 @@
  203. android:key="privacy"
  204. android:order="12"
  205. android:title="@string/prefs_privacy"/>
  206. + <Preference
  207. + android:fragment="org.chromium.chrome.browser.settings.AdBlockPreferences"
  208. + android:key="adblock"
  209. + android:order="13"
  210. + android:title="@string/prefs_adblock"/>
  211. <Preference
  212. android:fragment="org.chromium.chrome.browser.safety_check.SafetyCheckSettingsFragment"
  213. android:key="safety_check"
  214. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/AdBlockEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/AdBlockEditor.java
  215. new file mode 100644
  216. --- /dev/null
  217. +++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/AdBlockEditor.java
  218. @@ -0,0 +1,92 @@
  219. +// Copyright 2015 The Chromium Authors. All rights reserved.
  220. +// Use of this source code is governed by a BSD-style license that can be
  221. +// found in the LICENSE file.
  222. +
  223. +package org.chromium.chrome.browser.settings;
  224. +
  225. +import android.os.Bundle;
  226. +import androidx.fragment.app.Fragment;
  227. +import android.text.Editable;
  228. +import android.text.TextWatcher;
  229. +import android.view.LayoutInflater;
  230. +import android.view.View;
  231. +import android.view.ViewGroup;
  232. +import android.widget.Button;
  233. +import android.widget.EditText;
  234. +
  235. +import org.chromium.components.browser_ui.settings.SettingsUtils;
  236. +import org.chromium.chrome.browser.flags.CachedFeatureFlags;
  237. +import org.chromium.chrome.R;
  238. +import org.chromium.components.url_formatter.UrlFormatter;
  239. +
  240. +/**
  241. + * Provides the Java-UI for editing AdBlock preferences.
  242. + */
  243. +public class AdBlockEditor extends Fragment implements TextWatcher {
  244. + private EditText mAdBlockFiltersUrlEdit;
  245. + private Button mSaveButton;
  246. + private Button mResetButton;
  247. +
  248. + @Override
  249. + public View onCreateView(LayoutInflater inflater, ViewGroup container,
  250. + Bundle savedInstanceState) {
  251. + super.onCreate(savedInstanceState);
  252. + getActivity().setTitle(R.string.options_adblock_edit_title);
  253. +
  254. + View v = inflater.inflate(R.layout.adblock_editor, container, false);
  255. + View scrollView = v.findViewById(R.id.scroll_view);
  256. + scrollView.getViewTreeObserver().addOnScrollChangedListener(
  257. + SettingsUtils.getShowShadowOnScrollListener(v, v.findViewById(R.id.shadow)));
  258. + mAdBlockFiltersUrlEdit = (EditText) v.findViewById(R.id.adblock_url_edit);
  259. + mAdBlockFiltersUrlEdit.setText(CachedFeatureFlags.getAdBlockFiltersURL());
  260. + mAdBlockFiltersUrlEdit.addTextChangedListener(this);
  261. + mAdBlockFiltersUrlEdit.requestFocus();
  262. +
  263. + initializeSaveCancelResetButtons(v);
  264. + return v;
  265. + }
  266. +
  267. + @Override
  268. + public void beforeTextChanged(CharSequence s, int start, int count, int after) {
  269. + }
  270. +
  271. + @Override
  272. + public void onTextChanged(CharSequence s, int start, int before, int count) {
  273. + mSaveButton.setEnabled(s.length() != 0);
  274. + mResetButton.setEnabled(true);
  275. + }
  276. +
  277. + @Override
  278. + public void afterTextChanged(Editable s) {
  279. + }
  280. +
  281. + private void initializeSaveCancelResetButtons(View v) {
  282. + mResetButton = (Button) v.findViewById(R.id.adblock_reset);
  283. + mResetButton.setOnClickListener(new View.OnClickListener() {
  284. + @Override
  285. + public void onClick(View v) {
  286. + mAdBlockFiltersUrlEdit.setText(CachedFeatureFlags.getAdBlockFiltersURL());
  287. + getActivity().finish();
  288. + }
  289. + });
  290. +
  291. + mSaveButton = (Button) v.findViewById(R.id.adblock_save);
  292. + mSaveButton.setEnabled(false);
  293. + mSaveButton.setOnClickListener(new View.OnClickListener() {
  294. + @Override
  295. + public void onClick(View v) {
  296. + CachedFeatureFlags.setAdBlockFiltersURL(
  297. + UrlFormatter.fixupUrl(mAdBlockFiltersUrlEdit.getText().toString()).getSpec());
  298. + getActivity().finish();
  299. + }
  300. + });
  301. +
  302. + Button button = (Button) v.findViewById(R.id.adblock_cancel);
  303. + button.setOnClickListener(new View.OnClickListener() {
  304. + @Override
  305. + public void onClick(View v) {
  306. + getActivity().finish();
  307. + }
  308. + });
  309. + }
  310. +}
  311. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/settings/AdBlockPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/settings/AdBlockPreferences.java
  312. new file mode 100644
  313. --- /dev/null
  314. +++ b/chrome/android/java/src/org/chromium/chrome/browser/settings/AdBlockPreferences.java
  315. @@ -0,0 +1,61 @@
  316. +// Copyright 2015 The Chromium Authors. All rights reserved.
  317. +// Use of this source code is governed by a BSD-style license that can be
  318. +// found in the LICENSE file.
  319. +
  320. +package org.chromium.chrome.browser.settings;
  321. +
  322. +import android.os.Bundle;
  323. +import androidx.preference.Preference;
  324. +import androidx.preference.PreferenceFragmentCompat;
  325. +import org.chromium.components.browser_ui.settings.ChromeSwitchPreference;
  326. +
  327. +import org.chromium.components.embedder_support.browser_context.BrowserContextHandle;
  328. +import org.chromium.components.browser_ui.site_settings.SiteSettingsPreferenceFragment;
  329. +import org.chromium.components.browser_ui.site_settings.WebsitePreferenceBridge;
  330. +import org.chromium.components.content_settings.ContentSettingsType;
  331. +import org.chromium.components.browser_ui.settings.SettingsUtils;
  332. +import org.chromium.chrome.browser.flags.CachedFeatureFlags;
  333. +import androidx.annotation.VisibleForTesting;
  334. +import org.chromium.chrome.R;
  335. +
  336. +/**
  337. + * Fragment that allows the user to configure AdBlock related preferences.
  338. + */
  339. +public class AdBlockPreferences extends SiteSettingsPreferenceFragment {
  340. + @VisibleForTesting
  341. + public static final String PREF_ADBLOCK_SWITCH = "adblock_switch";
  342. + private static final String PREF_ADBLOCK_EDIT = "adblock_edit";
  343. +
  344. + private Preference mAdBlockEdit;
  345. +
  346. + @Override
  347. + public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
  348. + getActivity().setTitle(R.string.options_adblock_title);
  349. + SettingsUtils.addPreferencesFromResource(this, R.xml.adblock_preferences);
  350. +
  351. + BrowserContextHandle browserContextHandle =
  352. + getSiteSettingsClient().getBrowserContextHandle();
  353. +
  354. + ChromeSwitchPreference mAdBlockSwitch =
  355. + (ChromeSwitchPreference) findPreference(PREF_ADBLOCK_SWITCH);
  356. + boolean isAdBlockEnabled = !WebsitePreferenceBridge.isCategoryEnabled(browserContextHandle, ContentSettingsType.ADS);
  357. + mAdBlockSwitch.setChecked(isAdBlockEnabled);
  358. + mAdBlockSwitch.setOnPreferenceChangeListener((preference, newValue) -> {
  359. + WebsitePreferenceBridge.setCategoryEnabled(browserContextHandle, ContentSettingsType.ADS, !(boolean) newValue);
  360. + return true;
  361. + });
  362. +
  363. + mAdBlockEdit = findPreference(PREF_ADBLOCK_EDIT);
  364. + updateCurrentAdBlockUrl();
  365. + }
  366. +
  367. + private void updateCurrentAdBlockUrl() {
  368. + mAdBlockEdit.setSummary(CachedFeatureFlags.getAdBlockFiltersURL());
  369. + }
  370. +
  371. + @Override
  372. + public void onResume() {
  373. + super.onResume();
  374. + updateCurrentAdBlockUrl();
  375. + }
  376. +}
  377. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java
  378. --- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java
  379. +++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java
  380. @@ -815,7 +815,7 @@ public class TabModelImpl extends TabModelJniBridge {
  381. Tab parent, Profile profile, WebContents webContents) {
  382. return getTabCreator(profile.isOffTheRecord())
  383. .createTabWithWebContents(
  384. - parent, webContents, TabLaunchType.FROM_LONGPRESS_BACKGROUND);
  385. + parent, webContents, TabLaunchType.FROM_LINK);
  386. }
  387. @Override
  388. diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
  389. --- a/chrome/app/generated_resources.grd
  390. +++ b/chrome/app/generated_resources.grd
  391. @@ -10242,6 +10242,16 @@ Please help our engineers fix this problem. Tell us what happened right before y
  392. Never show this again.
  393. </message>
  394. + <!-- Ad Blocking preferences -->
  395. + <if expr="is_android">
  396. + <message name="IDS_OPTIONS_ADBLOCK_TITLE" desc="The title of the Ad Blocking option on Android" formatter_data="android_java">
  397. + Ad Blocking
  398. + </message>
  399. + <message name="IDS_OPTIONS_ADBLOCK_SUMMARY" desc="The title of the Ad Blocking summary on Android" formatter_data="android_java">
  400. + Configure Ad Blocking and filters URL
  401. + </message>
  402. + </if>
  403. +
  404. <!-- Ad Blocking UI strings. -->
  405. <message name="IDS_BLOCKED_ADS_PROMPT_TOOLTIP" desc="Explanation that Chrome blocked ads on this site. To be shown as a tooltip on the Ads blocked desktop bubble">
  406. Ads blocked on this site
  407. diff --git a/chrome/browser/after_startup_task_utils.cc b/chrome/browser/after_startup_task_utils.cc
  408. --- a/chrome/browser/after_startup_task_utils.cc
  409. +++ b/chrome/browser/after_startup_task_utils.cc
  410. @@ -36,6 +36,8 @@
  411. #include "ui/views/linux_ui/linux_ui.h"
  412. #endif
  413. +#include "chrome/browser/browser_process.h"
  414. +
  415. using content::BrowserThread;
  416. using content::WebContents;
  417. using content::WebContentsObserver;
  418. @@ -138,6 +140,9 @@ void SetBrowserStartupIsComplete() {
  419. g_after_startup_tasks.Get().clear();
  420. g_after_startup_tasks.Get().shrink_to_fit();
  421. + // initialize scheduled updates for the AdBlock updater
  422. + g_browser_process->adblock_updater()->Start();
  423. +
  424. #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
  425. // Make sure we complete the startup notification sequence, or launchers will
  426. // get confused by not receiving the expected message from the main process.
  427. diff --git a/chrome/browser/browser_process.h b/chrome/browser/browser_process.h
  428. --- a/chrome/browser/browser_process.h
  429. +++ b/chrome/browser/browser_process.h
  430. @@ -21,6 +21,7 @@
  431. #include "build/build_config.h"
  432. #include "chrome/common/buildflags.h"
  433. #include "media/media_buildflags.h"
  434. +#include "components/component_updater/adblock_updater_service.h"
  435. class BackgroundModeManager;
  436. class BrowserProcessPlatformPart;
  437. @@ -66,6 +67,10 @@ class ComponentUpdateService;
  438. class SupervisedUserWhitelistInstaller;
  439. }
  440. +namespace adblock_updater {
  441. +class AdBlockUpdaterService;
  442. +}
  443. +
  444. namespace extensions {
  445. class EventRouterForwarder;
  446. }
  447. @@ -244,6 +249,8 @@ class BrowserProcess {
  448. virtual component_updater::ComponentUpdateService* component_updater() = 0;
  449. + virtual adblock_updater::AdBlockUpdaterService* adblock_updater() = 0;
  450. +
  451. #if BUILDFLAG(ENABLE_SUPERVISED_USERS)
  452. virtual component_updater::SupervisedUserWhitelistInstaller*
  453. supervised_user_whitelist_installer() = 0;
  454. diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
  455. --- a/chrome/browser/browser_process_impl.cc
  456. +++ b/chrome/browser/browser_process_impl.cc
  457. @@ -1047,6 +1047,35 @@ BrowserProcessImpl::component_updater() {
  458. return component_updater_.get();
  459. }
  460. +adblock_updater::AdBlockUpdaterService*
  461. +BrowserProcessImpl::adblock_updater() {
  462. + if (adblock_updater_)
  463. + return adblock_updater_.get();
  464. +
  465. + if (!BrowserThread::CurrentlyOn(BrowserThread::UI))
  466. + return nullptr;
  467. +
  468. + std::unique_ptr<component_updater::UpdateScheduler> scheduler;
  469. +#if defined(OS_ANDROID)
  470. + if (base::FeatureList::IsEnabled(
  471. + chrome::android::kBackgroundTaskComponentUpdate) &&
  472. + component_updater::BackgroundTaskUpdateScheduler::IsAvailable()) {
  473. + scheduler =
  474. + std::make_unique<component_updater::BackgroundTaskUpdateScheduler>();
  475. + }
  476. +#endif
  477. + if (!scheduler)
  478. + scheduler = std::make_unique<component_updater::TimerUpdateScheduler>();
  479. +
  480. + adblock_updater_ = std::make_unique<adblock_updater::AdBlockUpdaterService>(
  481. + g_browser_process->system_network_context_manager()->GetSharedURLLoaderFactory(),
  482. + std::move(scheduler),
  483. + g_browser_process->subresource_filter_ruleset_service(),
  484. + local_state()->GetString(prefs::kAdBlockFiltersURL));
  485. +
  486. + return adblock_updater_.get();
  487. +}
  488. +
  489. #if BUILDFLAG(ENABLE_SUPERVISED_USERS)
  490. component_updater::SupervisedUserWhitelistInstaller*
  491. BrowserProcessImpl::supervised_user_whitelist_installer() {
  492. diff --git a/chrome/browser/browser_process_impl.h b/chrome/browser/browser_process_impl.h
  493. --- a/chrome/browser/browser_process_impl.h
  494. +++ b/chrome/browser/browser_process_impl.h
  495. @@ -183,6 +183,7 @@ class BrowserProcessImpl : public BrowserProcess,
  496. #endif
  497. component_updater::ComponentUpdateService* component_updater() override;
  498. + adblock_updater::AdBlockUpdaterService* adblock_updater() override;
  499. #if BUILDFLAG(ENABLE_SUPERVISED_USERS)
  500. component_updater::SupervisedUserWhitelistInstaller*
  501. supervised_user_whitelist_installer() override;
  502. @@ -367,6 +368,8 @@ class BrowserProcessImpl : public BrowserProcess,
  503. // but some users of component updater only install per-user.
  504. std::unique_ptr<component_updater::ComponentUpdateService> component_updater_;
  505. + std::unique_ptr<adblock_updater::AdBlockUpdaterService> adblock_updater_;
  506. +
  507. #if BUILDFLAG(ENABLE_SUPERVISED_USERS)
  508. std::unique_ptr<component_updater::SupervisedUserWhitelistInstaller>
  509. supervised_user_whitelist_installer_;
  510. diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
  511. --- a/chrome/browser/chrome_browser_main.cc
  512. +++ b/chrome/browser/chrome_browser_main.cc
  513. @@ -1594,6 +1594,8 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
  514. if (!parsed_command_line().HasSwitch(switches::kDisableComponentUpdate)) {
  515. component_updater::RegisterComponentsForUpdate(profile_->IsOffTheRecord(),
  516. profile_->GetPrefs());
  517. + // force initialisation
  518. + g_browser_process->adblock_updater();
  519. }
  520. variations::VariationsService* variations_service =
  521. diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
  522. --- a/chrome/browser/chrome_content_browser_client.cc
  523. +++ b/chrome/browser/chrome_content_browser_client.cc
  524. @@ -68,7 +68,6 @@
  525. #include "chrome/browser/hid/chrome_hid_delegate.h"
  526. #include "chrome/browser/interstitials/enterprise_util.h"
  527. #include "chrome/browser/lifetime/browser_shutdown.h"
  528. -#include "chrome/browser/lookalikes/lookalike_url_navigation_throttle.h"
  529. #include "chrome/browser/media/audio_service_util.h"
  530. #include "chrome/browser/media/router/media_router_feature.h"
  531. #include "chrome/browser/media/webrtc/audio_debug_recordings_handler.h"
  532. @@ -231,7 +230,6 @@
  533. #include "components/no_state_prefetch/common/prerender_types.mojom.h"
  534. #include "components/no_state_prefetch/common/prerender_url_loader_throttle.h"
  535. #include "components/no_state_prefetch/common/prerender_util.h"
  536. -#include "components/page_load_metrics/browser/metrics_navigation_throttle.h"
  537. #include "components/page_load_metrics/browser/metrics_web_contents_observer.h"
  538. #include "components/payments/content/payment_request_display_manager.h"
  539. #include "components/performance_manager/embedder/performance_manager_registry.h"
  540. @@ -3919,16 +3917,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
  541. content::NavigationHandle* handle) {
  542. std::vector<std::unique_ptr<content::NavigationThrottle>> throttles;
  543. - // MetricsNavigationThrottle requires that it runs before NavigationThrottles
  544. - // that may delay or cancel navigations, so only NavigationThrottles that
  545. - // don't delay or cancel navigations (e.g. throttles that are only observing
  546. - // callbacks without affecting navigation behavior) should be added before
  547. - // MetricsNavigationThrottle.
  548. - if (handle->IsInMainFrame()) {
  549. - throttles.push_back(
  550. - page_load_metrics::MetricsNavigationThrottle::Create(handle));
  551. - }
  552. -
  553. #if defined(OS_CHROMEOS)
  554. MaybeAddThrottle(
  555. chromeos::WebTimeLimitNavigationThrottle::MaybeCreateThrottleFor(handle),
  556. @@ -4037,10 +4025,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
  557. &throttles);
  558. #endif
  559. - MaybeAddThrottle(
  560. - LookalikeUrlNavigationThrottle::MaybeCreateNavigationThrottle(handle),
  561. - &throttles);
  562. -
  563. MaybeAddThrottle(PDFIFrameNavigationThrottle::MaybeCreateThrottleFor(handle),
  564. &throttles);
  565. diff --git a/chrome/browser/flags/android/cached_feature_flags.cc b/chrome/browser/flags/android/cached_feature_flags.cc
  566. --- a/chrome/browser/flags/android/cached_feature_flags.cc
  567. +++ b/chrome/browser/flags/android/cached_feature_flags.cc
  568. @@ -8,6 +8,9 @@
  569. #include "base/android/jni_string.h"
  570. #include "base/feature_list.h"
  571. +#include "chrome/browser/browser_process.h"
  572. +#include "chrome/common/pref_names.h"
  573. +#include "components/prefs/pref_service.h"
  574. #include "content/public/common/content_features.h"
  575. #include "content/public/common/network_service_util.h"
  576. @@ -41,3 +44,11 @@ static jboolean JNI_CachedFeatureFlags_IsNetworkServiceWarmUpEnabled(
  577. return content::IsOutOfProcessNetworkService() &&
  578. base::FeatureList::IsEnabled(features::kWarmUpNetworkProcess);
  579. }
  580. +
  581. +static ScopedJavaLocalRef<jstring> JNI_CachedFeatureFlags_GetAdBlockFiltersURL(JNIEnv* env) {
  582. + return base::android::ConvertUTF8ToJavaString(env, g_browser_process->local_state()->GetString(prefs::kAdBlockFiltersURL));
  583. +}
  584. +
  585. +static void JNI_CachedFeatureFlags_SetAdBlockFiltersURL(JNIEnv* env, const JavaParamRef<jstring>& url) {
  586. + g_browser_process->local_state()->SetString(prefs::kAdBlockFiltersURL, base::android::ConvertJavaStringToUTF8(env, url));
  587. +}
  588. diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
  589. --- a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
  590. +++ b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
  591. @@ -250,6 +250,14 @@ public class CachedFeatureFlags {
  592. ChromeFeatureList.REACHED_CODE_PROFILER, "sampling_interval_us", 0));
  593. }
  594. + public static void setAdBlockFiltersURL(String url) {
  595. + CachedFeatureFlagsJni.get().setAdBlockFiltersURL(url);
  596. + }
  597. +
  598. + public static String getAdBlockFiltersURL() {
  599. + return CachedFeatureFlagsJni.get().getAdBlockFiltersURL();
  600. + }
  601. +
  602. /**
  603. * Caches flags that must take effect on startup but are set via native code.
  604. */
  605. @@ -402,5 +410,7 @@ public class CachedFeatureFlags {
  606. @NativeMethods
  607. interface Natives {
  608. boolean isNetworkServiceWarmUpEnabled();
  609. + void setAdBlockFiltersURL(String url);
  610. + String getAdBlockFiltersURL();
  611. }
  612. }
  613. diff --git a/chrome/browser/net/system_network_context_manager.cc b/chrome/browser/net/system_network_context_manager.cc
  614. --- a/chrome/browser/net/system_network_context_manager.cc
  615. +++ b/chrome/browser/net/system_network_context_manager.cc
  616. @@ -333,6 +333,8 @@ SystemNetworkContextManager::SystemNetworkContextManager(
  617. SSLConfigServiceManager::CreateDefaultManager(local_state_)),
  618. proxy_config_monitor_(local_state_),
  619. stub_resolver_config_reader_(local_state_) {
  620. + local_state_->SetDefaultPrefValue(prefs::kAdBlockFiltersURL,
  621. + base::Value("https://www.bromite.org/filters/filters.dat"));
  622. #if !defined(OS_ANDROID)
  623. // QuicAllowed was not part of Android policy.
  624. const base::Value* value =
  625. @@ -397,6 +399,8 @@ SystemNetworkContextManager::~SystemNetworkContextManager() {
  626. void SystemNetworkContextManager::RegisterPrefs(PrefRegistrySimple* registry) {
  627. StubResolverConfigReader::RegisterPrefs(registry);
  628. + registry->RegisterStringPref(prefs::kAdBlockFiltersURL, std::string());
  629. +
  630. // Static auth params
  631. registry->RegisterStringPref(prefs::kAuthSchemes,
  632. "basic,digest,ntlm,negotiate");
  633. diff --git a/chrome/browser/sessions/session_restore_android.cc b/chrome/browser/sessions/session_restore_android.cc
  634. --- a/chrome/browser/sessions/session_restore_android.cc
  635. +++ b/chrome/browser/sessions/session_restore_android.cc
  636. @@ -43,7 +43,9 @@ content::WebContents* SessionRestore::RestoreForeignSessionTab(
  637. TabAndroid* current_tab = TabAndroid::FromWebContents(web_contents);
  638. DCHECK(current_tab);
  639. if (disposition == WindowOpenDisposition::CURRENT_TAB) {
  640. - current_tab->SwapWebContents(std::move(new_web_contents), false, false);
  641. + int active_tab_index = tab_model->GetActiveIndex();
  642. + tab_model->CreateTab(current_tab, new_web_contents.release());
  643. + tab_model->CloseTabAt(active_tab_index);
  644. } else {
  645. DCHECK(disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB ||
  646. disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB);
  647. diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
  648. --- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
  649. +++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
  650. @@ -214,6 +214,20 @@ CHAR-LIMIT guidelines:
  651. Enter VR
  652. </message>
  653. + <!-- AdBlock settings -->
  654. + <message name="IDS_PREFS_ADBLOCK" desc="Title of the AdBlock Settings screen. [CHAR-LIMIT=32]">
  655. + AdBlock settings
  656. + </message>
  657. + <message name="IDS_OPTIONS_ADBLOCK_EDIT_TITLE" desc="The title of the screen that allows users to change the URL that is used to fetch the ad blocker filters.">
  658. + Edit filters URL
  659. + </message>
  660. + <message name="IDS_OPTIONS_ADBLOCK_EDIT_LABEL" desc="The label for the edit text field that allows the user to change the URL that is used to fetch the ad blocker filters.">
  661. + Filters URL
  662. + </message>
  663. + <message name="IDS_ADBLOCK_HELP" desc="The title of the hyperlink that allows users to visit the web page with instructions for custom ad blocker filters.">
  664. + Visit help page
  665. + </message>
  666. +
  667. <!-- Notification channels -->
  668. <message name="IDS_NOTIFICATION_CATEGORY_GROUP_GENERAL" desc='Subheading for "General" section of a list of notification categories. [CHAR-LIMIT=32]'>
  669. General
  670. diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc
  671. --- a/chrome/common/pref_names.cc
  672. +++ b/chrome/common/pref_names.cc
  673. @@ -2120,6 +2120,9 @@ const char kAudioCaptureAllowed[] = "hardware.audio_capture_enabled";
  674. // capture devices without prompt.
  675. const char kAudioCaptureAllowedUrls[] = "hardware.audio_capture_allowed_urls";
  676. +// Holds the URL to an indexed subresource filters file.
  677. +const char kAdBlockFiltersURL[] = "adblock.filters_url";
  678. +
  679. // A pref holding the value of the policy used to explicitly allow or deny
  680. // access to video capture devices. When enabled or not set, the user is
  681. // prompted for device access. When disabled, access to video capture devices
  682. diff --git a/chrome/common/pref_names.h b/chrome/common/pref_names.h
  683. --- a/chrome/common/pref_names.h
  684. +++ b/chrome/common/pref_names.h
  685. @@ -31,6 +31,7 @@ extern const char kDownloadRestrictions[];
  686. extern const char kForceEphemeralProfiles[];
  687. extern const char kHomePageIsNewTabPage[];
  688. extern const char kHomePage[];
  689. +extern const char kAdBlockFiltersURL[];
  690. extern const char kImportantSitesDialogHistory[];
  691. extern const char kProfileCreationTime[];
  692. #if defined(OS_WIN)
  693. diff --git a/components/component_updater/BUILD.gn b/components/component_updater/BUILD.gn
  694. --- a/components/component_updater/BUILD.gn
  695. +++ b/components/component_updater/BUILD.gn
  696. @@ -10,6 +10,12 @@ static_library("component_updater") {
  697. "component_updater_command_line_config_policy.h",
  698. "component_updater_paths.cc",
  699. "component_updater_paths.h",
  700. +
  701. + "adblock_updater_service.cc",
  702. + "adblock_updater_service.h",
  703. + "download_filters_task.cc",
  704. + "download_filters_task.h",
  705. +
  706. "component_updater_service.cc",
  707. "component_updater_service.h",
  708. "component_updater_service_internal.h",
  709. diff --git a/components/component_updater/adblock_updater_service.cc b/components/component_updater/adblock_updater_service.cc
  710. new file mode 100644
  711. --- /dev/null
  712. +++ b/components/component_updater/adblock_updater_service.cc
  713. @@ -0,0 +1,248 @@
  714. +/*
  715. + This file is part of Bromite.
  716. +
  717. + Bromite is free software: you can redistribute it and/or modify
  718. + it under the terms of the GNU General Public License as published by
  719. + the Free Software Foundation, either version 3 of the License, or
  720. + (at your option) any later version.
  721. +
  722. + Bromite is distributed in the hope that it will be useful,
  723. + but WITHOUT ANY WARRANTY; without even the implied warranty of
  724. + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  725. + GNU General Public License for more details.
  726. +
  727. + You should have received a copy of the GNU General Public License
  728. + along with Bromite. If not, see <https://www.gnu.org/licenses/>.
  729. +*/
  730. +
  731. +#include "components/component_updater/adblock_updater_service.h"
  732. +
  733. +#include <algorithm>
  734. +#include <map>
  735. +#include <string>
  736. +#include <utility>
  737. +#include <vector>
  738. +
  739. +#include "base/bind.h"
  740. +#include "base/callback.h"
  741. +#include "base/files/file_path.h"
  742. +#include "base/files/file_util.h"
  743. +#include "base/logging.h"
  744. +#include "base/macros.h"
  745. +#include "base/threading/thread_checker.h"
  746. +#include "base/threading/thread_task_runner_handle.h"
  747. +#include "base/time/time.h"
  748. +#include "base/timer/timer.h"
  749. +#include "url/gurl.h"
  750. +#include "base/strings/safe_sprintf.h"
  751. +#include "base/strings/string_number_conversions.h"
  752. +#include "base/strings/string_split.h"
  753. +namespace adblock_updater {
  754. +
  755. +// all constants express seconds
  756. +// these could be made configurable
  757. +const int initial_check_delay = 5,
  758. + next_check_delay = 60*60*24*7, // 1 week
  759. + on_demand_check_delay = 60; // minimum 1 minute between each on-demand check
  760. +
  761. +AdBlockUpdaterService::AdBlockUpdaterService(scoped_refptr<network::SharedURLLoaderFactory> shared_url_network_factory, std::unique_ptr<component_updater::UpdateScheduler> scheduler,
  762. + subresource_filter::RulesetService* ruleset_service, std::string filters_url)
  763. + : ruleset_service_(ruleset_service), shared_url_network_factory_(shared_url_network_factory), scheduler_(std::move(scheduler)) {
  764. + DCHECK(ruleset_service);
  765. +
  766. + filters_url_ = filters_url;
  767. +}
  768. +
  769. +AdBlockUpdaterService::~AdBlockUpdaterService() {
  770. + DCHECK(thread_checker_.CalledOnValidThread());
  771. +}
  772. +
  773. +void AdBlockUpdaterService::AddObserver(Observer* observer) {
  774. + DCHECK(thread_checker_.CalledOnValidThread());
  775. + observer_list_.AddObserver(observer);
  776. +}
  777. +
  778. +void AdBlockUpdaterService::RemoveObserver(Observer* observer) {
  779. + DCHECK(thread_checker_.CalledOnValidThread());
  780. + observer_list_.RemoveObserver(observer);
  781. +}
  782. +
  783. +//TODO: use this as in: base::Bind(&AdBlockUpdaterService::NotifyObservers, base::Unretained(this)
  784. +void AdBlockUpdaterService::NotifyObservers(Event event) {
  785. + DCHECK(thread_checker_.CalledOnValidThread());
  786. + for (auto& observer : observer_list_)
  787. + observer.OnEvent(event);
  788. +}
  789. +
  790. +void AdBlockUpdaterService::Start() {
  791. + DCHECK(thread_checker_.CalledOnValidThread());
  792. +
  793. + // avoid multiple scheduling
  794. + if (scheduled_)
  795. + return;
  796. + scheduled_ = true;
  797. +
  798. + LOG(INFO) << "AdBlockUpdaterService: starting up. "
  799. + << "First update attempt will take place in "
  800. + << initial_check_delay << " seconds. "
  801. + << "Next update attempt will take place in "
  802. + << next_check_delay << " seconds. ";
  803. +
  804. + scheduler_->Schedule(
  805. + base::TimeDelta::FromSeconds(initial_check_delay),
  806. + base::TimeDelta::FromSeconds(next_check_delay),
  807. + base::Bind(&AdBlockUpdaterService::OnDemandScheduledUpdate,
  808. + base::Unretained(this)), base::DoNothing());
  809. +}
  810. +
  811. +void AdBlockUpdaterService::OnDemandScheduledUpdate(component_updater::UpdateScheduler::OnFinishedCallback on_finished) {
  812. + //TODO: call on_finished
  813. + OnDemandUpdateAsNeeded(false, Callback());
  814. +}
  815. +
  816. +bool AdBlockUpdaterService::OnDemandUpdate(Callback on_finished) {
  817. + return OnDemandUpdateAsNeeded(true, std::move(on_finished));
  818. +}
  819. +
  820. +bool AdBlockUpdaterService::OnDemandUpdateAsNeeded(bool is_foreground, Callback on_finished) {
  821. + DCHECK(thread_checker_.CalledOnValidThread());
  822. +
  823. + // Check if the request is too soon.
  824. + if (!last_update_.is_null()) {
  825. + base::TimeDelta delta =
  826. + base::TimeTicks::Now() - last_update_;
  827. + if (is_updating_ || (delta < base::TimeDelta::FromSeconds(on_demand_check_delay)))
  828. + LOG(INFO) << "AdBlockUpdaterService: update not necessary.";
  829. + return false;
  830. + }
  831. +
  832. + OnDemandUpdateInternal(is_foreground, std::move(on_finished));
  833. + return true;
  834. +}
  835. +
  836. +void AdBlockUpdaterService::OnDemandUpdateInternal(bool is_foreground, Callback on_finished) {
  837. + DCHECK(thread_checker_.CalledOnValidThread());
  838. +
  839. + if (is_updating_) {
  840. + base::ThreadTaskRunnerHandle::Get()->PostTask(
  841. + FROM_HERE, base::BindOnce(std::move(on_finished),
  842. + Error::UPDATE_IN_PROGRESS));
  843. + return;
  844. + }
  845. + is_updating_ = true;
  846. + last_update_ = base::TimeTicks::Now();
  847. +
  848. + base::Time::Exploded e = {0};
  849. + base::Time t = base::Time();
  850. + auto version = ruleset_service_->GetMostRecentlyIndexedVersion();
  851. + LOG(INFO) << "AdBlockUpdaterService: MostRecentIndexedVersion = " << version.content_version;
  852. + std::vector<std::string> tokens =
  853. + base::SplitString(version.content_version, ".", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
  854. + int i = 0;
  855. + bool failed = false;
  856. + for (const std::string& token : tokens) {
  857. + // parse as number
  858. + int n = 0;
  859. + if (!base::StringToInt(token, &n)) {
  860. + failed = true;
  861. + break;
  862. + }
  863. +
  864. + switch (i++) {
  865. + case 0:
  866. + e.year = 2019 + n;
  867. + break;
  868. + case 1:
  869. + e.month = n + 1;
  870. + break;
  871. + case 2:
  872. + e.day_of_month = n + 1;
  873. + break;
  874. + case 3:
  875. + e.second = n % 60;
  876. + n -= e.second;
  877. + n /= 60;
  878. + e.minute = n % 60;
  879. + e.hour = n / 60;
  880. + break;
  881. + default:
  882. + failed = true;
  883. + break;
  884. + }
  885. + }
  886. +
  887. + if (failed) {
  888. + LOG(WARNING) << "AdBlockUpdaterService: failed to parse most recent version as x.y.z.w dot-separated integers";
  889. + } else {
  890. + if (!base::Time::FromUTCExploded(e, &t))
  891. + LOG(WARNING) << "AdBlockUpdaterService: failed to convert version to time.";
  892. + }
  893. +
  894. + auto task = base::MakeRefCounted<DownloadFiltersTask>(
  895. + shared_url_network_factory_,
  896. + is_foreground, filters_url_,
  897. + t,
  898. + base::BindOnce(&AdBlockUpdaterService::OnUpdateComplete, base::Unretained(this),
  899. + std::move(on_finished)));
  900. +
  901. + // run task now; task is responsible for clearing the is_updating status
  902. + base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
  903. + base::BindOnce(&DownloadFiltersTask::Run, base::Unretained(task.get())));
  904. + tasks_.insert(task);
  905. +}
  906. +
  907. +void AdBlockUpdaterService::OnUpdateComplete(Callback on_finished,
  908. + scoped_refptr<DownloadFiltersTask> task,
  909. + Error error) {
  910. + DCHECK(thread_checker_.CalledOnValidThread());
  911. +
  912. + auto file_path = task->file_path();
  913. + if (error == Error::NONE) {
  914. + subresource_filter::UnindexedRulesetInfo ruleset_info;
  915. + ruleset_info.ruleset_path = file_path;
  916. + ruleset_info.delete_ruleset_path = true;
  917. + ruleset_info.content_version = "0.0.0.0";
  918. + DCHECK(!ruleset_info.ruleset_path.empty());
  919. +
  920. + // convert time to version
  921. + auto t = task->last_modified();
  922. + bool ignore_version = t.is_null();
  923. + if (!ignore_version) {
  924. + base::Time::Exploded e;
  925. + t.UTCExplode(&e);
  926. +
  927. + // convert time to version
  928. + const int major = e.year - 2019,
  929. + minor = e.month - 1,
  930. + patch = e.day_of_month - 1,
  931. + revision = (e.hour*60+e.minute)*60 + e.second;
  932. + if (major < 0)
  933. + LOG(WARNING) << "AdBlockUpdaterService: too old Last-Modified header, ignoring version check.";
  934. + else {
  935. + char version_buffer[32];
  936. + base::strings::SafeSNPrintf(version_buffer, sizeof(version_buffer), "%d.%d.%d.%d",
  937. + major, minor, patch, revision);
  938. +
  939. + ruleset_info.content_version = version_buffer;
  940. +
  941. + LOG(INFO) << "AdBlockUpdaterService: indexing filters with version " << ruleset_info.content_version;
  942. + }
  943. + } else
  944. + LOG(WARNING) << "AdBlockUpdaterService: invalid Last-Modified header, ignoring version check.";
  945. + ruleset_service_->IndexAndStoreAndPublishRulesetIfNeeded(ruleset_info, ignore_version);
  946. + } else {
  947. + //TODO: generate event for ADBLOCK_NOT_UPDATED in case of error UPDATE_NOT_NEEDED
  948. + }
  949. +
  950. + //TODO: run these only when index-and-store is actually finished?
  951. + if (!on_finished.is_null()) {
  952. + base::ThreadTaskRunnerHandle::Get()->PostTask(
  953. + FROM_HERE, base::BindOnce(std::move(on_finished), error));
  954. + }
  955. +
  956. + // mark as not updating
  957. + is_updating_ = false;
  958. + tasks_.erase(task);
  959. +}
  960. +
  961. +} // namespace adblock_updater
  962. diff --git a/components/component_updater/adblock_updater_service.h b/components/component_updater/adblock_updater_service.h
  963. new file mode 100644
  964. --- /dev/null
  965. +++ b/components/component_updater/adblock_updater_service.h
  966. @@ -0,0 +1,100 @@
  967. +/*
  968. + This file is part of Bromite.
  969. +
  970. + Bromite is free software: you can redistribute it and/or modify
  971. + it under the terms of the GNU General Public License as published by
  972. + the Free Software Foundation, either version 3 of the License, or
  973. + (at your option) any later version.
  974. +
  975. + Bromite is distributed in the hope that it will be useful,
  976. + but WITHOUT ANY WARRANTY; without even the implied warranty of
  977. + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  978. + GNU General Public License for more details.
  979. +
  980. + You should have received a copy of the GNU General Public License
  981. + along with Bromite. If not, see <https://www.gnu.org/licenses/>.
  982. +*/
  983. +
  984. +#ifndef COMPONENTS_ADBLOCK_UPDATER_SERVICE_H
  985. +#define COMPONENTS_ADBLOCK_UPDATER_SERVICE_H
  986. +
  987. +#include <stdint.h>
  988. +
  989. +#include <memory>
  990. +#include <string>
  991. +#include <vector>
  992. +
  993. +#include "base/callback_forward.h"
  994. +#include "base/gtest_prod_util.h"
  995. +#include "base/memory/ref_counted.h"
  996. +#include "base/version.h"
  997. +#include "build/build_config.h"
  998. +#include "components/component_updater/update_scheduler.h"
  999. +#include "url/gurl.h"
  1000. +#include "components/component_updater/download_filters_task.h"
  1001. +#include "components/subresource_filter/content/browser/ruleset_service.h"
  1002. +#include "services/network/public/cpp/shared_url_loader_factory.h"
  1003. +
  1004. +namespace adblock_updater {
  1005. +
  1006. +// Called when a non-blocking call in this module completes.
  1007. +using Callback = base::OnceCallback<void(Error error)>;
  1008. +
  1009. +class Observer {
  1010. + public:
  1011. + virtual ~Observer() {}
  1012. +
  1013. + // Called by the update service when a state change happens.
  1014. + virtual void OnEvent(Event event) = 0;
  1015. +};
  1016. +
  1017. +// The AdBlock update service is in charge of downloading and saving the
  1018. +// AdBlock filters.
  1019. +//
  1020. +// All methods are safe to call ONLY from the browser's main thread.
  1021. +class AdBlockUpdaterService {
  1022. + public:
  1023. + AdBlockUpdaterService(scoped_refptr<network::SharedURLLoaderFactory> shared_url_network_factory, std::unique_ptr<component_updater::UpdateScheduler> scheduler,
  1024. + subresource_filter::RulesetService* ruleset_service, std::string filters_url);
  1025. + ~AdBlockUpdaterService();
  1026. +
  1027. + // Adds an observer for this class. An observer should not be added more
  1028. + // than once. The caller retains the ownership of the observer object.
  1029. + void AddObserver(Observer* observer);
  1030. +
  1031. + // Removes an observer. It is safe for an observer to be removed while
  1032. + // the observers are being notified.
  1033. + void RemoveObserver(Observer* observer);
  1034. +
  1035. + // Will schedule automatic updates, run in background.
  1036. + void Start();
  1037. +
  1038. + // To be called for an user-triggered update.
  1039. + // Will not result in an actual update if the last update was too recently triggered.
  1040. + bool OnDemandUpdate(Callback on_finished);
  1041. +
  1042. + private:
  1043. + void NotifyObservers(Event event);
  1044. + void OnDemandScheduledUpdate(component_updater::UpdateScheduler::OnFinishedCallback on_finished);
  1045. + bool OnDemandUpdateAsNeeded(bool is_foreground, Callback on_finished);
  1046. + void OnDemandUpdateInternal(bool is_foreground, Callback on_finished);
  1047. + void OnUpdateComplete(Callback callback, scoped_refptr<DownloadFiltersTask> task, Error error);
  1048. +
  1049. + base::ObserverList<Observer>::Unchecked observer_list_;
  1050. + base::ThreadChecker thread_checker_;
  1051. + base::TimeTicks last_update_;
  1052. +
  1053. + subresource_filter::RulesetService* ruleset_service_;
  1054. + std::string filters_url_;
  1055. +
  1056. + scoped_refptr<network::SharedURLLoaderFactory> shared_url_network_factory_;
  1057. + std::unique_ptr<component_updater::UpdateScheduler> scheduler_;
  1058. +
  1059. + bool is_updating_ = false;
  1060. + bool scheduled_ = false;
  1061. + std::set<scoped_refptr<DownloadFiltersTask>> tasks_;
  1062. +};
  1063. +
  1064. +} // namespace adblock_updater
  1065. +
  1066. +#endif // COMPONENTS_ADBLOCK_UPDATER_SERVICE_H
  1067. diff --git a/components/component_updater/download_filters_task.cc b/components/component_updater/download_filters_task.cc
  1068. new file mode 100644
  1069. --- /dev/null
  1070. +++ b/components/component_updater/download_filters_task.cc
  1071. @@ -0,0 +1,222 @@
  1072. +/*
  1073. + This file is part of Bromite.
  1074. +
  1075. + Bromite is free software: you can redistribute it and/or modify
  1076. + it under the terms of the GNU General Public License as published by
  1077. + the Free Software Foundation, either version 3 of the License, or
  1078. + (at your option) any later version.
  1079. +
  1080. + Bromite is distributed in the hope that it will be useful,
  1081. + but WITHOUT ANY WARRANTY; without even the implied warranty of
  1082. + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  1083. + GNU General Public License for more details.
  1084. +
  1085. + You should have received a copy of the GNU General Public License
  1086. + along with Bromite. If not, see <https://www.gnu.org/licenses/>.
  1087. +*/
  1088. +#include "components/component_updater/download_filters_task.h"
  1089. +
  1090. +#include <utility>
  1091. +
  1092. +#include "base/files/file_util.h"
  1093. +#include "base/bind.h"
  1094. +#include "base/location.h"
  1095. +#include "base/threading/thread_task_runner_handle.h"
  1096. +#include "base/logging.h"
  1097. +#include "net/base/load_flags.h"
  1098. +#include "url/gurl.h"
  1099. +
  1100. +namespace adblock_updater {
  1101. +
  1102. +// maximum 10MB for the filters file
  1103. +const int kMaxBodySize = 1024 * 1024 * 10;
  1104. +
  1105. +const int kMaxRetriesOnNetworkChange = 3;
  1106. +
  1107. +const net::NetworkTrafficAnnotationTag traffic_annotation =
  1108. + net::DefineNetworkTrafficAnnotation("update_client", R"(
  1109. + semantics {
  1110. + sender: "Bromite AdBlock filters updater"
  1111. + description:
  1112. + "The AdBlock filters updater is responsible for updating the subresource filters."
  1113. + trigger: "Manual or automatic AdBlock filters updates."
  1114. + data:
  1115. + "Subresource filters rulesets, binary format"
  1116. + destination: WEBSITE
  1117. + }
  1118. + )");
  1119. +
  1120. +DownloadFiltersTask::DownloadFiltersTask(scoped_refptr<network::SharedURLLoaderFactory> shared_url_network_factory,
  1121. + bool is_foreground, const std::string& filters_url, base::Time min_last_modified,
  1122. + Callback callback)
  1123. + : shared_url_network_factory_(shared_url_network_factory),
  1124. + is_foreground_(is_foreground),
  1125. + complete_callback_(std::move(callback)) {
  1126. + DCHECK(!filters_url.empty());
  1127. + filters_url_ = GURL(filters_url);
  1128. + min_last_modified_ = min_last_modified;
  1129. +
  1130. + if (filters_url.empty()) {
  1131. + return;
  1132. + }
  1133. +
  1134. + createSimpleURLLoader(!min_last_modified_.is_null());
  1135. +}
  1136. +
  1137. +void DownloadFiltersTask::createSimpleURLLoader(bool headers_only) {
  1138. + // always reset response-related fields
  1139. + response_code_ = -1;
  1140. + final_url_ = GURL();
  1141. + download_start_time_ = base::TimeTicks();
  1142. +
  1143. + auto resource_request = std::make_unique<network::ResourceRequest>();
  1144. + resource_request->url = filters_url_;
  1145. + resource_request->credentials_mode = network::mojom::CredentialsMode::kOmit;
  1146. + resource_request->load_flags = net::LOAD_BYPASS_CACHE | net::LOAD_DISABLE_CACHE | net::LOAD_DO_NOT_SAVE_COOKIES;
  1147. + resource_request->credentials_mode = network::mojom::CredentialsMode::kOmit;
  1148. + if (headers_only)
  1149. + // will chain two requests - first one is to check last modified header alone
  1150. + resource_request->method = "HEAD";
  1151. + else
  1152. + resource_request->method = "GET";
  1153. +
  1154. + simple_url_loader_ = network::SimpleURLLoader::Create(
  1155. + std::move(resource_request), traffic_annotation);
  1156. + simple_url_loader_->SetRetryOptions(
  1157. + kMaxRetriesOnNetworkChange,
  1158. + network::SimpleURLLoader::RetryMode::RETRY_ON_NETWORK_CHANGE);
  1159. + simple_url_loader_->SetAllowPartialResults(false);
  1160. + simple_url_loader_->SetOnResponseStartedCallback(base::BindOnce(
  1161. + &DownloadFiltersTask::OnResponseStarted, base::Unretained(this)));
  1162. +}
  1163. +
  1164. +DownloadFiltersTask::~DownloadFiltersTask() {
  1165. + DCHECK(thread_checker_.CalledOnValidThread());
  1166. +}
  1167. +
  1168. +void DownloadFiltersTask::Run() {
  1169. + DCHECK(thread_checker_.CalledOnValidThread());
  1170. +
  1171. + // will not be initialized if the URL was empty
  1172. + if (!simple_url_loader_) {
  1173. + TaskComplete(Error::INVALID_ARGUMENT);
  1174. + return;
  1175. + }
  1176. +
  1177. + download_start_time_ = base::TimeTicks::Now();
  1178. + if (min_last_modified_.is_null()) {
  1179. + internalDownload();
  1180. + } else {
  1181. + simple_url_loader_->DownloadHeadersOnly(
  1182. + shared_url_network_factory_.get(),
  1183. + base::BindOnce(&DownloadFiltersTask::OnHeadersDownloadComplete, base::Unretained(this))
  1184. + );
  1185. + }
  1186. +}
  1187. +
  1188. +void DownloadFiltersTask::internalDownload() {
  1189. + simple_url_loader_->DownloadToTempFile(
  1190. + shared_url_network_factory_.get(),
  1191. + base::BindOnce(&DownloadFiltersTask::OnDownloadComplete, base::Unretained(this)),
  1192. + kMaxBodySize);
  1193. +}
  1194. +
  1195. +void DownloadFiltersTask::OnHeadersDownloadComplete(scoped_refptr<net::HttpResponseHeaders> headers) {
  1196. + // something went wrong
  1197. + if (headers == nullptr) {
  1198. + OnDownloadComplete(base::FilePath());
  1199. + return;
  1200. + }
  1201. +
  1202. + // ignoring 'headers' as 'Last-Modified' has already been picked up by OnResponseStarted
  1203. + const base::TimeDelta dt =
  1204. + last_modified_ - min_last_modified_;
  1205. +
  1206. + if (dt.InSeconds() > 0) {
  1207. + // prepare for next simple URL loader and trigger download
  1208. + createSimpleURLLoader(false);
  1209. + internalDownload();
  1210. + return;
  1211. + }
  1212. +
  1213. + // the remote filters are not more recent than known ones
  1214. + TaskComplete(Error::UPDATE_NOT_NEEDED);
  1215. +}
  1216. +
  1217. +void DownloadFiltersTask::OnResponseStarted(
  1218. + const GURL& final_url,
  1219. + const network::mojom::URLResponseHead& response_head) {
  1220. +
  1221. + final_url_ = final_url;
  1222. + response_code_ = response_head.headers ? response_head.headers->response_code() : -1;
  1223. +
  1224. + if (!response_head.headers->GetLastModifiedValue(&last_modified_))
  1225. + LOG(WARNING) << "DownloadFiltersTask: fetching URL '" << final_url.spec() << "' with method " << (min_last_modified_.is_null() ? "GET" : "HEAD") << " (no Last-Modified header)";
  1226. + else
  1227. + LOG(INFO) << "DownloadFiltersTask: fetching URL '" << final_url.spec() << "' with method " << (min_last_modified_.is_null() ? "GET" : "HEAD");
  1228. +}
  1229. +
  1230. +void DownloadFiltersTask::OnDownloadComplete(base::FilePath file_path) {
  1231. + DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
  1232. + int net_error = simple_url_loader_->NetError();
  1233. + int64_t content_size = simple_url_loader_->GetContentSize();
  1234. +
  1235. + const base::TimeTicks download_end_time(base::TimeTicks::Now());
  1236. + const base::TimeDelta download_time =
  1237. + download_end_time >= download_start_time_
  1238. + ? download_end_time - download_start_time_
  1239. + : base::TimeDelta();
  1240. +
  1241. + // Consider a 5xx response from the server as an indication to terminate
  1242. + // the request and avoid overloading the server in this case.
  1243. + // is not accepting requests for the moment.
  1244. + int error = -1;
  1245. + if (!file_path.empty() && response_code_ == 200) {
  1246. + DCHECK_EQ(0, net_error);
  1247. + error = 0;
  1248. + } else if (response_code_ != -1) {
  1249. + error = response_code_;
  1250. + } else {
  1251. + error = net_error;
  1252. + }
  1253. +
  1254. + LOG(INFO) << "DownloadFiltersTask: downloaded " << content_size << " bytes in "
  1255. + << download_time.InMilliseconds() << "ms from '" << final_url_.spec()
  1256. + << "' to '" << file_path << "' with net_error " << net_error << " and error " << error;
  1257. +
  1258. + if (error) {
  1259. + TaskComplete(Error::DOWNLOAD_ERROR);
  1260. + return;
  1261. + }
  1262. +
  1263. + file_path_ = file_path;
  1264. + TaskComplete(Error::NONE);
  1265. +}
  1266. +
  1267. +void DownloadFiltersTask::Cancel() {
  1268. + DCHECK(thread_checker_.CalledOnValidThread());
  1269. +
  1270. + LOG(INFO) << "DownloadFiltersTask: update cancelled";
  1271. +
  1272. + // deletion of the simple_url_loader_ will cause cancellation of its active request, if any
  1273. +
  1274. + TaskComplete(Error::UPDATE_CANCELED);
  1275. +}
  1276. +
  1277. +void DownloadFiltersTask::TaskComplete(Error error) {
  1278. + DCHECK(thread_checker_.CalledOnValidThread());
  1279. +
  1280. + base::ThreadTaskRunnerHandle::Get()->PostTask(
  1281. + FROM_HERE, base::BindOnce(std::move(complete_callback_),
  1282. + scoped_refptr<DownloadFiltersTask>(this), error));
  1283. +}
  1284. +
  1285. +base::Time DownloadFiltersTask::last_modified() {
  1286. + return last_modified_;
  1287. +}
  1288. +
  1289. +base::FilePath DownloadFiltersTask::file_path() {
  1290. + return file_path_;
  1291. +}
  1292. +
  1293. +} // namespace adblock_updater
  1294. diff --git a/components/component_updater/download_filters_task.h b/components/component_updater/download_filters_task.h
  1295. new file mode 100644
  1296. --- /dev/null
  1297. +++ b/components/component_updater/download_filters_task.h
  1298. @@ -0,0 +1,129 @@
  1299. +/*
  1300. + This file is part of Bromite.
  1301. +
  1302. + Bromite is free software: you can redistribute it and/or modify
  1303. + it under the terms of the GNU General Public License as published by
  1304. + the Free Software Foundation, either version 3 of the License, or
  1305. + (at your option) any later version.
  1306. +
  1307. + Bromite is distributed in the hope that it will be useful,
  1308. + but WITHOUT ANY WARRANTY; without even the implied warranty of
  1309. + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  1310. + GNU General Public License for more details.
  1311. +
  1312. + You should have received a copy of the GNU General Public License
  1313. + along with Bromite. If not, see <https://www.gnu.org/licenses/>.
  1314. +*/
  1315. +
  1316. +#ifndef COMPONENTS_DOWNLOAD_FILTERS_TASK_H_
  1317. +#define COMPONENTS_DOWNLOAD_FILTERS_TASK_H_
  1318. +
  1319. +#include <string>
  1320. +#include <vector>
  1321. +
  1322. +#include "base/callback.h"
  1323. +#include "base/macros.h"
  1324. +#include "base/memory/ref_counted.h"
  1325. +#include "base/threading/thread_checker.h"
  1326. +#include "components/update_client/network.h"
  1327. +#include "url/gurl.h"
  1328. +#include "base/files/file_path.h"
  1329. +#include "services/network/public/cpp/shared_url_loader_factory.h"
  1330. +#include "services/network/public/cpp/simple_url_loader.h"
  1331. +
  1332. +namespace adblock_updater {
  1333. +
  1334. +// Errors generated as a result of calling Run() or by the service itself (UPDATE_IN_PROGRESS or UPDATE_CANCELED)
  1335. +enum class Error {
  1336. + NONE = 0,
  1337. + UPDATE_IN_PROGRESS = 1,
  1338. + UPDATE_CANCELED = 2,
  1339. + UPDATE_NOT_NEEDED = 3,
  1340. + DOWNLOAD_ERROR = 4,
  1341. + INVALID_ARGUMENT = 5,
  1342. + MAX_VALUE,
  1343. +};
  1344. +
  1345. +enum class Event {
  1346. + // Sent before the update client does an update check.
  1347. + ADBLOCK_CHECKING_FOR_UPDATES = 1,
  1348. +
  1349. + // Sent after the new filters have been downloaded but before the install
  1350. + // or the upgrade is attempted.
  1351. + ADBLOCK_UPDATE_READY,
  1352. +
  1353. + // Sent when filters are being downloaded.
  1354. + ADBLOCK_UPDATE_DOWNLOADING,
  1355. +
  1356. + // Sent when filters have been successfully updated.
  1357. + ADBLOCK_UPDATED,
  1358. +
  1359. + // Sent when filters have not been updated because there
  1360. + // was no new version available
  1361. + //TODO: implement this with the headers check
  1362. + ADBLOCK_NOT_UPDATED,
  1363. +
  1364. + // Sent when an error ocurred during an update for any reason, including
  1365. + // the update check itself failed, or the download of the update payload
  1366. + // failed, or applying the update failed.
  1367. + ADBLOCK_UPDATE_ERROR,
  1368. +};
  1369. +
  1370. +// Defines a specialized task for updating AdBlock filters.
  1371. +class DownloadFiltersTask : public base::RefCounted<DownloadFiltersTask> {
  1372. + public:
  1373. + using Callback =
  1374. + base::OnceCallback<void(scoped_refptr<DownloadFiltersTask> task, Error error)>;
  1375. +
  1376. + // |shared_url_network_factory| is injected here for the URL loader factory.
  1377. + // |is_foreground| is true when the update task is initiated by the user.
  1378. + // |filters_url| is the URL to load filters from.
  1379. + // |complete_callback| is called to return the execution flow back to creator of
  1380. + // this task when the task is done.
  1381. + DownloadFiltersTask(scoped_refptr<network::SharedURLLoaderFactory> shared_url_network_factory,
  1382. + bool is_foreground, const std::string& filters_url, base::Time min_last_modified,
  1383. + Callback complete_callback);
  1384. +
  1385. + void Run();
  1386. +
  1387. + void Cancel();
  1388. +
  1389. + base::FilePath file_path();
  1390. +
  1391. + base::Time last_modified();
  1392. +
  1393. + private:
  1394. + ~DownloadFiltersTask();
  1395. +
  1396. + void OnDownloadProgress(uint64_t current);
  1397. + void OnResponseStarted(const GURL& final_url,
  1398. + const network::mojom::URLResponseHead& response_head);
  1399. + void OnDownloadComplete(base::FilePath file_path);
  1400. + void OnHeadersDownloadComplete(scoped_refptr<net::HttpResponseHeaders> headers);
  1401. + void createSimpleURLLoader(bool);
  1402. + void internalDownload();
  1403. +
  1404. + // Called when the task has completed either because the task has run or
  1405. + // it has been canceled.
  1406. + void TaskComplete(Error error);
  1407. +
  1408. + base::ThreadChecker thread_checker_;
  1409. + scoped_refptr<network::SharedURLLoaderFactory> shared_url_network_factory_;
  1410. + const bool is_foreground_;
  1411. + Callback complete_callback_;
  1412. + std::unique_ptr<network::SimpleURLLoader> simple_url_loader_;
  1413. +
  1414. + // fields populated while downloading
  1415. + base::TimeTicks download_start_time_;
  1416. + GURL final_url_, filters_url_;
  1417. + int response_code_;
  1418. + base::Time last_modified_, min_last_modified_;
  1419. + base::FilePath file_path_;
  1420. +
  1421. + friend class base::RefCounted<DownloadFiltersTask>;
  1422. + DISALLOW_COPY_AND_ASSIGN(DownloadFiltersTask);
  1423. +};
  1424. +
  1425. +} // namespace update_client
  1426. +
  1427. +#endif // COMPONENTS_DOWNLOAD_FILTERS_TASK_H_
  1428. diff --git a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
  1429. --- a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
  1430. +++ b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
  1431. @@ -551,6 +551,17 @@ ContentSubresourceFilterThrottleManager::
  1432. throttle->NotifyPageActivationWithRuleset(EnsureRulesetHandle(),
  1433. ad_tagging_state);
  1434. }
  1435. +
  1436. + //TODO: could use same logic as in SubresourceFilterSafeBrowsingActivationThrottle::NotifyResult()
  1437. + {
  1438. + subresource_filter::ActivationDecision ignored_decision;
  1439. + mojom::ActivationState ad_filtering_state;
  1440. + ad_filtering_state.activation_level = client_->OnPageActivationComputed(
  1441. + navigation_handle, mojom::ActivationLevel::kEnabled, &ignored_decision);
  1442. + throttle->NotifyPageActivationWithRuleset(EnsureRulesetHandle(),
  1443. + ad_filtering_state);
  1444. + }
  1445. +
  1446. return throttle;
  1447. }
  1448. diff --git a/components/subresource_filter/content/browser/ruleset_service.cc b/components/subresource_filter/content/browser/ruleset_service.cc
  1449. --- a/components/subresource_filter/content/browser/ruleset_service.cc
  1450. +++ b/components/subresource_filter/content/browser/ruleset_service.cc
  1451. @@ -47,9 +47,7 @@ namespace {
  1452. void RecordIndexAndWriteRulesetResult(
  1453. RulesetService::IndexAndWriteRulesetResult result) {
  1454. - UMA_HISTOGRAM_ENUMERATION(
  1455. - "SubresourceFilter.WriteRuleset.Result", static_cast<int>(result),
  1456. - static_cast<int>(RulesetService::IndexAndWriteRulesetResult::MAX));
  1457. + VLOG(1) << "SubresourceFilter.WriteRuleset.Result: " << static_cast<int>(result);
  1458. }
  1459. // Implements operations on a `sentinel file`, which is used as a safeguard to
  1460. @@ -228,10 +226,13 @@ RulesetService::RulesetService(
  1461. RulesetService::~RulesetService() {}
  1462. void RulesetService::IndexAndStoreAndPublishRulesetIfNeeded(
  1463. - const UnindexedRulesetInfo& unindexed_ruleset_info) {
  1464. - if (unindexed_ruleset_info.content_version.empty())
  1465. + const UnindexedRulesetInfo& unindexed_ruleset_info, bool ignore_recent_version) {
  1466. + if (unindexed_ruleset_info.content_version.empty()) {
  1467. + LOG(INFO) << "RulesetService: ignoring update with empty version.";
  1468. return;
  1469. + }
  1470. + if (!ignore_recent_version) {
  1471. // Trying to store a ruleset with the same version for a second time would
  1472. // not only be futile, but would fail on Windows due to "File System
  1473. // Tunneling" as long as the previously stored copy of the rules is still
  1474. @@ -241,13 +242,16 @@ void RulesetService::IndexAndStoreAndPublishRulesetIfNeeded(
  1475. if (most_recently_indexed_version.IsCurrentFormatVersion() &&
  1476. most_recently_indexed_version.content_version ==
  1477. unindexed_ruleset_info.content_version) {
  1478. + LOG(INFO) << "RulesetService: ignoring update with equal or older version.";
  1479. return;
  1480. }
  1481. + }
  1482. // Before initialization, retain information about the most recently supplied
  1483. // unindexed ruleset, to be processed during initialization.
  1484. if (!is_initialized_) {
  1485. queued_unindexed_ruleset_info_ = unindexed_ruleset_info;
  1486. + LOG(INFO) << "RulesetService: ignoring update while not initialized.";
  1487. return;
  1488. }
  1489. @@ -266,6 +270,18 @@ IndexedRulesetVersion RulesetService::GetMostRecentlyIndexedVersion() const {
  1490. IndexedRulesetVersion RulesetService::IndexAndWriteRuleset(
  1491. const base::FilePath& indexed_ruleset_base_dir,
  1492. const UnindexedRulesetInfo& unindexed_ruleset_info) {
  1493. + IndexedRulesetVersion version = IndexAndWriteRulesetInternal(indexed_ruleset_base_dir, unindexed_ruleset_info);
  1494. + // cleanup temporary file when done
  1495. + if (unindexed_ruleset_info.delete_ruleset_path) {
  1496. + base::DeleteFile(unindexed_ruleset_info.ruleset_path);
  1497. + }
  1498. + return version;
  1499. +}
  1500. +
  1501. +// static
  1502. +IndexedRulesetVersion RulesetService::IndexAndWriteRulesetInternal(
  1503. + const base::FilePath& indexed_ruleset_base_dir,
  1504. + const UnindexedRulesetInfo& unindexed_ruleset_info) {
  1505. base::ScopedBlockingCall scoped_blocking_call(FROM_HERE,
  1506. base::BlockingType::MAY_BLOCK);
  1507. @@ -273,6 +289,7 @@ IndexedRulesetVersion RulesetService::IndexAndWriteRuleset(
  1508. unindexed_ruleset_info);
  1509. if (!unindexed_ruleset_stream_generator.ruleset_stream()) {
  1510. + LOG(WARNING) << "RulesetService: failed to open: " << unindexed_ruleset_info.ruleset_path;
  1511. RecordIndexAndWriteRulesetResult(
  1512. IndexAndWriteRulesetResult::FAILED_OPENING_UNINDEXED_RULESET);
  1513. return IndexedRulesetVersion();
  1514. @@ -286,6 +303,7 @@ IndexedRulesetVersion RulesetService::IndexAndWriteRuleset(
  1515. indexed_ruleset_base_dir, indexed_version);
  1516. if (!base::CreateDirectory(indexed_ruleset_version_dir)) {
  1517. + LOG(WARNING) << "RulesetService: failed to create version dir: " << indexed_ruleset_version_dir;
  1518. RecordIndexAndWriteRulesetResult(
  1519. IndexAndWriteRulesetResult::FAILED_CREATING_VERSION_DIR);
  1520. return IndexedRulesetVersion();
  1521. @@ -311,6 +329,7 @@ IndexedRulesetVersion RulesetService::IndexAndWriteRuleset(
  1522. RulesetIndexer indexer;
  1523. if (!(*g_index_ruleset_func)(&unindexed_ruleset_stream_generator, &indexer)) {
  1524. + LOG(WARNING) << "RulesetService: failed parsing.";
  1525. RecordIndexAndWriteRulesetResult(
  1526. IndexAndWriteRulesetResult::FAILED_PARSING_UNINDEXED_RULESET);
  1527. return IndexedRulesetVersion();
  1528. @@ -331,6 +350,8 @@ IndexedRulesetVersion RulesetService::IndexAndWriteRuleset(
  1529. if (result != IndexAndWriteRulesetResult::SUCCESS)
  1530. return IndexedRulesetVersion();
  1531. + LOG(INFO) << "RulesetService: successful parsing.";
  1532. +
  1533. DCHECK(indexed_version.IsValid());
  1534. return indexed_version;
  1535. }
  1536. @@ -455,6 +476,7 @@ void RulesetService::IndexAndStoreRuleset(
  1537. void RulesetService::OnWrittenRuleset(WriteRulesetCallback result_callback,
  1538. const IndexedRulesetVersion& version) {
  1539. DCHECK(!result_callback.is_null());
  1540. + LOG(INFO) << "RulesetService: valid version: " << version.IsValid();
  1541. if (!version.IsValid())
  1542. return;
  1543. version.SaveToPrefs(local_state_);
  1544. @@ -467,7 +489,6 @@ void RulesetService::OpenAndPublishRuleset(
  1545. IndexedRulesetLocator::GetRulesetDataFilePath(
  1546. IndexedRulesetLocator::GetSubdirectoryPathForVersion(
  1547. indexed_ruleset_base_dir_, version));
  1548. -
  1549. publisher_->TryOpenAndSetRulesetFile(
  1550. file_path, version.checksum,
  1551. base::BindOnce(&RulesetService::OnRulesetSet, AsWeakPtr()));
  1552. diff --git a/components/subresource_filter/content/browser/ruleset_service.h b/components/subresource_filter/content/browser/ruleset_service.h
  1553. --- a/components/subresource_filter/content/browser/ruleset_service.h
  1554. +++ b/components/subresource_filter/content/browser/ruleset_service.h
  1555. @@ -182,7 +182,7 @@ class RulesetService : public base::SupportsWeakPtr<RulesetService> {
  1556. //
  1557. // Virtual so that it can be mocked out in tests.
  1558. virtual void IndexAndStoreAndPublishRulesetIfNeeded(
  1559. - const UnindexedRulesetInfo& unindexed_ruleset_info);
  1560. + const UnindexedRulesetInfo& unindexed_ruleset_info, bool ignore_recent_version = false);
  1561. // Get the ruleset version associated with the current local_state_.
  1562. IndexedRulesetVersion GetMostRecentlyIndexedVersion() const;
  1563. @@ -215,6 +215,11 @@ class RulesetService : public base::SupportsWeakPtr<RulesetService> {
  1564. const base::FilePath& indexed_ruleset_base_dir,
  1565. const UnindexedRulesetInfo& unindexed_ruleset_info);
  1566. + // internal function used to wrap the temporary file deletion for unindexed rulesets
  1567. + static IndexedRulesetVersion IndexAndWriteRulesetInternal(
  1568. + const base::FilePath& indexed_ruleset_base_dir,
  1569. + const UnindexedRulesetInfo& unindexed_ruleset_info);
  1570. +
  1571. // Reads the rules via the |unindexed_ruleset_stream_generator|, and indexes
  1572. // them using |indexer|. Returns whether the entire ruleset could be parsed.
  1573. static bool IndexRuleset(
  1574. diff --git a/components/subresource_filter/content/browser/ruleset_version.h b/components/subresource_filter/content/browser/ruleset_version.h
  1575. --- a/components/subresource_filter/content/browser/ruleset_version.h
  1576. +++ b/components/subresource_filter/content/browser/ruleset_version.h
  1577. @@ -53,6 +53,10 @@ struct UnindexedRulesetInfo {
  1578. // can be indicated not only by setting |license_path| to empty, but also by
  1579. // setting it to any non existent path.
  1580. base::FilePath license_path;
  1581. +
  1582. + // Whether to delete or not the ruleset path once done indexing; useful for disposal
  1583. + // of temporary files.
  1584. + bool delete_ruleset_path;
  1585. };
  1586. // Encapsulates the combination of the binary format version of the indexed
  1587. diff --git a/components/subresource_filter/content/browser/verified_ruleset_dealer.cc b/components/subresource_filter/content/browser/verified_ruleset_dealer.cc
  1588. --- a/components/subresource_filter/content/browser/verified_ruleset_dealer.cc
  1589. +++ b/components/subresource_filter/content/browser/verified_ruleset_dealer.cc
  1590. @@ -11,6 +11,7 @@
  1591. #include "base/check.h"
  1592. #include "base/files/file.h"
  1593. #include "base/location.h"
  1594. +#include "base/logging.h"
  1595. #include "base/metrics/histogram_macros.h"
  1596. #include "base/notreached.h"
  1597. #include "base/task_runner_util.h"
  1598. @@ -36,6 +37,8 @@ base::File VerifiedRulesetDealer::OpenAndSetRulesetFile(
  1599. TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("loading"),
  1600. "VerifiedRulesetDealer::OpenAndSetRulesetFile", "file_valid",
  1601. file.IsValid());
  1602. +
  1603. + LOG(INFO) << "OpenAndSetRulesetFile: " << file_path << " is valid: " << file.IsValid();
  1604. if (file.IsValid()) {
  1605. SetRulesetFile(file.Duplicate());
  1606. expected_checksum_ = expected_checksum;
  1607. diff --git a/components/subresource_filter/core/browser/subresource_filter_features.cc b/components/subresource_filter/core/browser/subresource_filter_features.cc
  1608. --- a/components/subresource_filter/core/browser/subresource_filter_features.cc
  1609. +++ b/components/subresource_filter/core/browser/subresource_filter_features.cc
  1610. @@ -53,69 +53,7 @@ class CommaSeparatedStrings {
  1611. DISALLOW_COPY_AND_ASSIGN(CommaSeparatedStrings);
  1612. };
  1613. -std::string TakeVariationParamOrReturnEmpty(
  1614. - std::map<std::string, std::string>* params,
  1615. - const std::string& key) {
  1616. - auto it = params->find(key);
  1617. - if (it == params->end())
  1618. - return std::string();
  1619. - std::string value = std::move(it->second);
  1620. - params->erase(it);
  1621. - return value;
  1622. -}
  1623. -
  1624. -mojom::ActivationLevel ParseActivationLevel(
  1625. - const base::StringPiece activation_level) {
  1626. - if (base::LowerCaseEqualsASCII(activation_level, kActivationLevelEnabled))
  1627. - return mojom::ActivationLevel::kEnabled;
  1628. - else if (base::LowerCaseEqualsASCII(activation_level, kActivationLevelDryRun))
  1629. - return mojom::ActivationLevel::kDryRun;
  1630. - return mojom::ActivationLevel::kDisabled;
  1631. -}
  1632. -
  1633. -ActivationScope ParseActivationScope(const base::StringPiece activation_scope) {
  1634. - if (base::LowerCaseEqualsASCII(activation_scope, kActivationScopeAllSites))
  1635. - return ActivationScope::ALL_SITES;
  1636. - else if (base::LowerCaseEqualsASCII(activation_scope,
  1637. - kActivationScopeActivationList))
  1638. - return ActivationScope::ACTIVATION_LIST;
  1639. - return ActivationScope::NO_SITES;
  1640. -}
  1641. -
  1642. -ActivationList ParseActivationList(std::string activation_lists_string) {
  1643. - CommaSeparatedStrings activation_lists(std::move(activation_lists_string));
  1644. - if (activation_lists.CaseInsensitiveContains(
  1645. - kActivationListPhishingInterstitial)) {
  1646. - return ActivationList::PHISHING_INTERSTITIAL;
  1647. - } else if (activation_lists.CaseInsensitiveContains(
  1648. - kActivationListSocialEngineeringAdsInterstitial)) {
  1649. - return ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL;
  1650. - } else if (activation_lists.CaseInsensitiveContains(
  1651. - kActivationListSubresourceFilter)) {
  1652. - return ActivationList::SUBRESOURCE_FILTER;
  1653. - } else if (activation_lists.CaseInsensitiveContains(
  1654. - kActivationListBetterAds)) {
  1655. - return ActivationList::BETTER_ADS;
  1656. - }
  1657. - return ActivationList::NONE;
  1658. -}
  1659. -
  1660. -// Will return a value between 0 and 1 inclusive.
  1661. -double ParsePerformanceMeasurementRate(const std::string& rate) {
  1662. - double value = 0.0;
  1663. - if (!base::StringToDouble(rate, &value) || value < 0)
  1664. - return 0.0;
  1665. - return value < 1 ? value : 1;
  1666. -}
  1667. -
  1668. -int ParseInt(const base::StringPiece value) {
  1669. - int result = 0;
  1670. - base::StringToInt(value, &result);
  1671. - return result;
  1672. -}
  1673. -
  1674. -std::vector<Configuration> FillEnabledPresetConfigurations(
  1675. - std::map<std::string, std::string>* params) {
  1676. +std::vector<Configuration> FillEnabledPresetConfigurations() {
  1677. // If ad tagging is enabled, turn on the dryrun automatically.
  1678. bool ad_tagging_enabled = base::FeatureList::IsEnabled(kAdTagging);
  1679. const struct {
  1680. @@ -123,23 +61,16 @@ std::vector<Configuration> FillEnabledPresetConfigurations(
  1681. bool enabled_by_default;
  1682. Configuration (*factory_method)();
  1683. } kAvailablePresetConfigurations[] = {
  1684. - {kPresetLiveRunOnPhishingSites, true,
  1685. + {kPresetLiveRunOnPhishingSites, false,
  1686. &Configuration::MakePresetForLiveRunOnPhishingSites},
  1687. {kPresetPerformanceTestingDryRunOnAllSites, ad_tagging_enabled,
  1688. &Configuration::MakePresetForPerformanceTestingDryRunOnAllSites},
  1689. {kPresetLiveRunForBetterAds, true,
  1690. &Configuration::MakePresetForLiveRunForBetterAds}};
  1691. - CommaSeparatedStrings enabled_presets(
  1692. - TakeVariationParamOrReturnEmpty(params, kEnablePresetsParameterName));
  1693. - CommaSeparatedStrings disabled_presets(
  1694. - TakeVariationParamOrReturnEmpty(params, kDisablePresetsParameterName));
  1695. -
  1696. std::vector<Configuration> enabled_configurations;
  1697. for (const auto& available_preset : kAvailablePresetConfigurations) {
  1698. - if ((enabled_presets.CaseInsensitiveContains(available_preset.name) ||
  1699. - available_preset.enabled_by_default) &&
  1700. - !disabled_presets.CaseInsensitiveContains(available_preset.name)) {
  1701. + if (available_preset.enabled_by_default) {
  1702. enabled_configurations.push_back(available_preset.factory_method());
  1703. }
  1704. }
  1705. @@ -147,46 +78,10 @@ std::vector<Configuration> FillEnabledPresetConfigurations(
  1706. return enabled_configurations;
  1707. }
  1708. -Configuration ParseExperimentalConfiguration(
  1709. - std::map<std::string, std::string>* params) {
  1710. - Configuration configuration;
  1711. -
  1712. - // ActivationConditions:
  1713. - configuration.activation_conditions.activation_scope = ParseActivationScope(
  1714. - TakeVariationParamOrReturnEmpty(params, kActivationScopeParameterName));
  1715. -
  1716. - configuration.activation_conditions.activation_list = ParseActivationList(
  1717. - TakeVariationParamOrReturnEmpty(params, kActivationListsParameterName));
  1718. -
  1719. - configuration.activation_conditions.priority =
  1720. - ParseInt(TakeVariationParamOrReturnEmpty(
  1721. - params, kActivationPriorityParameterName));
  1722. -
  1723. - // ActivationOptions:
  1724. - configuration.activation_options.activation_level = ParseActivationLevel(
  1725. - TakeVariationParamOrReturnEmpty(params, kActivationLevelParameterName));
  1726. -
  1727. - configuration.activation_options.performance_measurement_rate =
  1728. - ParsePerformanceMeasurementRate(TakeVariationParamOrReturnEmpty(
  1729. - params, kPerformanceMeasurementRateParameterName));
  1730. -
  1731. - // GeneralSettings:
  1732. - configuration.general_settings.ruleset_flavor =
  1733. - TakeVariationParamOrReturnEmpty(params, kRulesetFlavorParameterName);
  1734. -
  1735. - return configuration;
  1736. -}
  1737. -
  1738. std::vector<Configuration> ParseEnabledConfigurations() {
  1739. - std::map<std::string, std::string> params;
  1740. - base::GetFieldTrialParamsByFeature(kSafeBrowsingSubresourceFilter, &params);
  1741. -
  1742. std::vector<Configuration> configs;
  1743. if (base::FeatureList::IsEnabled(kSafeBrowsingSubresourceFilter))
  1744. - configs = FillEnabledPresetConfigurations(&params);
  1745. -
  1746. - Configuration experimental_config = ParseExperimentalConfiguration(&params);
  1747. - configs.push_back(std::move(experimental_config));
  1748. + configs = FillEnabledPresetConfigurations();
  1749. return configs;
  1750. }
  1751. diff --git a/components/subresource_filter/core/common/common_features.cc b/components/subresource_filter/core/common/common_features.cc
  1752. --- a/components/subresource_filter/core/common/common_features.cc
  1753. +++ b/components/subresource_filter/core/common/common_features.cc
  1754. @@ -6,6 +6,6 @@
  1755. namespace subresource_filter {
  1756. -const base::Feature kAdTagging{"AdTagging", base::FEATURE_ENABLED_BY_DEFAULT};
  1757. +const base::Feature kAdTagging{"AdTagging", base::FEATURE_DISABLED_BY_DEFAULT};
  1758. } // namespace subresource_filter
  1759. diff --git a/content/browser/renderer_host/navigation_throttle_runner.cc b/content/browser/renderer_host/navigation_throttle_runner.cc
  1760. --- a/content/browser/renderer_host/navigation_throttle_runner.cc
  1761. +++ b/content/browser/renderer_host/navigation_throttle_runner.cc
  1762. @@ -131,11 +131,6 @@ void NavigationThrottleRunner::RegisterNavigationThrottles() {
  1763. // than other throttles that might care about those navigations, e.g.
  1764. // throttles handling pages with 407 errors that require extra authentication.
  1765. AddThrottle(HttpErrorNavigationThrottle::MaybeCreateThrottleFor(*request));
  1766. -
  1767. - // Insert all testing NavigationThrottles last.
  1768. - throttles_.insert(throttles_.end(),
  1769. - std::make_move_iterator(testing_throttles.begin()),
  1770. - std::make_move_iterator(testing_throttles.end()));
  1771. }
  1772. NavigationThrottle* NavigationThrottleRunner::GetDeferringThrottle() const {
  1773. --
  1774. 2.17.1