Add-option-to-not-persist-tabs-across-sessions.patch 6.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124
  1. From: csagan5 <32685696+csagan5@users.noreply.github.com>
  2. Date: Sat, 7 Sep 2019 15:07:42 +0200
  3. Subject: Add option to not persist tabs across sessions
  4. ---
  5. chrome/android/java/res/values/values.xml | 3 +++
  6. chrome/android/java/res/xml/privacy_preferences.xml | 5 +++++
  7. .../chrome/browser/ChromeTabbedActivity.java | 4 +++-
  8. .../browser/privacy/settings/PrivacySettings.java | 12 ++++++++++++
  9. .../ui/android/strings/android_chrome_strings.grd | 6 ++++++
  10. 5 files changed, 29 insertions(+), 1 deletion(-)
  11. diff --git a/chrome/android/java/res/values/values.xml b/chrome/android/java/res/values/values.xml
  12. --- a/chrome/android/java/res/values/values.xml
  13. +++ b/chrome/android/java/res/values/values.xml
  14. @@ -60,6 +60,9 @@
  15. <!-- TODO(peconn): Add help section. -->
  16. <!-- <string name="help_context_suggestions">mobile_content_suggestions</string> -->
  17. + <string name="close_tabs_on_exit_title">Close tabs on exit</string>
  18. + <string name="close_tabs_on_exit_summary">Don\'t persist tabs between browsing sessions</string>
  19. +
  20. <!-- Our manage space activity. Default pre-KitKat to be nothing. -->
  21. <string name="manage_space_activity"></string>
  22. diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/android/java/res/xml/privacy_preferences.xml
  23. --- a/chrome/android/java/res/xml/privacy_preferences.xml
  24. +++ b/chrome/android/java/res/xml/privacy_preferences.xml
  25. @@ -34,6 +34,11 @@
  26. android:title="@string/allow_custom_tab_intents_title"
  27. android:summary="@string/allow_custom_tab_intents_summary"
  28. android:defaultValue="false" />
  29. + <org.chromium.components.browser_ui.settings.ChromeBaseCheckBoxPreference
  30. + android:key="close_tabs_on_exit"
  31. + android:title="@string/close_tabs_on_exit_title"
  32. + android:summary="@string/close_tabs_on_exit_summary"
  33. + android:defaultValue="false" />
  34. <Preference
  35. android:key="clear_browsing_data"
  36. android:title="@string/clear_browsing_data_title"
  37. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
  38. --- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
  39. +++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
  40. @@ -1173,8 +1173,10 @@ public class ChromeTabbedActivity
  41. boolean hadCipherData =
  42. CipherFactory.getInstance().restoreFromBundle(getSavedInstanceState());
  43. + String PREF_CLOSE_TABS_ON_EXIT = "close_tabs_on_exit";
  44. boolean noRestoreState =
  45. - CommandLine.getInstance().hasSwitch(ChromeSwitches.NO_RESTORE_STATE);
  46. + CommandLine.getInstance().hasSwitch(ChromeSwitches.NO_RESTORE_STATE) ||
  47. + ContextUtils.getAppSharedPreferences().getBoolean(PREF_CLOSE_TABS_ON_EXIT, false);
  48. if (noRestoreState) {
  49. // Clear the state files because they are inconsistent and useless from now on.
  50. mTabModelSelectorImpl.clearState();
  51. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
  52. --- a/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
  53. +++ b/chrome/android/java/src/org/chromium/chrome/browser/privacy/settings/PrivacySettings.java
  54. @@ -4,6 +4,7 @@
  55. package org.chromium.chrome.browser.privacy.settings;
  56. +import android.content.SharedPreferences;
  57. import android.os.Bundle;
  58. import android.view.Menu;
  59. import android.view.MenuInflater;
  60. @@ -14,6 +15,7 @@ import androidx.preference.Preference;
  61. import androidx.preference.PreferenceFragmentCompat;
  62. import androidx.vectordrawable.graphics.drawable.VectorDrawableCompat;
  63. +import org.chromium.base.ContextUtils;
  64. import org.chromium.base.BuildInfo;
  65. import org.chromium.chrome.R;
  66. import org.chromium.chrome.browser.flags.ChromeFeatureList;
  67. @@ -40,6 +42,7 @@ public class PrivacySettings
  68. private static final String PREF_SEARCH_SUGGESTIONS = "search_suggestions";
  69. private static final String PREF_CAN_MAKE_PAYMENT = "can_make_payment";
  70. private static final String PREF_NETWORK_PREDICTIONS = "preload_pages";
  71. + private static final String PREF_CLOSE_TABS_ON_EXIT = "close_tabs_on_exit";
  72. private static final String PREF_DO_NOT_TRACK = "do_not_track";
  73. private static final String PREF_CLEAR_BROWSING_DATA = "clear_browsing_data";
  74. @@ -88,6 +91,10 @@ public class PrivacySettings
  75. sharedPreferencesEditor.apply();
  76. } else if (PREF_SEARCH_SUGGESTIONS.equals(key)) {
  77. PrefServiceBridge.getInstance().setBoolean(Pref.SEARCH_SUGGEST_ENABLED, (boolean) newValue);
  78. + } else if (PREF_CLOSE_TABS_ON_EXIT.equals(key)) {
  79. + SharedPreferences.Editor sharedPreferencesEditor = ContextUtils.getAppSharedPreferences().edit();
  80. + sharedPreferencesEditor.putBoolean(PREF_CLOSE_TABS_ON_EXIT, (boolean)newValue);
  81. + sharedPreferencesEditor.apply();
  82. }
  83. return true;
  84. @@ -132,6 +139,11 @@ public class PrivacySettings
  85. ? R.string.text_on
  86. : R.string.text_off);
  87. }
  88. +
  89. + ChromeBaseCheckBoxPreference closeTabsOnExitPref =
  90. + (ChromeBaseCheckBoxPreference) findPreference(PREF_CLOSE_TABS_ON_EXIT);
  91. + closeTabsOnExitPref.setOnPreferenceChangeListener(this);
  92. + closeTabsOnExitPref.setManagedPreferenceDelegate(mManagedPreferenceDelegate);
  93. }
  94. private ChromeManagedPreferenceDelegate createManagedPreferenceDelegate() {
  95. diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
  96. --- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
  97. +++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
  98. @@ -3196,6 +3196,12 @@ Only you can see what your camera is looking at. The site can't see your camera'
  99. <message name="IDS_CONTEXTMENU_IMAGE_TITLE" desc="The title of a context menu tab when the item pressed contains more than one type. This indicates that all the actions are related to the image.">
  100. IMAGE
  101. </message>
  102. + <message name="IDS_CLOSE_TABS_ON_EXIT_TITLE" desc="Text for 'Close tabs on exit' settings-privacy option.">
  103. + Close all open tabs on exit
  104. + </message>
  105. + <message name="IDS_CLOSE_TABS_ON_EXIT_SUMMARY" desc="Summary text for 'Close tabs on exit' settings-privacy option.">
  106. + Don't persist tabs between browsing sessions
  107. + </message>
  108. <message name="IDS_CONTEXTMENU_LINK_TITLE" desc="The title of a context menu tab when the item pressed contains more than one type. This indicates that all the actions are related to the link.">
  109. LINK
  110. </message>
  111. --
  112. 2.17.1