1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889 |
- From: Serg <serg.zhukovsky@gmail.com>
- Date: Tue, 31 Jan 2017 22:12:27 -0500
- Subject: Add exit menu item
- Corrected Exit functionality
- ---
- chrome/android/java/res/menu/main_menu.xml | 4 ++++
- .../src/org/chromium/chrome/browser/ChromeActivity.java | 7 +++++++
- .../chrome/browser/init/ChromeLifetimeController.java | 6 +++++-
- .../browser/ui/android/strings/android_chrome_strings.grd | 3 +++
- 4 files changed, 19 insertions(+), 1 deletion(-)
- diff --git a/chrome/android/java/res/menu/main_menu.xml b/chrome/android/java/res/menu/main_menu.xml
- --- a/chrome/android/java/res/menu/main_menu.xml
- +++ b/chrome/android/java/res/menu/main_menu.xml
- @@ -87,6 +87,8 @@
- android:title="@string/menu_help" />
- <item android:id="@+id/enter_vr_id"
- android:title="@string/enter_vr" />
- + <item android:id="@+id/exit_id"
- + android:title="@string/menu_exit" />
- </group>
-
- <!-- Items shown only in the tab switcher -->
- @@ -104,6 +106,8 @@
- android:title="@string/menu_group_tabs" />
- <item android:id="@id/preferences_id"
- android:title="@string/menu_settings" />
- + <item android:id="@+id/exit_id"
- + android:title="@string/menu_exit" />
- </group>
-
- <!-- Items shown only in the tab switcher when start surface is enabled -->
- diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
- --- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
- +++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
- @@ -1920,6 +1920,11 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
- RecordUserAction.record("MobileMenuSettings");
- }
-
- + if (id == R.id.exit_id) {
- + ApplicationLifetime.terminate(false);
- + return true;
- + }
- +
- if (id == R.id.update_menu_id) {
- UpdateMenuItemHelper.getInstance().onMenuItemClicked(this);
- return true;
- @@ -1996,6 +2001,8 @@ public abstract class ChromeActivity<C extends ChromeActivityComponent>
- AddToHomescreenCoordinator.showForAppMenu(
- this, getWindowAndroid(), getModalDialogManager(), currentTab.getWebContents());
- RecordUserAction.record("MobileMenuAddToHomescreen");
- + } else if (id == R.id.exit_id) {
- + ApplicationLifetime.terminate(false);
- } else if (id == R.id.open_webapk_id) {
- Context context = ContextUtils.getApplicationContext();
- String packageName =
- diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java b/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java
- --- a/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java
- +++ b/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java
- @@ -82,7 +82,11 @@ class ChromeLifetimeController implements ApplicationLifetime.Observer,
-
- // Kick off a timer to kill the process after a delay, which fires only if the Activities
- // take too long to be finished.
- - mHandler.postDelayed(mRestartRunnable, WATCHDOG_DELAY_MS);
- + if (restart) {
- + mHandler.postDelayed(mRestartRunnable, WATCHDOG_DELAY_MS);
- + } else {
- + fireBrowserRestartActivityIntent();
- + }
- }
-
- @Override
- diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
- --- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
- +++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
- @@ -2413,6 +2413,9 @@ To change this setting, <ph name="BEGIN_LINK"><resetlink></ph>reset sync<p
- <message name="IDS_MENU_SETTINGS" desc="Menu item for opening browser settings. [CHAR-LIMIT=27]">
- Settings
- </message>
- + <message name="IDS_MENU_EXIT" desc="Menu item for exit browser. [CHAR-LIMIT=27]">
- + Exit
- + </message>
- <message name="IDS_MENU_CLOSE_ALL_TABS" desc="Menu item for closing all open tabs. [CHAR-LIMIT=27]">
- Close all tabs
- </message>
- --
- 2.17.1
|